parse-kickstart doesn't use SimpleConfig and wasn't quoting everything.
These files are shell executables so everything needs to be quoted to
prevent accidentally trying to run unexpected binaries.
Resolves: rhbz#1279131
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/446
Having the original un-modified kickstart can sometimes be useful,
include it in /var/log/anaconda/ks.cfg
Resolves: rhbz#1227939
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/447
This is one potential approach to help with #1183880 . It
changes the deleteAll behaviour as follows:
* Partitions known to be shared with other OSes won't be deleted
* Boot partitions won't be deleted if there are unknown parts
You can delete these partitions only by specifically targeting
them. It also adds a variant of the ConfirmDeleteDialog for
boot partitions, with text specifically explaining that they
might be needed for other OSes to boot.
This is my alternative to #377 - I'm just providing it as an option. We could pull the ConfirmDeleteDialog change out of this as a standalone to go along with dlehman's minimal change to the 'delete other partitions' text, also?
--
To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/383
libbytesize provides an implementation of what we need for manipulations and
calculations with sizes in bytes. It's a little bit faster and more importantly
it can be shared with other projects because it's written in C. Thus we should
use it.
At some point it would be nice if we could drop our own Size class and the
blivet/size.py module altogether because they don't bring any extra value, but
for now we need this thin wrapper to keep the API (almost*) stable. The only
real changes are:
1) Strings like "100 kibibytes" are no longer accepted, I doubt anybody has ever
used this functionality. If the opposite turns out to be true such support will
be added to libbytesize and no change will be needed in Blivet.
2) humanReadable() now ignores the 'skip' and 'min_value' attributes. The former
one is always replaced by 'True' (i.e. trailing zeroes are always stripped), the
latter one is ignored because it made things really cryptic and weird.
* see the commit, mainly the part modifying/removing the tests for more details
Note: tests are expected to be failing at this phase -- libbytesize is not available as a package yet. I am of course not going to merge this before that changes.
--
To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/251