anaconda-patches December 2015

anaconda-patches@lists.fedorahosted.org

9 participants
498 discussions

Re: [rhinstaller/lorax/pulls/77 master] Write a list of debuginfo packages to /root/debug-pkgs.log (#1068675)
by dashea 22 Dec '15

22 Dec '15

Closed. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/77

1 0

Re: [rhinstaller/lorax/pulls/77 master] Write a list of debuginfo packages to /root/debug-pkgs.log (#1068675)
by dashea 22 Dec '15

22 Dec '15

> Having the full rpmdb would have helped me in the past for other things as well, mostly knowing the version of python-kickstart etc. So it's not "no useful reason". There's actually already a list of the installed packages in /root/lorax-packages.log -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/77

1 0

[PATCH rhel6-branch] network: add support for vlan over bond boot option (#1011595)
by Radek Vykydal 21 Dec '15

21 Dec '15

Resolves: rhbz#1011595 Essential part of the patchset to have early integration testing with NetworkManager, ie we are generating correct ifcfgs and NM handles them as expected. Next item: genrating correct command in anaconda-ks.cfg --- loader/net.c | 62 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- loader/net.h | 1 + 2 files changed, 62 insertions(+), 1 deletion(-) diff --git a/loader/net.c b/loader/net.c index b678a80..43c107c 100644 --- a/loader/net.c +++ b/loader/net.c @@ -1573,6 +1573,9 @@ int writeEnabledNetInfo(iface_t *iface) { } g_strfreev(slaves); } + if (iface->vlanid) { + writeBondVlanParentIfcfgFile(iface); + } } if (rename(ofile, nfile) == -1) { @@ -1656,6 +1659,64 @@ int enable_NM_BOND_VLAN() { } +int writeBondVlanParentIfcfgFile(iface_t *iface) { + char *ofile = NULL; + char *nfile = NULL; + FILE *fp = NULL; + char *uuid = NULL; + + checked_asprintf(&ofile, "%s/.ifcfg-%s", + NETWORK_SCRIPTS_PATH, + iface->device); + checked_asprintf(&nfile, "%s/ifcfg-%s", + NETWORK_SCRIPTS_PATH, + iface->device); + + if ((fp = fopen(ofile, "w")) == NULL) { + free(ofile); + free(nfile); + return 2; + } + + fprintf(fp, "DEVICE=%s\n", iface->device); + uuid = nm_utils_uuid_generate(); + fprintf(fp, "UUID=%s\n", uuid); + fprintf(fp, "TYPE=Bond\n"); + if (iface->bonding_opts) { + if (strchr(iface->bonding_opts, ';')) { + replaceChars(iface->bonding_opts, ';', ' '); + } else { + replaceChars(iface->bonding_opts, ',', ' '); + } + fprintf(fp, "BONDING_OPTS=\"%s\"\n", iface->bonding_opts); + } + fprintf(fp, "ONBOOT=yes\n"); + fprintf(fp, "NM_CONTROLLED=yes\n"); + g_free(uuid); + + if (fclose(fp) == EOF) { + return 3; + } + + if (rename(ofile, nfile) == -1) { + free(ofile); + free(nfile); + return 4; + } + + if (ofile) { + free(ofile); + ofile = NULL; + } + + if (nfile) { + free(nfile); + nfile = NULL; + } + + return 0; +} + int writeBondSlaveIfcfgFile(char *slave, char *master) { char *ofile = NULL; char *nfile = NULL; @@ -2391,7 +2452,6 @@ int activateDevice(struct loaderData_s * loaderData, iface_t * iface) { logMessage(ERROR, "writeDisabledIfcfgFile failure (%s): %d", __func__, rc); } - loaderData->netDev_set = 0; loaderData->ipinfo_set = 0; free(loaderData->ipv4); diff --git a/loader/net.h b/loader/net.h index 7f9e57c..abf9238 100644 --- a/loader/net.h +++ b/loader/net.h @@ -91,4 +91,5 @@ int split_bond_option(char *str, char **bondname, char **bondslaves, char **opti int networkDeviceExists(char *name); int writeBondSlaveIfcfgFile(char *slave, char *master); void parseDnsServers(const char *dnss, iface_t *iface); +int writeBondVlanParentIfcfgFile(iface_t *iface); #endif -- 2.4.3

2 1

Re: [rhinstaller/blivet/pulls/293 master] Let Device know about its children
by dashea 21 Dec '15

21 Dec '15

Looks good to me too. I again expected this would be worse. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/293

1 0

Re: [rhinstaller/blivet/pulls/293 master] Let Device know about its children
by dashea 21 Dec '15

21 Dec '15

Added label: ACK. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/293

1 0

Re: [rhinstaller/blivet/pulls/294 master] Make blivet thread-safe
by dashea 21 Dec '15

21 Dec '15

Oh, this is even nicer than I expected it to be. Really great! -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/294

1 0

Re: [rhinstaller/anaconda/pulls/475 rhel6-branch] Fix multipath UI representation (#914637)
by dashea 21 Dec '15

21 Dec '15

Looks good to me otherwise too. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/475

1 0

Re: [rhinstaller/anaconda/pulls/475 rhel6-branch] Fix multipath UI representation (#914637)
by dashea 21 Dec '15

21 Dec '15

> @@ -130,6 +130,24 @@ def __init__(self, xml): > def addToUI(self, tuple): > pass > > + def incrementDeviceCount(self, tuple): > + global totalDevices, totalSize > + global selectedDevices, selectedSize > + global talliedDevices > + > + # Check to be sure this device has not already been counted > + if tuple[0]["name"] in talliedDevices or tuple[0]["DEVNAME"] in talliedDevices: > + return > + > + talliedDevices.append(tuple[0]["name"]) > + > + totalDevices += 1 > + totalSize += tuple[0]["XXX_SIZE"] > + > + if tuple[2]: > + selectedDevices += 1 > + selectedSize += tuple[0]["XXX_SIZE"] I think these methods could be made clearer if the tuples were expanded somewhere. ``tuple[X]`` is really cryptic. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/475#discussion_r48126771

1 0

Re: [rhinstaller/lorax/pulls/78 master] Add --image-type and --qemu-args
by dashea 21 Dec '15

21 Dec '15

Seems good to me too. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/78

1 0

Re: [rhinstaller/anaconda/pulls/475 rhel6-branch] Fix multipath UI representation (#914637)
by dashea 21 Dec '15

21 Dec '15

Seems good to me otherwise. Thank you for adding the comments there. It's much readable right now. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/475

1 0

← Newer
1
2
3
4
5
6
7
8
...
50
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches December 2015