anaconda-patches December 2015

anaconda-patches@lists.fedorahosted.org

9 participants
498 discussions

Re: [master 2/4] livemedia-creator: Use discard during installation
by dashea 01 Dec '15

01 Dec '15

In reply to line 144 of src/sbin/livemedia-creator: `discard=unmap` might not be available in older `virt-install` versions. But it should be there since F22 or even earlier. -- To view this comment on github, visit https://github.com/fabiand/lorax/commit/ea20c5e1947643534927c94f806d9c48a7a…

1 0

[master 4/4] livemedia-creator: Raise an error if url is used without networking
by dashea 01 Dec '15

01 Dec '15

From: Fabian Deutsch <fabiand(a)fedoraproject.org> Because livemedia-creator is using a media based installation by default, no networking is brought up automatically. If then the url installation method is used, it fails with an unclear reason. This patch adds a check to raise a clear error if the url installation method is used insisde the kickstart but no networking is configured. Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- src/sbin/livemedia-creator | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/sbin/livemedia-creator b/src/sbin/livemedia-creator index 74ea16a..50c7ada 100755 --- a/src/sbin/livemedia-creator +++ b/src/sbin/livemedia-creator @@ -1328,6 +1328,10 @@ def main(): errors.append("Only url and nfs install methods are currently supported. Please " "fix your kickstart file." ) + if ks.handler.method.method == "url" and not ks.handler.network.seen: + errors.append("The kickstart must activate networking if " + "the url install method is used.") + if ks.handler.displaymode.displayMode is not None: errors.append("The kickstart must not set a display mode (text, cmdline, " "graphical), this will interfere with livemedia-creator.") -- To view this commit on github, visit https://github.com/rhinstaller/lorax/commit/1e9118afb01d1a1518c4f507b1dbf9c…

1 0

[master 3/4] livemedia-creator: Fix a small typo
by dashea 01 Dec '15

01 Dec '15

From: Fabian Deutsch <fabiand(a)fedoraproject.org> Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- src/sbin/livemedia-creator | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sbin/livemedia-creator b/src/sbin/livemedia-creator index aa8774f..74ea16a 100755 --- a/src/sbin/livemedia-creator +++ b/src/sbin/livemedia-creator @@ -1325,7 +1325,7 @@ def main(): if not opts.disk_image and not opts.fs_image: errors = [] if opts.no_virt and ks.handler.method.method not in ("url", "nfs"): - errors.append("Only url and nfs install methods are currently supported. Please " + errors.append("Only url and nfs install methods are currently supported. Please " "fix your kickstart file." ) if ks.handler.displaymode.displayMode is not None: -- To view this commit on github, visit https://github.com/rhinstaller/lorax/commit/9599a258b659ac946f57a04cf22447c…

1 0

[master 2/4] livemedia-creator: Use discard during installation
by dashea 01 Dec '15

01 Dec '15

From: Fabian Deutsch <fabiand(a)fedoraproject.org> This could help to keep the disk size down during installation, if the FS within the VM is also supporting TRIM. Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- src/sbin/livemedia-creator | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sbin/livemedia-creator b/src/sbin/livemedia-creator index 59add02..aa8774f 100755 --- a/src/sbin/livemedia-creator +++ b/src/sbin/livemedia-creator @@ -141,7 +141,7 @@ class VirtualInstall(object): args.append(ks) disk_opts = "path={0}".format(disk_img) - disk_opts += ",cache=unsafe" + disk_opts += ",cache=unsafe,discard=unmap" if qcow2: disk_opts += ",format=qcow2" else: -- To view this commit on github, visit https://github.com/rhinstaller/lorax/commit/ea20c5e1947643534927c94f806d9c4…

1 0

New: [rhinstaller/lorax/pulls/72 master] livemedia-creator: Some smaller improvements
by dashea 01 Dec '15

01 Dec '15

This branch will add a few improvements to livemdia-creator, nothing ground breaking. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/72

1 0

[master 1/4] livemedia-creator: Use cache=unsafe for the installation disk
by dashea 01 Dec '15

01 Dec '15

From: Fabian Deutsch <fabiand(a)fedoraproject.org> This should improve the installation speed, as no sync is required on the underlying disk. Signed-off-by: Fabian Deutsch <fabiand(a)fedoraproject.org> --- src/sbin/livemedia-creator | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sbin/livemedia-creator b/src/sbin/livemedia-creator index 3c4e107..59add02 100755 --- a/src/sbin/livemedia-creator +++ b/src/sbin/livemedia-creator @@ -141,6 +141,7 @@ class VirtualInstall(object): args.append(ks) disk_opts = "path={0}".format(disk_img) + disk_opts += ",cache=unsafe" if qcow2: disk_opts += ",format=qcow2" else: -- To view this commit on github, visit https://github.com/rhinstaller/lorax/commit/e5cbf53496ae6d44546ff47e2e52419…

1 0

Re: [rhinstaller/anaconda/pulls/462 rhel6-branch] Fix IPoIB interfaces are shown as Ethernet (#1116633)
by dashea 01 Dec '15

01 Dec '15

Added label: ACK. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/462

1 0

Re: [rhinstaller/anaconda/pulls/462 rhel6-branch] Fix IPoIB interfaces are shown as Ethernet (#1116633)
by dashea 01 Dec '15

01 Dec '15

Looks good to me. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/462

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches December 2015