anaconda-patches May 2015

anaconda-patches@lists.fedorahosted.org

14 participants
169 discussions

New: [rhinstaller/anaconda/pulls/17] Backport pyanaconda_tests/keyboard_test.py updates from master
by dashea 03 Jun '15

03 Jun '15

Seems OK (nosetests passes) but there's one thing on master that worries me: commit 45a05d0a16014e9a46a625bc2f418888d3bdeb7d Author: Vratislav Podzimek Date: Thu Jul 17 16:12:14 2014 +0200 Prevent crashes due to accessing X server from multiple threads I don't know how that applies to rhel7-branch. Please comment. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/17

1 9

New: [rhinstaller/anaconda/pulls/19] Backport grub_raid_test.py from master
by dashea 03 Jun '15

03 Jun '15

A few notes here: As is this test fails in grub_mbr_raid1_test(). See the lines: ``` expected_targets = set([(self.sda, self.boot_md), (self.sdb, self.boot_md)]) # expected_targets = set([(self.sda, self.sda2), (self.sdb, self.sdb2)]) ``` If the second one is used instead of the first one then the result is PASS. This is due to different support for GRUB stage2 between master and rhel7-branch. On RHEL7: ``` for stage2dev in self.stage2_device.parents: # if target disk contains any of /boot array's member # partitions, set up stage1 on each member's disk # and stage2 on each member partition stage1dev = stage2dev.disk targets.append((stage1dev, stage2dev)) ``` While on master: ``` for stage2dev in stage2_parents: # if target disk contains any of /boot array's member # partitions, set up stage1 on each member's disk stage1dev = stage2dev.disk targets.append((stage1dev, self.stage2_device)) ``` Notice the self.stage2_device vs. stage2dev. The first one is the md1 partition while the second one is either sda2 or sdb2 - the mdraid member partitions. I don't know which one is the expected behavior for RHEL 7. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/19

1 7

New: [rhinstaller/anaconda/pulls/12] Remove W0123 which is not defined in older pylint and causes traceback
by dashea 03 Jun '15

03 Jun '15

Running the test suite on RHEL7 yields: ``` Traceback (most recent call last): File "/usr/bin/pylint", line 9, in <module> load_entry_point('pylint==1.0.0', 'console_scripts', 'pylint')() File "/usr/lib/python2.7/site-packages/pylint/__init__.py", line 21, in run_pylint Run(sys.argv[1:]) File "/usr/lib/python2.7/site-packages/pylint/lint.py", line 990, in __init__ args = linter.load_command_line_configuration(args) File "/usr/lib/python2.7/site-packages/logilab/common/configuration.py", line 685, in load_command_line_configuration (options, args) = self.cmdline_parser.parse_args(args=args) File "/usr/lib64/python2.7/optparse.py", line 1399, in parse_args stop = self._process_args(largs, rargs, values) File "/usr/lib64/python2.7/optparse.py", line 1439, in _process_args self._process_long_opt(rargs, values) File "/usr/lib64/python2.7/optparse.py", line 1514, in _process_long_opt option.process(opt, value, values, self) File "/usr/lib/python2.7/site-packages/logilab/common/optik_ext.py", line 237, in process self.action, self.dest, opt, value, values, parser) File "/usr/lib64/python2.7/optparse.py", line 808, in take_action self.callback(self, opt, value, parser, *args, **kwargs) File "/usr/lib/python2.7/site-packages/logilab/common/configuration.py", line 540, in cb_set_provider_option self.global_set_option(opt, value) File "/usr/lib/python2.7/site-packages/logilab/common/configuration.py", line 544, in global_set_option self._all_options[opt].set_option(opt, value) File "/usr/lib/python2.7/site-packages/pylint/lint.py", line 383, in set_option meth(_id) File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 251, in disable msg = self.check_message_id(msgid) File "/usr/lib/python2.7/site-packages/pylint/utils.py", line 315, in check_message_id raise UnknownMessage('No such message id %s' % msgid) pylint.utils.UnknownMessage: No such message id W0123 ``` With this small fix it displays correct results from pylint: ``` FAIL: pylint/runpylint ====================== pylint reports the following issues: ************* Module ../pyanaconda/ui/gui/spokes/lib/resize.py E0611: 25,0: : No name 'Gdk' in module 'gi.repository' E0611: 25,0: : No name 'Gtk' in module 'gi.repository' ************* Module ../pyanaconda/anaconda.py F0401:161,8: Anaconda.dumpState: Unable to import 'meh' F0401:162,8: Anaconda.dumpState: Unable to import 'meh.dump' ``` -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/12

1 9

Updated: [rhinstaller/blivet/pulls/125 master] Ignore and clean files generated by Sphinx
by dashea 03 Jun '15

03 Jun '15

Just cleaning up a bit. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/125

1 6

New: [rhinstaller/anaconda/pulls/18] backport iutil_test.py updates from master
by dashea 02 Jun '15

02 Jun '15

Please comment on this PR. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/18

1 6

New: [rhinstaller/anaconda/pulls/22 rhel7-branch] Backport glade tests from master
by dashea 02 Jun '15

02 Jun '15

I've cherry picked these two commits from David and fixed a small conflict while applying the second one. The tests also discover some issues. Will open a bug for them. Please comment on the PR state? Do you want me to squash the two commits together ? -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/22

1 8

New: [rhinstaller/anaconda/pulls/13] Backport pylint updates from master
by dashea 02 Jun '15

02 Jun '15

Notes: - this PR also contains 2206654b6cedd2dc48618435db7a5c55ff294afa which was submitted previously as PR #12. - I've copied the add_metaclass() into pointless-override.py b/c RHEL7 has an older version of six, which doesn't define it Please comment! -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/13

1 7

Updated: [rhinstaller/anaconda/pulls/10] backported gettext updates from master
by dashea 02 Jun '15

02 Jun '15

Hi guys, I'm not sure about removal of this line: potcheckfile = checkfile + ".h" but as far as I can tell it should be the correct thing to do. There are both .glade and .glade.h files and I think the .h files need to go. Everything else appears to be OK. Please comment. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/10

1 7

New: [rhinstaller/anaconda/pulls/16] Move the pykickstart version test into a different subdirectory.
by dashea 02 Jun '15

02 Jun '15

I've just cherry-picked this from master. Doesn't seem to break anything although it doesn't add new value except making rhel7-branch closer to master. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/16

1 6

New: [rhinstaller/anaconda/pulls/121 rhel7-branch] Fix dracut reads ksdevice from missing os enviromnent
by dashea 02 Jun '15

02 Jun '15

Now dracut reads the ksdevice from /proc/cmdline file instead. Related: rhbz#1085310 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/121

1 8

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches May 2015