anaconda-patches June 2015

anaconda-patches@lists.fedorahosted.org

13 participants
265 discussions

Start a nNew thread

Updated: [rhinstaller/blivet/pulls/142 rhel7-branch] 7.2 cherry picks
by dashea 02 Jun '15

02 Jun '15

-- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/142

1 7

New: [rhinstaller/anaconda/pulls/121 rhel7-branch] Fix dracut reads ksdevice from missing os enviromnent
by dashea 02 Jun '15

02 Jun '15

Now dracut reads the ksdevice from /proc/cmdline file instead. Related: rhbz#1085310 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/121

1 8

[PATCH rhel7-branch] f21 rebase fixups in parse-kickstart
by Radek Vykydal 02 Jun '15

02 Jun '15

Inspired by seeing https://github.com/bcl/anaconda/commit/3c9d72e7a992c11eb960aa0d1ddf564bdcff…

2 3

Updated: [rhinstaller/blivet/pulls/141 f22-branch] Allow adding new partitions to disks with active devices
by dashea 02 Jun '15

02 Jun '15

#93 for f22-branch -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/141

1 3

New: [rhinstaller/blivet/pulls/139 rhel6-branch] Master rhel6 branch a
by dashea 02 Jun '15

02 Jun '15

Work for RHEL6 backport. Commit c6e14f9 marks the point where we chose a new version number, and put a build with that version number into dist-git. Only patches after that point can actually be amended. Changes to patches from before that point will have to be done with additional patches. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/139

1 39

New: [rhinstaller/anaconda/pulls/124 rhel7-branch] Bugs from rhel7.1 ported to new rhel7.2 branch
by dashea 01 Jun '15

01 Jun '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/124

1 29

[PATCH] Fix pylint issues on rhel7-branch of blivet.
by Chris Lumens 01 Jun '15

01 Jun '15

--- blivet/formats/__init__.py | 4 +++- scripts/makebumpver | 12 +++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/blivet/formats/__init__.py b/blivet/formats/__init__.py index 9b9a729..55fc626 100644 --- a/blivet/formats/__init__.py +++ b/blivet/formats/__init__.py @@ -179,6 +179,8 @@ class DeviceFormat(ObjectID): it via the 'device' kwarg to the :meth:`create` method. """ ObjectID.__init__(self) + self._device = None + self.device = kwargs.get("device") self.uuid = kwargs.get("uuid") self.exists = kwargs.get("exists") @@ -294,7 +296,7 @@ class DeviceFormat(ObjectID): def _setDevice(self, devspec): if devspec and not devspec.startswith("/"): raise ValueError("device must be a fully qualified path") - self._device = devspec # pylint: disable=attribute-defined-outside-init + self._device = devspec def _getDevice(self): return self._device diff --git a/scripts/makebumpver b/scripts/makebumpver index fa805f7..45e6526 100755 --- a/scripts/makebumpver +++ b/scripts/makebumpver @@ -126,9 +126,9 @@ class MakeBumpVer: ret = proc[0].strip('\n').split('\n') if len(ret) == 1 and ret[0].find('@') != -1: - ret = ret[0].split('@')[0] + ret = [ret[0].split('@')[0]] elif len(ret) == 1: - ret = ret[0] + ret = [ret[0]] else: ret = filter(lambda x: x != '', ret) @@ -243,7 +243,7 @@ class MakeBumpVer: if self.ignore and self.ignore != '': for commit in self.ignore.split(','): - lines = filter(lambda x: not x.startswith(commit), lines) + lines = filter(lambda x, c=commit: not x.startswith(c), lines) rpm_log = [] bad_bump = False @@ -255,11 +255,9 @@ class MakeBumpVer: fields = line.split(' ') commit = fields[0] - summary = self._getCommitDetail(commit, "%s") + summary = self._getCommitDetail(commit, "%s")[0] body = self._getCommitDetail(commit, "%b") - if type(body) is not list: - body = [body] - author = self._getCommitDetail(commit, "%aE") + author = self._getCommitDetail(commit, "%aE")[0] if self.rhel: rhbz = set() -- 2.2.2

2 3

[master][anaconda] Fix a couple pylint errors.
by Samantha N. Bueno 01 Jun '15

01 Jun '15

I always miss something when manually rebasing. And when I think I'm ok, I don't run pylnt, so of course things like this happen. --- pyanaconda/ui/gui/spokes/lib/dasdfmt.py | 2 +- pyanaconda/ui/tui/spokes/storage.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/lib/dasdfmt.py b/pyanaconda/ui/gui/spokes/lib/dasdfmt.py index 4a5c789..27645ee 100644 --- a/pyanaconda/ui/gui/spokes/lib/dasdfmt.py +++ b/pyanaconda/ui/gui/spokes/lib/dasdfmt.py @@ -89,7 +89,7 @@ class DasdFormatDialog(GUIObject): for disk in self.to_format: try: gtk_call_once(self._formatting_label.set_text, _("Formatting /dev/%s. This may take a moment.") % disk.name) - blockdev.s390.format_dasd(disk.name) + blockdev.s390.dasd_format(disk.name) except blockdev.S390Error as err: # Log errors if formatting fails, but don't halt the installer log.error(str(err)) diff --git a/pyanaconda/ui/tui/spokes/storage.py b/pyanaconda/ui/tui/spokes/storage.py index 39ee924..5aae6dd 100644 --- a/pyanaconda/ui/tui/spokes/storage.py +++ b/pyanaconda/ui/tui/spokes/storage.py @@ -333,9 +333,9 @@ class StorageSpoke(NormalTUISpoke): for disk in to_format: try: - print(_("Formatting /dev/%s. This may take a moment.") % disk) - format_dasd(disk) - except DasdFormatError as err: + print(_("Formatting /dev/%s. This may take a moment.") % disk.name) + blockdev.s390.dasd_format(disk.name) + except blockdev.S390Error as err: # Log errors if formatting fails, but don't halt the installer log.error(str(err)) continue -- 2.1.0

2 1

patches to support fancier kstest setups
by Chris Lumens 01 Jun '15

01 Jun '15

The following three patches to anaconda and three patches to lorax allow us to set up tests that have much fancier disk setups. This can be as simple as multiple disks, or as complicated as disks that are preinitialized with some formatting. This requires passing extra arguments to virt-install that LMC shouldn't support. It already has enough arguments. Instead I have broken some code out of LMC into extra pylorax modules and then made an LMC-like program so we still get all the nice timeout and traceback detection. I don't think there's more code that can be shared between LMC and my own program without making it all more complicated than it needs to be. This has the extra added bonus of meaning we can just do "autopart" in our tests unless we want something else. I've gone ahead and made that change. It also requires that you create the disks ahead of time. I've made that change as well, and moved all the common code into its own file so everyone doesn't have to remember it every time. Support for fancy networking is not yet present, but should at least be possible now. I simply don't yet know what will be required or how to do it. - Chris

3 9

New: [rhinstaller/anaconda/pulls/123 master] Prevent issues with encrypted LVs on renamed VGs (#1224045)
by dashea 01 Jun '15

01 Jun '15

If a VG (or a container generally) is renamed, we need to take into account the fact that its child device (can) get renamed too and update our list of already-used names accordingly. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/123

1 1

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches June 2015