anaconda-patches June 2015

anaconda-patches@lists.fedorahosted.org

13 participants
265 discussions

[RHEL 7.2/PATCH] Cancel Container Edit Sensitizes Update (#1168656)
by Robert Marshall 19 Jun '15

19 Jun '15

The "Update Settings" button in the custom partition screen would activate after a user attempted to create a new volume and then pressed the cancel button. This patch removes the double event handler which had the unintended side effect of setting the sensitive property to True no matter what happened in the container editor dialog box. Resolves: rhbz#1168656 --- pyanaconda/ui/gui/spokes/custom.glade | 1 - pyanaconda/ui/gui/spokes/custom.py | 12 +++++++++--- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade index 2cf6e70..8407dda 100644 --- a/pyanaconda/ui/gui/spokes/custom.glade +++ b/pyanaconda/ui/gui/spokes/custom.glade @@ -815,7 +815,6 @@ <property name="can_focus">False</property> <property name="model">containerStore</property> <signal name="changed" handler="on_container_changed" swapped="no"/> - <signal name="changed" handler="on_value_changed" swapped="no"/> <child> <object class="GtkCellRendererText" id="descRenderer"/> <attributes> diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py index 8ee545d..c80e4ab 100644 --- a/pyanaconda/ui/gui/spokes/custom.py +++ b/pyanaconda/ui/gui/spokes/custom.py @@ -2085,13 +2085,15 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker): container_type = get_container_type_name(device_type).lower() new_text = _(NEW_CONTAINER_TEXT) % {"container_type": container_type} create_new_container = container_name == new_text + user_changed_container = True if create_new_container: # run the vg editor dialog with a default name and disk set hostname = self.data.network.hostname name = self._storage_playground.suggestContainerName(hostname=hostname) - new = self.run_container_editor(name=name) + # user_changed_container flips to False if "cancel" picked + user_changed_container = self.run_container_editor(name=name) for idx, data in enumerate(self._containerStore): - if new and data[0] == new_text: + if user_changed_container and data[0] == new_text: c = self._storage_playground.devicetree.getDeviceByName(self._device_container_name) freeSpace = getattr(c, "freeSpace", None) row = self._container_store_row(self._device_container_name, freeSpace) @@ -2099,11 +2101,15 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker): self._containerStore.insert(idx, row) combo.set_active(idx) # triggers a call to this method return - elif not new and data[0] == self._device_container_name: + elif not user_changed_container and data[0] == self._device_container_name: combo.set_active(idx) return + # else clause runs if an already existing container is picked else: self._device_container_name = container_name + + if user_changed_container: + self._applyButton.set_sensitive(True) container = self._storage_playground.devicetree.getDeviceByName(self._device_container_name) container_exists = getattr(container, "exists", False) # might not be in the tree -- 2.4.3

2 1

New: [rhinstaller/anaconda/pulls/150 rhel7-branch] If using pre-existing, no size needs to be specified in ksdata (#1169…
by dashea 19 Jun '15

19 Jun '15

…783) Resolves: rhbz#1169783 Related: rhbz#1196721 Signed-off-by: mulhern <amulhern(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/150

1 1

New: [rhinstaller/lorax/pulls/26 rhel7-branch] Add ntp configuration file to installation
by dashea 19 Jun '15

19 Jun '15

Add package ntp and remove it except ntp.conf file. Related: rhbz#1085013 -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/26

1 10

New: [rhinstaller/blivet/pulls/160 master] Deprecate some little-used device lookup methods
by dashea 19 Jun '15

19 Jun '15

`getDevicesBySerial` has no callers and the other two don't offer any value beyond their list comprehension equivalents `[d for d in dt.devices if isinstance(d, cls)]` (`getDevicesByInstance`) and `[d for d in dt.devices if d.type == devtype]` (`getDevicesByType`). The first patch establishes a basic procedure for deprecating things in blivet. The warnings will only be logged if someone has called `blivet.util.set_up_logging`. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/160

1 12

[PATCH rhel7-branch] Use the RHEL7 versions of certain partitioning commands.
by Chris Lumens 19 Jun '15

19 Jun '15

With the changes to pykickstart for supporting --mkfsoptions, we need to make sure anaconda is using the latest versions of those commands. This does not add support to anaconda for the --mkfsoptions argument, it merely allows tests to continue passing. Related: rhbz#1217110 --- pyanaconda/kickstart.py | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py index d587976..5cccb5e 100644 --- a/pyanaconda/kickstart.py +++ b/pyanaconda/kickstart.py @@ -423,12 +423,12 @@ class Bootloader(commands.bootloader.RHEL7_Bootloader): if self.nombr: flags.nombr = True -class BTRFS(commands.btrfs.F17_BTRFS): +class BTRFS(commands.btrfs.RHEL7_BTRFS): def execute(self, storage, ksdata, instClass): for b in self.btrfsList: b.execute(storage, ksdata, instClass) -class BTRFSData(commands.btrfs.F17_BTRFSData): +class BTRFSData(commands.btrfs.RHEL7_BTRFSData): def execute(self, storage, ksdata, instClass): devicetree = storage.devicetree @@ -1067,7 +1067,7 @@ class DmRaid(commands.dmraid.FC6_DmRaid): def parse(self, args): raise NotImplementedError(_("The %s kickstart command is not currently supported.") % "dmraid") -class Partition(commands.partition.F20_Partition): +class Partition(commands.partition.RHEL7_Partition): def execute(self, storage, ksdata, instClass): for p in self.partitions: p.execute(storage, ksdata, instClass) @@ -1075,7 +1075,7 @@ class Partition(commands.partition.F20_Partition): if self.partitions: doPartitioning(storage) -class PartitionData(commands.partition.F18_PartData): +class PartitionData(commands.partition.RHEL7_PartData): def execute(self, storage, ksdata, instClass): devicetree = storage.devicetree kwargs = {} @@ -1336,12 +1336,12 @@ class PartitionData(commands.partition.F18_PartData): parents=request) storage.createDevice(luksdev) -class Raid(commands.raid.F20_Raid): +class Raid(commands.raid.RHEL7_Raid): def execute(self, storage, ksdata, instClass): for r in self.raidList: r.execute(storage, ksdata, instClass) -class RaidData(commands.raid.F18_RaidData): +class RaidData(commands.raid.RHEL7_RaidData): def execute(self, storage, ksdata, instClass): raidmems = [] devicetree = storage.devicetree -- 2.4.3

2 1

Updated: [rhinstaller/anaconda/pulls/146 rhel7-branch] Fix set size to partition in custom spoke
by dashea 19 Jun '15

19 Jun '15

Setting size for custom partition was broken. Blivet now needs normal string instead of unicode. @dwlehman from what I found this change is need at top of your [commit](https://github.com/rhinstaller/blivet/commit/ee1802babf7ae0ec3abfee…. Could you please look on it. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/146

1 8

New: [rhinstaller/anaconda/pulls/142 master] Don't run input checks on every keystroke
by dashea 19 Jun '15

19 Jun '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/142

1 12

New: [rhinstaller/anaconda/pulls/148 master] Do something about the new flood of pylint errors I caused
by dashea 19 Jun '15

19 Jun '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/148

2 15

New: [rhinstaller/anaconda/pulls/143 master] Use comps.environments instead of comps.environments_iter (#1221736)
by dashea 19 Jun '15

19 Jun '15

environments_iter is not ordered, environments is. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/143

1 4

[rhel6-branch] Include drbg module in the initrd. (#1233088)
by Samantha N. Bueno 19 Jun '15

19 Jun '15

Apparently it is suddenly necessary that this module is present in order for cryptsetup to work. Resolves: rhbz#1233088 --- scripts/mk-images | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mk-images b/scripts/mk-images index f7b2c29..b565c65 100755 --- a/scripts/mk-images +++ b/scripts/mk-images @@ -109,7 +109,7 @@ SCSIMODS="sr_mod sg st sd_mod scsi_mod iscsi_tcp iscsi_ibft scsi_wait_scan cxgb3 FSMODS="fat msdos vfat ext2 ext3 ext4 reiserfs jfs xfs gfs2 cifs fuse btrfs hfsplus xenfs" LVMMODS="dm-mod dm-zero dm-snapshot dm-mirror dm-multipath dm-round-robin dm-crypt dm-raid dm-raid45 dm-memcache dm-thin-pool" RAIDMODS="raid0 raid1 raid5 raid6 raid456 raid10 linear" -CRYPTOMODS="sha256_generic cbc xts lrw aes_generic crypto_blkcipher crc32c ecb arc4" +CRYPTOMODS="sha256_generic cbc xts lrw aes_generic crypto_blkcipher crc32c ecb arc4 drbg" PCMCIASOCKMODS="yenta_socket i82365 tcic pcmcia" INFINIBANDMODS="ib_qib mlx4_ib" VMPVMODS="vmxnet3 vmware_balloon vmw_pvsci" -- 1.9.3

2 1

← Newer
1
...
8
9
10
11
12
13
14
...
27
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches June 2015