anaconda-patches July 2015

anaconda-patches@lists.fedorahosted.org

14 participants
266 discussions

Start a nNew thread

New: [rhinstaller/anaconda/pulls/178 rhel7-branch] fix issues with info bar visibility
by dashea 10 Jul '15

10 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/178

1 7

[PATCH] Fix a couple other pylint problems in the driver disk tests.
by Chris Lumens 10 Jul '15

10 Jul '15

Most of this is just pylint not being able to import from the dracut/ directory without being told how. Most of the rest is ignoring the interruptible system call stuff in contexts where it doesn't matter. --- dracut/driver_updates.py | 3 +++ tests/dracut_tests/test_driver_updates.py | 6 ++++-- tests/lib/mkdud.py | 6 +++++- tests/testenv.sh | 4 ++-- 4 files changed, 14 insertions(+), 5 deletions(-) diff --git a/dracut/driver_updates.py b/dracut/driver_updates.py index 0bf9648..e50eae9 100755 --- a/dracut/driver_updates.py +++ b/dracut/driver_updates.py @@ -63,6 +63,9 @@ During system installation, anaconda will install the packages listed in /run/install/dd_packages to the target system. """ +# Ignore any interruptible calls +# pylint: disable=interruptible-system-call + import logging import sys import os diff --git a/tests/dracut_tests/test_driver_updates.py b/tests/dracut_tests/test_driver_updates.py index 9b87c73..d4387f3 100644 --- a/tests/dracut_tests/test_driver_updates.py +++ b/tests/dracut_tests/test_driver_updates.py @@ -1,5 +1,8 @@ # test_driver_updates.py - unittests for driver_updates.py +# Ignore any interruptible calls +# pylint: disable=interruptible-system-call + import unittest try: import unittest.mock as mock @@ -231,7 +234,7 @@ class TestSaveRepo(FileTestCaseBase): def test_basic(self): """save_repo: copies a directory to /run/install/DD-X""" makerepo(self.srcdir) - [repo] = find_repos(self.srcdir) + repo = find_repos(self.srcdir)[0] makefile(repo+'/fake-something.rpm') saved = save_repo(repo, target=self.destdir) self.assertEqual(set(os.listdir(saved)), set(["fake-something.rpm"])) @@ -584,7 +587,6 @@ class DeviceInfoTestCase(unittest.TestCase): # TODO: test TextMenu itself # py2/3 compat -import sys if sys.version_info.major == 3: from io import StringIO else: diff --git a/tests/lib/mkdud.py b/tests/lib/mkdud.py index 1fb2b3c..3959ded 100755 --- a/tests/lib/mkdud.py +++ b/tests/lib/mkdud.py @@ -18,8 +18,12 @@ # # Author: Will Woods <wwoods(a)redhat.com> +# Ignore any interruptible calls +# pylint: disable=interruptible-system-call + import os -import rpmfluff +# TODO: this pragma is temporary until there's a python3-rpmfluff +import rpmfluff # pylint: disable=import-error import subprocess import argparse import tempfile diff --git a/tests/testenv.sh b/tests/testenv.sh index cdc7c41..4b7b236 100644 --- a/tests/testenv.sh +++ b/tests/testenv.sh @@ -9,9 +9,9 @@ fi : "${top_builddir:=$top_srcdir}" if [ -z "$PYTHONPATH" ]; then - PYTHONPATH="${top_builddir}/pyanaconda/isys/.libs:${top_srcdir}/pyanaconda:${top_srcdir}:${top_srcdir}/tests/lib" + PYTHONPATH="${top_builddir}/pyanaconda/isys/.libs:${top_srcdir}/pyanaconda:${top_srcdir}:${top_srcdir}/tests/lib:${top_srcdir}/dracut" else - PYTHONPATH="${PYTHONPATH}:${top_builddir}/pyanaconda/isys/.libs:${top_srcdir}/pyanaconda:${top_srcdir}:${top_srcdir}/tests/lib" + PYTHONPATH="${PYTHONPATH}:${top_builddir}/pyanaconda/isys/.libs:${top_srcdir}/pyanaconda:${top_srcdir}:${top_srcdir}/tests/lib:${top_srcdir}/dracut" fi if [ -z "$LD_LIBRARY_PATH" ]; then -- 2.4.3

2 1

[rhel7-branch] Bump pykickstart version required. (#1241413)
by Samantha N. Bueno 09 Jul '15

09 Jul '15

Kickstart clearpart --cdl option for formatting DASDs requires a newer pykickstart. Forgot to bump the version required in the spec file. Resolves: rhbz#1241413 --- anaconda.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/anaconda.spec.in b/anaconda.spec.in index e921db3..e28bf8a 100644 --- a/anaconda.spec.in +++ b/anaconda.spec.in @@ -19,7 +19,7 @@ Source0: %{name}-%{version}.tar.bz2 # match the requires versions of things). %define gettextver 0.18.1 %define intltoolver 0.31.2-3 -%define pykickstartver 1.99.66.4 +%define pykickstartver 1.99.66.5 %define yumver 3.4.3-91 %define partedver 1.8.1 %define pypartedver 2.5-2 -- 2.1.0

2 1

New: [rhinstaller/anaconda/pulls/194 master] dracut: fix boot failure waiting for finished/dd.sh
by dashea 09 Jul '15

09 Jul '15

parse-anaconda-dd.sh was creating an (empty) /tmp/dd_todo if there was nothing to do, but that tricked driver-updates-genrules.sh into thinking there *was* something to do, so we time out waiting for the dd stuff to finish. This patch fixes that by ensuring the file is only created if there is actually one or more tasks to complete. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/194

1 5

Updated: [rhinstaller/anaconda/pulls/190 rhel7-branch] rhel7 backports
by dashea 09 Jul '15

09 Jul '15

This is the commits from #181 and #182, backported for rhel7. The differences are minor but _just barely_ enough to make me want another quick review. The differences from the above commits are: - 231ac70: also reverts a66cb15 - 99c97dd: dnfpayload vs. yumpayload; the fix is the same, it's just in a different file. - d844db8: resolve some parse-kickstart conflicts - `commands.network.RHEL7_Network` vs. `commands.network.F22_Network`, etc. - faf2432: resolve conflict in dracut/module-setup.sh: RHEL7 doesn't have `PYTHONHASHSEED=42` - 679448a: RHEL7 handles chronyd and ntpd; rather than checking to see if the files exist, just try to modify them - the worst that can happen (AFAICT) is a warning in the log. NBD. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/190

1 11

Updated: [rhinstaller/anaconda/pulls/190 rhel7-branch] rhel7 backports
by dashea 09 Jul '15

09 Jul '15

1 9

New: [rhinstaller/blivet/pulls/172 master] Add a bunch more gi.require_version calls
by dashea 09 Jul '15

09 Jul '15

Choo choo here comes the crud train -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/172

1 5

Updated: [rhinstaller/anaconda/pulls/188 master] Fix the dd_test for python3.
by dashea 09 Jul '15

09 Jul '15

The return of check_output is bytes now. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/188

1 5

New: [rhinstaller/anaconda/pulls/189 master] Fix %files to deal with compiled python3 modules
by dashea 09 Jul '15

09 Jul '15

.py and .pyc files were ending up in different subpackages because all the .pyc files moved. Also switch to the %{python3_sitearch} macro to save a few characters. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/189

1 5

New: [rhinstaller/anaconda/pulls/190 rhel7-branch] rhel7 backports
by dashea 08 Jul '15

08 Jul '15

1 9

← Newer
1
...
18
19
20
21
22
23
24
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches July 2015