anaconda-patches July 2015

anaconda-patches@lists.fedorahosted.org

14 participants
266 discussions

[RHEL 7.2 - PATCH] Fix GRUB2 Password Update Scope (#985962)
by Robert Marshall 07 Jul '15

07 Jul '15

Change scoping of variable to resolve issue in unit test. Resolves: rhbz#985962 --- pyanaconda/bootloader.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py index bdebb2e..510ab07 100644 --- a/pyanaconda/bootloader.py +++ b/pyanaconda/bootloader.py @@ -1528,7 +1528,7 @@ class GRUB2(GRUB): if not self.password and not self.encrypted_password: return - users_file = "%s%s/%s" % (iutil.getSysroot(), self.config_dir, _passwd_file) + users_file = "%s%s/%s" % (iutil.getSysroot(), self.config_dir, self._passwd_file) header = open(users_file, "w") # XXX FIXME: document somewhere that the username is "root" self._encrypt_password() -- 1.8.3.1

3 2

New: [rhinstaller/anaconda/pulls/176 rhel7-branch] Refresh advanced disks after disk summary dialog (#1226354)
by dashea 07 Jul '15

07 Jul '15

The advanced list of disks wasn't being refreshed after exiting the disk summary dialog. The storage spoke was not updated when removing a disk with the dialog. Resolves: rhbz#1226354 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/176

1 7

[RHEL 7.2 - PATCH 1/5] Wrap device labels earlier (#1212615)
by Robert Marshall 07 Jul '15

07 Jul '15

From: David Shea <dshea(a)redhat.com> Cherry pick from David Shea's work on master for bz#1212586 in commit fc8c9a7676d1c3ffff9c70501b8cbc7713e31396. A minimum width of 35 in the device label causes problems with smaller resolutions (800x600). Remove width_chars so that the label wraps earlier than the max width if it needs to, and change the wrap mode from word to word-char to ensure that device names with extra long words get wrapped ugly instead of causing layout issues. Resolves: rhbz#1212615 --- pyanaconda/ui/gui/spokes/custom.glade | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyanaconda/ui/gui/spokes/custom.glade b/pyanaconda/ui/gui/spokes/custom.glade index 8407dda..14371f3 100644 --- a/pyanaconda/ui/gui/spokes/custom.glade +++ b/pyanaconda/ui/gui/spokes/custom.glade @@ -524,8 +524,8 @@ <property name="valign">start</property> <property name="xalign">0</property> <property name="wrap">True</property> - <property name="width_chars">35</property> <property name="angle">0.01</property> + <property name="wrap_mode">word-char</property> <property name="max_width_chars">35</property> </object> <packing> -- 2.4.3

3 8

New: [rhinstaller/anaconda/pulls/182 master] Driverdisk refactor
by dashea 07 Jul '15

07 Jul '15

Okay, here it is - the big refactor of driver-updates. `README.dd` still needs to be updated, but the code is all here. It also adds a suite of unit tests for `driver-updates` and a kickstart test for the `driverdisk` command. Other than some minor text changes the overall behavior should be the same, except for one thing: we no longer attempt to unload running modules. (This is, I think, outside the scope of what problems the driver-updates stuff is designed to solve. `modprobe.blacklist` can handle the rare cases where a driver-updates disk needs to replace an existing module.) Resolves: RHBZ#1084197 Resolves: RHBZ#1164131 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/182

1 8

New: [rhinstaller/anaconda/pulls/181 master] dracut: fix boot with inst.ks and no inst.{repo,stage2} (#1238987)
by dashea 07 Jul '15

07 Jul '15

Okay so: commit 4883b96 moved fetch-kickstart-net.sh from the online hook into initqueue (or initqueue/settled) to fix inst.ks.sendmac. So when you boot with inst.ks=[URL], the order goes: 1. Network comes up 2. Run `online` hook * Schedule kickstart fetch in initqueue * Other online tasks from boot args (e.g. updates) 3. Run `initqueue` * fetch + run kickstart * add `anaconda-netroot.sh` (etc.) to `online` hook * `udevadm trigger` disk devices * `udevadm trigger` net devices The problem is, triggering network devices is *not* sufficient to re-run the `online` hook - this only happens when the NIC actually gets _configured_, not when the device is triggered. The fix is pretty straightforward: re-run the `online` hook for active NICs after we run the kickstart, in order to pick up any new tasks that the kickstart might have scheduled. Resolves: RHBZ#1238987 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/181

1 3

Updated: [rhinstaller/anaconda/pulls/169 rhel7-branch] Allowed /boot partition on iscsi with ibft (#1164195)
by dashea 07 Jul '15

07 Jul '15

Fix testing of ibft attribute on device. Fix for the [bug 1164195](https://bugzilla.redhat.com/show_bug.cgi?id=1164195) was pushed already but with an issue. When I used iscsi with ibft I have found that I can't add `/boot` on iscsi drive with `ip=ibft` set. *Related: rhbz#1164195* -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/169

1 7

[anaconda][rhel7-branch][PATCH 0/2] Fix environment handling
by Martin Kolman 07 Jul '15

07 Jul '15

So it turns out that there are multiple issues with how we handle environment specifications from kickstart: 1) an invalid (not known by the payload) environment specified in kickstart causes a crash 2) valid human readable environment specifications, such as: "Infrastructure Server", which is the human readable form of "infrastructure-server-environment", are not considered valid, the same thing happens for translated human readable environment names 3) environments that have been manually selected in the UI are not written to the output kickstart The first patch should fix issues 1) + 3) and the second patch should fix issue 2). Martin Kolman (2): Don't crash if incorrect environment is set in kickstart (#1234890) Handle human readable environment names from kickstart (#1234890) pyanaconda/packaging/yumpayload.py | 14 +++++ pyanaconda/ui/gui/spokes/software.py | 117 ++++++++++++++++++++++++++--------- 2 files changed, 101 insertions(+), 30 deletions(-) -- 2.4.3

2 10

Updated: [rhinstaller/anaconda/pulls/118 master] Add kickstart tests to test btrfs installation
by dashea 07 Jul '15

07 Jul '15

First test: simple installation Second test: installation over multiple devices with RAID Signed-off-by: Vojtech Trefny <vtrefny(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/118

1 5

[PATCH] Use the most recent versions of the btrfs, logvol, part, and raid commands.
by Chris Lumens 07 Jul '15

07 Jul '15

--- pyanaconda/kickstart.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py index 802fdc6..0c85e5b 100644 --- a/pyanaconda/kickstart.py +++ b/pyanaconda/kickstart.py @@ -431,12 +431,12 @@ class Bootloader(commands.bootloader.F21_Bootloader): if self.nombr: flags.nombr = True -class BTRFS(commands.btrfs.F17_BTRFS): +class BTRFS(commands.btrfs.F23_BTRFS): def execute(self, storage, ksdata, instClass): for b in self.btrfsList: b.execute(storage, ksdata, instClass) -class BTRFSData(commands.btrfs.F17_BTRFSData): +class BTRFSData(commands.btrfs.F23_BTRFSData): def execute(self, storage, ksdata, instClass): devicetree = storage.devicetree @@ -804,7 +804,7 @@ class Lang(commands.lang.F19_Lang): # no overrides needed here Eula = commands.eula.F20_Eula -class LogVol(commands.logvol.F21_LogVol): +class LogVol(commands.logvol.F23_LogVol): def execute(self, storage, ksdata, instClass): for l in self.lvList: l.execute(storage, ksdata, instClass) @@ -812,7 +812,7 @@ class LogVol(commands.logvol.F21_LogVol): if self.lvList: growLVM(storage) -class LogVolData(commands.logvol.F21_LogVolData): +class LogVolData(commands.logvol.F23_LogVolData): def execute(self, storage, ksdata, instClass): devicetree = storage.devicetree @@ -1100,7 +1100,7 @@ class DmRaid(commands.dmraid.FC6_DmRaid): def parse(self, args): raise NotImplementedError(_("The %s kickstart command is not currently supported.") % "dmraid") -class Partition(commands.partition.F20_Partition): +class Partition(commands.partition.F23_Partition): def execute(self, storage, ksdata, instClass): for p in self.partitions: p.execute(storage, ksdata, instClass) @@ -1108,7 +1108,7 @@ class Partition(commands.partition.F20_Partition): if self.partitions: doPartitioning(storage) -class PartitionData(commands.partition.F18_PartData): +class PartitionData(commands.partition.F23_PartData): def execute(self, storage, ksdata, instClass): devicetree = storage.devicetree kwargs = {} @@ -1396,12 +1396,12 @@ class PartitionData(commands.partition.F18_PartData): if add_fstab_swap: storage.addFstabSwap(add_fstab_swap) -class Raid(commands.raid.F20_Raid): +class Raid(commands.raid.F23_Raid): def execute(self, storage, ksdata, instClass): for r in self.raidList: r.execute(storage, ksdata, instClass) -class RaidData(commands.raid.F18_RaidData): +class RaidData(commands.raid.F23_RaidData): def execute(self, storage, ksdata, instClass): raidmems = [] devicetree = storage.devicetree -- 2.4.3

2 1

New: [rhinstaller/anaconda/pulls/177 rhel7-branch] Fix broken test by infiniband patch (#1177032)
by dashea 07 Jul '15

07 Jul '15

In the [first patch](https://github.com/rhinstaller/anaconda/pull/173) I changed a method which broke network_test in pyanaconda_tests. *Related: rhbz#1177032* -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/177

1 7

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches July 2015