anaconda-patches July 2015

anaconda-patches@lists.fedorahosted.org

14 participants
266 discussions

New: [rhinstaller/anaconda/pulls/251 master] Disable GRUB os_prober on POWER (#1193281)
by dashea 30 Jul '15

30 Jul '15

The GRUB2 os_prober utility searches for other Linux installations and the output to the grub config file is parsed incorrectly by petitboot. This disables the os_prober script on the following POWER based machine/platform combinations. CHRP/pSeries CHRP IBM/pSeries pSeries/pSeries Maple/pSeries, Cell/pSeries Momentum/pSeries PowerNV/pSeries Resolves: rhbz#1193281 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/251

1 5

New: [rhinstaller/anaconda/pulls/253 master] Cancel Container Edit Sensitizes Update (#1168656)
by dashea 30 Jul '15

30 Jul '15

Settings" button in the custom partition screen would activate after a user attempted to create a new volume and then pressed the cancel button. This patch removes the double event handler which had the unintended side effect of setting the sensitive property to True no matter what happened in the container editor dialog box. Resolves: rhbz#1168656 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/253

1 8

New: [rhinstaller/anaconda/pulls/254 master] Equalize capacity & mount point entries (#1212615)
by dashea 30 Jul '15

30 Jul '15

Shorten the mount point entry box to match the width of the capacity entry box. Resolves: rhbz#1212615 Conflicts: pyanaconda/ui/gui/spokes/custom.glade -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/254

1 5

[master/rhel7-branch] Fix error with OEMDRV ks auto-load check. (#1057271)
by Samantha N. Bueno 30 Jul '15

30 Jul '15

getarg returns an empty string if there is no argument to fetch; this causes a problem since I originally checked the value against "none". Oops. Related: rhbz#1057271 --- dracut/kickstart-genrules.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dracut/kickstart-genrules.sh b/dracut/kickstart-genrules.sh index b5823f9..3dd7f89 100755 --- a/dracut/kickstart-genrules.sh +++ b/dracut/kickstart-genrules.sh @@ -25,7 +25,7 @@ case "${kickstart%%:*}" in warn "inst.ks: can't get kickstart - biospart (bd:) isn't supported yet" ;; "") - if [ -z "$kickstart" -a $(getarg ks= inst.ks=) != "none" ]; then + if [ -z "$kickstart" -a -z $(getarg ks= inst.ks=) ]; then when_diskdev_appears $(disk_to_dev_path LABEL=OEMDRV) \ fetch-kickstart-disk \$env{DEVNAME} "/ks.cfg" fi -- 1.9.3

2 2

Updated: [rhinstaller/blivet/pulls/183 master] Various small test changes
by dashea 29 Jul '15

29 Jul '15

Improvement of loop device cleanup and disabling of image-backed tests are so we can start running the test suite in jenkins again, @clumens. The device factory tests fail without the changes from #182. They increase coverage of devicefactory.py from 19% to 74% (IIRC). -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/183

1 6

Updated: [rhinstaller/blivet/pulls/182 master] device factory bug fixes
by dashea 29 Jul '15

29 Jul '15

These were turned up in the course of writing unit tests for `DeviceFactory` (PR forthcoming). -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/182

1 7

New: [rhinstaller/blivet/pulls/184 master] Misc 20150728
by dashea 29 Jul '15

29 Jul '15

These are just some random things I had laying around. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/184

1 6

New: [rhinstaller/anaconda/pulls/252 master] Equalize capacity & mount point entries (#1212615)
by dashea 29 Jul '15

29 Jul '15

1 4

New: [rhinstaller/blivet/pulls/186 master] Put MDRaidArrayDevice.devices back, but mark it as deprecated.
by dashea 29 Jul '15

29 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/186

1 2

[initial-setup][master/f23-branch][PATCH] Switch Initial Setup to Python 3 (#1244558)
by Martin Kolman 29 Jul '15

29 Jul '15

Make Initial Setup use Python 3 by changing the startup script, dependencies and by changing a single piece of Python 3 incompatible code. Also remove usage of the python-di module - it has not yet been ported to Python 3 and is not really needed. It has been apparently added for use by tests, but there are no tests. It can of course be added back once it is ported to Python 3 and once there are some tests that use it. Signed-off-by: Martin Kolman <mkolman(a)redhat.com> --- Makefile | 6 +----- initial-setup | 2 +- initial-setup.spec | 18 ++++++++---------- initial_setup/gui/gui.py | 3 --- initial_setup/gui/hubs/initial_setup_hub.py | 2 +- initial_setup/tui/tui.py | 3 --- 6 files changed, 11 insertions(+), 23 deletions(-) diff --git a/Makefile b/Makefile index 347f7ea..7b23727 100644 --- a/Makefile +++ b/Makefile @@ -25,10 +25,6 @@ TAG=r$(VERSION)-$(RELEASE) PREFIX=/usr -PYTHON2=python2 -PYTHON3=python3 -PYTHON=$(PYTHON2) - ZANATA_PULL_ARGS = --transdir po/ ZANATA_PUSH_ARGS = --srcdir po/ --push-type source --force @@ -37,7 +33,7 @@ default: all all: po-files install: - $(PYTHON) setup.py install --root=$(DESTDIR) + $(python3) setup.py install --root=$(DESTDIR) $(MAKE) -C po install clean: diff --git a/initial-setup b/initial-setup index 462a515..34b1feb 100755 --- a/initial-setup +++ b/initial-setup @@ -1,7 +1,7 @@ #!/bin/sh echo "Running initial_setup" | logger -if python -m initial_setup; then +if python3 -m initial_setup; then echo "initial_setup finished successfully, disabling" | logger /bin/systemctl disable initial-setup-graphical.service initial-setup-text.service &>/dev/null else diff --git a/initial-setup.spec b/initial-setup.spec index 6a6f6f8..1c8b553 100644 --- a/initial-setup.spec +++ b/initial-setup.spec @@ -18,23 +18,21 @@ Source0: %{name}-%{version}.tar.gz License: GPLv2+ Group: System Environment/Base BuildRequires: gettext -BuildRequires: python2-devel -BuildRequires: python-setuptools -BuildRequires: python-nose +BuildRequires: python3-devel +BuildRequires: python3-setuptools +BuildRequires: python3-nose BuildRequires: systemd-units BuildRequires: gtk3-devel BuildRequires: glade-devel BuildRequires: anaconda >= %{anacondaver} -BuildRequires: python-di BuildRequires: intltool -Requires: python +Requires: python3 Requires: anaconda-tui >= %{anacondaver} Requires(post): systemd Requires(preun): systemd Requires(postun): systemd -Requires: libreport-python -Requires: python-di +Requires: libreport-python3 Requires: util-linux Conflicts: firstboot < 19.2 @@ -102,8 +100,8 @@ fi %files -f %{name}.lang %doc COPYING README.rst -%{python_sitelib}/initial_setup* -%exclude %{python_sitelib}/initial_setup/gui +%{python3_sitelib}/initial_setup* +%exclude %{python3_sitelib}/initial_setup/gui %{_bindir}/initial-setup %{_bindir}/firstboot-windowmanager %{_unitdir}/initial-setup-text.service @@ -114,7 +112,7 @@ fi %endif %files gui -%{python_sitelib}/initial_setup/gui/* +%{python3_sitelib}/initial_setup/gui/* %{_unitdir}/initial-setup-graphical.service %changelog diff --git a/initial_setup/gui/gui.py b/initial_setup/gui/gui.py index e824e1f..64b114c 100644 --- a/initial_setup/gui/gui.py +++ b/initial_setup/gui/gui.py @@ -4,7 +4,6 @@ from .hubs import InitialSetupMainHub import os from gi.repository import Gdk import gettext -from di import inject, usesclassinject # localization _ = lambda x: gettext.ldgettext("initial-setup", x) @@ -14,7 +13,6 @@ class InitialSetupQuitDialog(QuitDialog): MESSAGE = N_("Are you sure you want to quit the configuration process?\n" "You might end up with unusable system if you do.") -@inject(Gdk, product_title = product_title, is_final = is_final) class InitialSetupGraphicalUserInterface(GraphicalUserInterface): """This is the main Gtk based firstboot interface. It inherits from anaconda to make the look & feel as similar as possible. @@ -22,7 +20,6 @@ class InitialSetupGraphicalUserInterface(GraphicalUserInterface): screenshots_directory = "/tmp/initial-setup-screenshots" - @usesclassinject def __init__(self, storage, payload, instclass): GraphicalUserInterface.__init__(self, storage, payload, instclass, product_title, is_final, diff --git a/initial_setup/gui/hubs/initial_setup_hub.py b/initial_setup/gui/hubs/initial_setup_hub.py index 0fb6cb4..602aab1 100644 --- a/initial_setup/gui/hubs/initial_setup_hub.py +++ b/initial_setup/gui/hubs/initial_setup_hub.py @@ -25,6 +25,6 @@ class InitialSetupMainHub(Hub): Hub._createBox(self) # override spokes' distribution strings set by the pyanaconda module - for spoke in self._spokes.itervalues(): + for spoke in self._spokes.values(): spoke.window.set_property("distribution", product.product_title().upper()) diff --git a/initial_setup/tui/tui.py b/initial_setup/tui/tui.py index 07b29a8..259ab13 100644 --- a/initial_setup/tui/tui.py +++ b/initial_setup/tui/tui.py @@ -3,7 +3,6 @@ from initial_setup.product import product_title, is_final from .hubs import InitialSetupMainHub import os import gettext -from di import inject, usesclassinject # localization _ = lambda x: gettext.ldgettext("initial-setup", x) @@ -12,7 +11,6 @@ N_ = lambda x: x QUIT_MESSAGE = N_("Are you sure you want to quit the configuration process?\n" "You might end up with unusable system if you do.") -@inject(product_title = product_title, is_final = is_final) class InitialSetupTextUserInterface(TextUserInterface): """This is the main text based firstboot interface. It inherits from anaconda to make the look & feel as similar as possible. @@ -20,7 +18,6 @@ class InitialSetupTextUserInterface(TextUserInterface): ENVIRONMENT = "firstboot" - @usesclassinject def __init__(self, storage, payload, instclass): TextUserInterface.__init__(self, storage, payload, instclass, product_title, is_final, quitMessage = QUIT_MESSAGE) -- 2.4.3

2 1

← Newer
1
2
3
4
5
6
7
8
...
27
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches July 2015