July 2015 - anaconda-patches - Fedora mailing-lists

New: [rhinstaller/anaconda/pulls/234 master] Fixes for inst.ks=cdrom
by dashea 23 Jul '15

23 Jul '15

While testing the fix from PR #231 (commit bc6378b here) I found some other problems, so here's a new version with some followup fixes. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/234

1 7

[anaconda][rhel7-branch][PATCH] Avoid tofu in TUI
by Martin Kolman 23 Jul '15

23 Jul '15

Make sure that we can actually display the current language in the TUI, so that we don't end with tofu (white rectangles) or mojibake (nonsensical character mix). So languages such as Czech, German, Finish, Greek or Russian will be displayed correctly while for example Japanese will trigger a fallback to English. This patch requires langtable 0.0.31-3, so I'll wait for it hitting the composes before pushing it. Martin Kolman (1): Make sure TUI is readable for non-latin languages (#1182562) anaconda | 13 +++- anaconda.spec.in | 2 +- pyanaconda/anaconda.py | 1 + pyanaconda/localization.py | 142 ++++++++++++++++++++++++++++++++++-- pyanaconda/ui/gui/spokes/welcome.py | 4 +- 5 files changed, 151 insertions(+), 11 deletions(-) -- 2.4.3

3 8

Updated: [rhinstaller/anaconda/pulls/235 rhel7-branch] RHEL7 backport of inst.ks=cdrom fixes
by dashea 22 Jul '15

22 Jul '15

This is basically the same as #234, except it turns out that a couple of the pre-requisite commits either never made it to RHEL7 or got dropped in the rebase. So I've added bd99015 and 8e5b65d, and now CDROM-swapping with `inst.ks=cdrom` should work in RHEL7. Yaaayyyyyyyyy~~~ -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/235

1 5

New: [rhinstaller/anaconda/pulls/235 rhel7-branch] RHEL7 backport of inst.ks=cdrom fixes
by dashea 22 Jul '15

22 Jul '15

This is basically the same as #234, except it turns out that a couple of the pre-requisite commits either never made it to RHEL7 or got dropped in the rebase. So I've added bd99015 and 8e5b65d, and now CDROM-swapping with `inst.ks=cdrom` should work in RHEL7. Yaaayyyyyyyyy~~~ -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/235

1 6

Updated: [rhinstaller/anaconda/pulls/231 master] Wait forever for kickstarts on CDROM (#1168902)
by dashea 22 Jul '15

22 Jul '15

Commit 5d016ef added support for doing cdrom-swapping while doing "inst.ks=cdrom[:...]". But it turns out that if you're slow to swap the discs, we'll hit dracut's retry timeout and it'll drop to the emergency shell. So, in response to User Requests, we now disable the timeout entirely when using "inst.ks=cdrom[:...]"; dracut will wait forever for the kickstart and/or installer media, and if anything goes wrong you're just stuck and you'll need to reset. Resolves: rhbz#1168902 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/231

1 13

[PATCH rhel7-branch] Fix various pylint problems caused by the new rescue mode.
by Chris Lumens 22 Jul '15

22 Jul '15

Related: rhbz#965985 --- pyanaconda/constants_text.py | 1 - pyanaconda/rescue.py | 12 ++++++------ tests/gettext/style_guide.py | 3 ++- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/pyanaconda/constants_text.py b/pyanaconda/constants_text.py index 07882a3..bb0f113 100644 --- a/pyanaconda/constants_text.py +++ b/pyanaconda/constants_text.py @@ -19,7 +19,6 @@ # pylint: disable=wildcard-import from pyanaconda.constants import * -from pyanaconda.i18n import _, N_ # Make the return calls from the UIScreen input() function more clear INPUT_PROCESSED = None diff --git a/pyanaconda/rescue.py b/pyanaconda/rescue.py index d5d596b..e040406 100644 --- a/pyanaconda/rescue.py +++ b/pyanaconda/rescue.py @@ -151,7 +151,7 @@ class RescueMode(NormalTUISpoke): "to find your Linux installation and mount it under " "the directory : %s. You can then make any changes " "required to your system. Choose '1' to proceed with " - "this step.\nYou can choose to mount your file" + "this step.\nYou can choose to mount your file " "systems read-only instead of read-write by choosing " "'2'.\nIf for some reason this process does not work " "choose '3' to skip directly to a shell.\n\n") % (iutil.getSysroot())), ""] @@ -350,10 +350,10 @@ class RescueMountSpoke(NormalTUISpoke): if flags.automatedInstall: log.info("System has been mounted under: %s", iutil.getSysroot()) else: - text = TextWidget(_("Your system has been mounted under %s.\n\nIf " + text = TextWidget(_("Your system has been mounted under %(mountpoint)s.\n\nIf " "you would like to make your system the root " - "environment, run the command:\n\n\tchroot %s\n" - % (iutil.getSysroot(), iutil.getSysroot()))) + "environment, run the command:\n\n\tchroot %(mountpoint)s\n") + % {"mountpoint": iutil.getSysroot()} ) self._window.append(text) rootmounted = True @@ -377,7 +377,7 @@ class RescueMountSpoke(NormalTUISpoke): # set a libpath to use mounted fs libdirs = os.environ.get("LD_LIBRARY_PATH", "").split(":") mounted = map(lambda dir: "/mnt/sysimage%s" % dir, libdirs) - os.environ["LD_LIBRARY_PATH"] = ":".join(libdirs + mounted) + iutil.setenv("LD_LIBRARY_PATH", ":".join(libdirs + mounted)) # do we have bash? try: @@ -387,7 +387,7 @@ class RescueMountSpoke(NormalTUISpoke): pass except (ValueError, LookupError, SyntaxError, NameError): pass - except Exception as e: + except Exception as e: # pylint: disable=broad-except if flags.automatedInstall: msg = _("Run %s to unmount the system when you are finished.\n") % ANACONDA_CLEANUP diff --git a/tests/gettext/style_guide.py b/tests/gettext/style_guide.py index 9f7d273..f486ec2 100755 --- a/tests/gettext/style_guide.py +++ b/tests/gettext/style_guide.py @@ -38,7 +38,8 @@ bad_strings = {'(?i)bootloader': 'boot loader', # write a more specific regex. List occurrences here. # {'filename': {'matched string', occurrences}} expected_badness = {'pyanaconda/bootloader.py': {'mountpoint': 1}, # format string specifier - 'pyanaconda/network.py': {'vlan': 1}} # format string specifier + 'pyanaconda/network.py': {'vlan': 1}, # format string specifier + 'pyanaconda/rescue.py': {'mountpoint': 1}} # format string specifier # Use polib to parse anaconda.pot try: -- 2.4.3

2 2

[PATCH] Add a new makefile target that does everything needed for jenkins.
by Chris Lumens 22 Jul '15

22 Jul '15

We should have as much of the logic of how the CI tests are run in source control as possible, so that's what this target is for. Besides this, jenkins just runs a "git clean" first. --- Makefile.am | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am index b2cef40..8d56898 100644 --- a/Makefile.am +++ b/Makefile.am @@ -46,7 +46,7 @@ ZANATA_PULL_ARGS = --transdir $(srcdir)/po/ ZANATA_PUSH_ARGS = --srcdir $(srcdir)/po/ --push-type source --force RC_RELEASE ?= $(shell date -u +0.1.%Y%m%d%H%M%S) -MOCKCHROOT ?= fedora-rawhide-x86_64 +MOCKCHROOT ?= fedora-rawhide-$(shell uname -m) tag: @git tag -s -a -m "Tag as $(ARCHIVE_TAG)" $(ARCHIVE_TAG) @@ -153,3 +153,11 @@ runglade: GLADE_CATALOG_SEARCH_PATH=$(srcdir)/widgets/glade \ GLADE_MODULE_SEARCH_PATH=$(builddir)/widgets/src/.libs \ glade ${GLADE_FILE} + +ci: rc-release + $(MAKE) -C utils/dd + $(MAKE) TMPDIR=/var/tmp check + @mkdir -p repo + @mv *rpm repo + @createrepo -p repo + @sudo $(MAKE) TMPDIR=/var/tmp TESTS=install/run_install_test.sh TEST_ANACONDA_REPO=file://$(srcdir)/repo/ check -- 2.4.3

2 1

Updated: [rhinstaller/anaconda/pulls/231 master] Wait forever for kickstarts on CDROM (#1168902)
by dashea 22 Jul '15

22 Jul '15

Commit 5d016ef added support for doing cdrom-swapping while doing "inst.ks=cdrom[:...]". But it turns out that if you're slow to swap the discs, we'll hit dracut's retry timeout and it'll drop to the emergency shell. So, in response to User Requests, we now disable the timeout entirely when using "inst.ks=cdrom[:...]"; dracut will wait forever for the kickstart and/or installer media, and if anything goes wrong you're just stuck and you'll need to reset. Resolves: rhbz#1168902 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/231

1 3

New: [rhinstaller/anaconda/pulls/228 master] anaconda.target: Wants systemd-logind.service (#1222413)
by dashea 22 Jul '15

22 Jul '15

This should get back the console on tty2. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/228

1 5

Updated: [rhinstaller/anaconda/pulls/204 master] Source spoke master fix
by dashea 22 Jul '15

22 Jul '15

I want to fix source spoke which was somewhat broken and I found that this change will be somewhat bigger than I expected :). So in short: * Change hashing of repositories to special IDs (they are attached to existing RepoData instances) * Checks can now test even not selected objects * Check repositories URL before leaving spoke * Some minor fixes *This is some kind of RFE so please feel free to tell me if there is better solution* -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/204

1 6

New: [rhinstaller/anaconda/pulls/231 master] Wait forever for kickstarts on CDROM (#1168902)
by dashea 22 Jul '15

22 Jul '15

Commit 5d016ef added support for doing cdrom-swapping while doing "inst.ks=cdrom[:...]". But it turns out that if you're slow to swap the discs, we'll hit dracut's retry timeout and it'll drop to the emergency shell. So, in response to User Requests, we now disable the timeout entirely when using "inst.ks=cdrom[:...]"; dracut will wait forever for the kickstart and/or installer media, and if anything goes wrong you're just stuck and you'll need to reset. Resolves: rhbz#1168902 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/231

1 4

[master/rhel7-branch] Auto-load ks.cfg if OEMDRV volume available. (#1057271)
by Samantha N. Bueno 22 Jul '15

22 Jul '15

This checks if there are any OEMDRV labelled storage volumes available; if yes, load a ks.cfg file from that. This should only happen if a user has not manually specified a ks= option themselves. Thanks to Will Woods <wwoods(a)redhat.com> for helping out with this. Resolves: rhbz#1057271 --- dracut/kickstart-genrules.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/dracut/kickstart-genrules.sh b/dracut/kickstart-genrules.sh index 3b83d6c..eb58b2a 100755 --- a/dracut/kickstart-genrules.sh +++ b/dracut/kickstart-genrules.sh @@ -24,4 +24,10 @@ case "${kickstart%%:*}" in bd) # bd:<dev>:<path> - biospart (TODO... if anyone uses this anymore) warn "inst.ks: can't get kickstart - biospart (bd:) isn't supported yet" ;; + "") + if [ -z "$kickstart" ]; then + when_diskdev_appears $(disk_to_dev_path LABEL=OEMDRV) \ + fetch-kickstart-disk \$env{DEVNAME} "/ks.cfg" + fi + ;; esac -- 1.9.3

2 1

Updated: [rhinstaller/blivet/pulls/176 master] Add install-requires Makefile target
by dashea 21 Jul '15

21 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/176

1 6

New: [rhinstaller/blivet/pulls/175 master] Get blivet unit test suite running again
by dashea 21 Jul '15

21 Jul '15

Apparently when I made pylint a part of my development process I stopped running the unit tests. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/175

1 14

New: [rhinstaller/anaconda/pulls/226 master] Change the generated API indices slightly
by dashea 21 Jul '15

21 Jul '15

gtk-doc doesn't like the xi:include line in the api-index-full section anymore, so remove it. Add index pages for the AnacondaWidgets versions that added symbols. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/226

1 5

New: [rhinstaller/anaconda/pulls/225 master] Consolidate the language environment variables.
by dashea 21 Jul '15

21 Jul '15

Make use of the information in $LANGUAGE, $LC_ALL, or $LC_MESSAGES, if set. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/225

1 5

New: [rhinstaller/anaconda/pulls/227 master] Rescue tests
by dashea 21 Jul '15

21 Jul '15

Fix the test failures in the new rescue mode. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/227

1 8

Updated: [rhinstaller/anaconda/pulls/220 master] act on the right objects when stripping URL protocols (#1243962)
by dashea 21 Jul '15

21 Jul '15

efa549ef introduced a _removeUrlPrefix() method which expected its 'editable' parameter to be a GtkEntry (either the base repo URL entry box, or an additional repo's URL entry box). However, it had the on_repoUrl_changed() handler call _removeUrlPrefix() with its own 'editable' parameter, and then had the protocol combo box call the on_repoUrl_changed() handler when it was changed, as well as the URL entry box. The intent is that if, say, you paste in 'https://www.repo.com' while the protocol is set to http://, then change the protocol to https://, the protocol will get stripped - but because 'editable' in this case is the GtkComboBoxText, not the GtkEntry, it all goes wrong and crashes. The crash is reproducible by adding a supplementary repo, entering a URL, then changing the protocol. This adjusts things so the handler functions that call _removeUrlPrefix() don't pass in their own 'editable' params but always pass in the appropriate GtkEntry. It also makes the protocol combo box for the base repo call the appropriate handler function as well as the text entry box - matching the behaviour the original commit introduced for the additional repo widgets (I guess this was simply overlooked at the time). I've tested this and all four widgets now behave as expected, and there are no crashes. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/220

1 5

Updated: [rhinstaller/anaconda/pulls/204 master] Source spoke master fix
by dashea 21 Jul '15

21 Jul '15

I want to fix source spoke which was somewhat broken and I found that this change will be somewhat bigger than I expected :). So in short: * Change hashing of repositories to special IDs (they are attached to existing RepoData instances) * Checks can now test even not selected objects * Check repositories URL before leaving spoke * Some minor fixes *This is some kind of RFE so please feel free to tell me if there is better solution* -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/204

1 2

New: [rhinstaller/anaconda/pulls/224 master] Fix crash when protocol combobox changed item
by dashea 21 Jul '15

21 Jul '15

The method `on_repoUrl_changed` in Source spoke is now called by `Gtk.Entry` and `Gtk.ComboBoxText` too. This caused crash in a method depending on `Gtk.Entry` but sometimes gets `ComboBoxText` instead. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/224

1 5

[python-meh][rhel7-branch][PATCH] Switch to Zanata for translations (#1244814)
by Martin Kolman 20 Jul '15

20 Jul '15

Anaconda switched to Zanata, so switch also python-meh to use Zanata for translations. Resolves: rhbz#1244814 Signed-off-by: Martin Kolman <mkolman(a)redhat.com> --- .tx/config | 8 ----- Makefile | 9 ++++-- zanata.xml | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 113 insertions(+), 10 deletions(-) delete mode 100644 .tx/config create mode 100644 zanata.xml diff --git a/.tx/config b/.tx/config deleted file mode 100644 index 7f2655b..0000000 --- a/.tx/config +++ /dev/null @@ -1,8 +0,0 @@ -[main] -host = https://www.transifex.com - -[python-meh.master] -file_filter = po/<lang>.po -source_file = po/python-meh.pot -source_lang = en - diff --git a/Makefile b/Makefile index d0a9784..6a9db6a 100644 --- a/Makefile +++ b/Makefile @@ -9,6 +9,9 @@ TESTSUITE:=tests/baseclass.py PYCHECKEROPTS=--no-argsused --no-miximport --maxargs 0 --no-local -\# 0 --only -Q +ZANATA_PULL_ARGS = --transdir po/ +ZANATA_PUSH_ARGS = --srcdir po/ --push-type source --force + default: all all: @@ -65,10 +68,12 @@ potfile: $(MAKE) -C po potfile po-pull: - tx pull -a --disable-overwrite + rpm -q zanata-python-client &>/dev/null || ( echo "need to run: yum install zanata-python-client"; exit 1 ) + zanata pull $(ZANATA_PULL_ARGS) bumpver: potfile - tx push -s + rpm -q zanata-python-client &>/dev/null || ( echo "need to run: yum install zanata-python-client"; exit 1 ) + zanata push $(ZANATA_PUSH_ARGS) || ( echo "zanata push failed"; exit 1 ) @NEWSUBVER=$$((`echo $(VERSION) |cut -d . -f 2` + 1)) ; \ NEWVERSION=`echo $(VERSION).$$NEWSUBVER |cut -d . -f 1,3` ; \ DATELINE="* `date "+%a %b %d %Y"` `git config user.name` <`git config user.email`> - $$NEWVERSION-1" ; \ diff --git a/zanata.xml b/zanata.xml new file mode 100644 index 0000000..0ec4280 --- /dev/null +++ b/zanata.xml @@ -0,0 +1,106 @@ +<?xml version="1.0" encoding="UTF-8" standalone="yes"?> +<config xmlns="http://zanata.org/namespace/config/"> + <url>https://fedora.zanata.org/</url> + <project>python-meh</project> + <project-version>rhel7-branch</project-version> + <project-type>gettext</project-type> + + <locales> + <locale>sq</locale> + <locale>ar</locale> + <locale>as</locale> + <locale>ast</locale> + <locale>bal</locale> + <locale>eu</locale> + <locale>bn</locale> + <locale>bn-IN</locale> + <locale>brx</locale> + <locale>bs</locale> + <locale>br</locale> + <locale>bg</locale> + <locale>ca</locale> + <locale>zh-CN</locale> + <locale>zh-HK</locale> + <locale>zh-TW</locale> + <locale>kw</locale> + <locale>kw-GB</locale> + <locale>cs</locale> + <locale>da</locale> + <locale>nl</locale> + <locale>en-GB</locale> + <locale>eo</locale> + <locale>et</locale> + <locale>fi</locale> + <locale>fr</locale> + <locale>gl</locale> + <locale>ka</locale> + <locale>de</locale> + <locale>el</locale> + <locale>gu</locale> + <locale>he</locale> + <locale>hi</locale> + <locale>hu</locale> + <locale>is</locale> + <locale>id</locale> + <locale>ia</locale> + <locale>it</locale> + <locale>ja</locale> + <locale>kn</locale> + <locale>kk</locale> + <locale>km</locale> + <locale>ky</locale> + <locale>ko</locale> + <locale>lt</locale> + <locale>nds</locale> + <locale>mk</locale> + <locale>mai</locale> + <locale>ms</locale> + <locale>ml</locale> + <locale>mr</locale> + <locale>mn</locale> + <locale>ne</locale> + <locale>nb</locale> + <locale>nn</locale> + <locale>or</locale> + <locale>pa</locale> + <locale>fa</locale> + <locale>pl</locale> + <locale>pt</locale> + <locale>pt-BR</locale> + <locale>ro</locale> + <locale>ru</locale> + <locale>sr</locale> + <locale>sr@latin</locale> + <locale>si</locale> + <locale>sk</locale> + <locale>sl</locale> + <locale>es</locale> + <locale>sv</locale> + <locale>tg</locale> + <locale>ta</locale> + <locale>te</locale> + <locale>bo</locale> + <locale>tr</locale> + <locale>uk</locale> + <locale>ur</locale> + <locale>wba</locale> + <locale>cy</locale> + <locale>lv</locale> + <locale>kw@uccor</locale> + <locale>kw@kkcor</locale> + <locale>af</locale> + <locale>am</locale> + <locale>be</locale> + <locale>hr</locale> + <locale>de-CH</locale> + <locale>th</locale> + <locale>vi</locale> + <locale>zu</locale> + <locale>ilo</locale> + <locale>nso</locale> + <locale>tw</locale> + <locale>yo</locale> + <locale>anp</locale> + </locales> + +</config> -- 2.4.3

2 1

[initial-setup][rhel7-branch][PATCH] Switch to Zanata for translations (#1229747)
by Martin Kolman 20 Jul '15

20 Jul '15

Anaconda switched to Zanata, so switch also Initial Setup to use Zanata for translations. Related: rhbz#1229747 Signed-off-by: Martin Kolman <mkolman(a)redhat.com> --- .tx/config | 9 ------ Makefile | 10 +++++- zanata.xml | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 115 insertions(+), 10 deletions(-) delete mode 100644 .tx/config create mode 100644 zanata.xml diff --git a/.tx/config b/.tx/config deleted file mode 100644 index b1371eb..0000000 --- a/.tx/config +++ /dev/null @@ -1,9 +0,0 @@ -[main] -host = https://www.transifex.com - -[initial-setup.rhel7-branch] -file_filter = po/<lang>.po -source_file = po/initial-setup.pot -source_lang = en -type = PO - diff --git a/Makefile b/Makefile index f890124..c27a955 100644 --- a/Makefile +++ b/Makefile @@ -20,6 +20,9 @@ ANACONDA_PATH=${HOME}/Work/anaconda/msivak PYKICKSTART_PATH=${HOME}/Work/pykickstart/master +ZANATA_PULL_ARGS = --transdir po/ +ZANATA_PUSH_ARGS = --srcdir po/ --push-type source --force + default: all all: po-files @@ -77,7 +80,12 @@ potfile: $(MAKE) -C po potfile po-pull: - tx pull -a --disable-overwrite + rpm -q zanata-python-client &>/dev/null || ( echo "need to run: dnf install zanata-python-client"; exit 1 ) + zanata pull $(ZANATA_PULL_ARGS) + +po-push: + rpm -q zanata-python-client &>/dev/null || ( echo "need to run: dnf install zanata-python-client"; exit 1 ) + zanata push $(ZANATA_PUSH_ARGS) || ( echo "zanata push failed"; exit 1 ) install-po-files: $(MAKE) -C po install diff --git a/zanata.xml b/zanata.xml new file mode 100644 index 0000000..61b0e27 --- /dev/null +++ b/zanata.xml @@ -0,0 +1,106 @@ +<?xml version="1.0" encoding="UTF-8" standalone="yes"?> +<config xmlns="http://zanata.org/namespace/config/"> + <url>https://fedora.zanata.org/</url> + <project>initial-setup</project> + <project-version>rhel7-branch</project-version> + <project-type>gettext</project-type> + + <locales> + <locale>sq</locale> + <locale>ar</locale> + <locale>as</locale> + <locale>ast</locale> + <locale>bal</locale> + <locale>eu</locale> + <locale>bn</locale> + <locale>bn-IN</locale> + <locale>brx</locale> + <locale>bs</locale> + <locale>br</locale> + <locale>bg</locale> + <locale>ca</locale> + <locale>zh-CN</locale> + <locale>zh-HK</locale> + <locale>zh-TW</locale> + <locale>kw</locale> + <locale>kw-GB</locale> + <locale>cs</locale> + <locale>da</locale> + <locale>nl</locale> + <locale>en-GB</locale> + <locale>eo</locale> + <locale>et</locale> + <locale>fi</locale> + <locale>fr</locale> + <locale>gl</locale> + <locale>ka</locale> + <locale>de</locale> + <locale>el</locale> + <locale>gu</locale> + <locale>he</locale> + <locale>hi</locale> + <locale>hu</locale> + <locale>is</locale> + <locale>id</locale> + <locale>ia</locale> + <locale>it</locale> + <locale>ja</locale> + <locale>kn</locale> + <locale>kk</locale> + <locale>km</locale> + <locale>ky</locale> + <locale>ko</locale> + <locale>lt</locale> + <locale>nds</locale> + <locale>mk</locale> + <locale>mai</locale> + <locale>ms</locale> + <locale>ml</locale> + <locale>mr</locale> + <locale>mn</locale> + <locale>ne</locale> + <locale>nb</locale> + <locale>nn</locale> + <locale>or</locale> + <locale>pa</locale> + <locale>fa</locale> + <locale>pl</locale> + <locale>pt</locale> + <locale>pt-BR</locale> + <locale>ro</locale> + <locale>ru</locale> + <locale>sr</locale> + <locale>sr@latin</locale> + <locale>si</locale> + <locale>sk</locale> + <locale>sl</locale> + <locale>es</locale> + <locale>sv</locale> + <locale>tg</locale> + <locale>ta</locale> + <locale>te</locale> + <locale>bo</locale> + <locale>tr</locale> + <locale>uk</locale> + <locale>ur</locale> + <locale>wba</locale> + <locale>cy</locale> + <locale>lv</locale> + <locale>kw@uccor</locale> + <locale>kw@kkcor</locale> + <locale>af</locale> + <locale>am</locale> + <locale>be</locale> + <locale>hr</locale> + <locale>de-CH</locale> + <locale>th</locale> + <locale>vi</locale> + <locale>zu</locale> + <locale>ilo</locale> + <locale>nso</locale> + <locale>tw</locale> + <locale>yo</locale> + <locale>anp</locale> + </locales> + +</config> -- 2.4.3

2 1

New: [rhinstaller/blivet/pulls/176 master] Add install-requires Makefile target
by dashea 20 Jul '15

20 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/176

1 1

New: [rhinstaller/anaconda/pulls/101 rhel7-branch] Do not create HFS+ EFI partition on Intel Macs
by dashea 20 Jul '15

20 Jul '15

This commit complements blivet's c35aafe4b27318faee52b5a0ea44ca9a6fd4a1ec because RHEL7 doesn't support working with HFS+ partitions. The HW boots just fine with VFAT EFI system partition. The downside of using VFAT is that there aren't pretty menus, but I prefer no menus but working system over non-working system each time. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/101

1 12

New: [rhinstaller/anaconda/pulls/214 master] Added package logging to anaconda.log.
by dashea 20 Jul '15

20 Jul '15

Minor update, package operations are now logged in main anaconda.log file. Signed-off-by: Karel Valek <kvalek(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/214

1 10

New: [rhinstaller/lorax/pulls/33 master] verify that everything in /usr/bin and /usr/sbin is still runnable after cleanup
by dashea 20 Jul '15

20 Jul '15

spice-vdagent, part of the thing that makes copy/paste work between a host and a virt guest, is missing libraries in rawhide. It isn't as noticeable when spice-vdagent breaks as it is, say, when dhclient breaks, so it's probably been broken for a little while. I would like changes like this to be less of a surprise. I don't have any strong opinions about whether verify should be on or off by default as long as the jenkins job runs with it on. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/33

1 9

New: [rhinstaller/lorax/pulls/31 rhel7-branch] Add a custom RHEL tagger for tito
by dashea 20 Jul '15

20 Jul '15

The default tagger doesn't add Related/Resolves lines to the changelog, resulting in builds that have to be fixed up manually. The output from this code still needs to be edited to remove the '-' prefix from the Related/Resolves lines because tito appends them to every line of output from the Tagger. But this is better than having to add them manually. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/31

1 7

New: [rhinstaller/lorax/pulls/32 master] Create an empty selinux config file (#1243168)
by dashea 20 Jul '15

20 Jul '15

In order for selinux to properly label the system it needs to see that the config file exists. Also remove the old code trying to copy in a selinux config file, it never worked -- the removepkg would remove it. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/32

2 6

Updated: [rhinstaller/anaconda/pulls/219 master] Display source errors in the spoke's info bar
by dashea 20 Jul '15

20 Jul '15

also makes it clickable and shows verbose errors in a dialog. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/219

1 6

New: [rhinstaller/blivet/pulls/173 master] Add make-sphinx-docs helper script
by dashea 20 Jul '15

20 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/173

1 8

Updated: [rhinstaller/anaconda/pulls/109 f22-branch] Don't use $LANGUAGE if empty (#1222262)
by dashea 20 Jul '15

20 Jul '15

KDE sets $LANGUAGE to an empty string for some mysterious reason, and they know about it, and they ain't gonna fix it. Ignore $LANGUAGE if it's an empty string because a careful reading of the man page says that $LANGUAGE only counts if it contains something and an empty $LANGUAGE breaks everything. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/109

1 4

[master/rhel7-branch] New rescue mode (take II)
by Samantha N. Bueno 20 Jul '15

20 Jul '15

Includes bcl's suggestions. I couldn't really see any Requires to remove, but someone else clue me in since I'm sure I might be missing something.

3 8

New: [rhinstaller/anaconda/pulls/223 master] prune some dead code
by dashea 20 Jul '15

20 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/223

1 11

Updated: [rhinstaller/anaconda/pulls/203 master] Decode wifi SSIDs into strings. (#1240398)
by dashea 20 Jul '15

20 Jul '15

Use the chardet module to try to detect what encoding the SSID uses. Add a column to the wireless network ListStore in the network spoke to store the original byte sequence (also encoded as a string because GLib is awful at storing byte sequences). -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/203

1 5

Updated: [rhinstaller/anaconda/pulls/218 master] a couple more things related to the tests
by dashea 20 Jul '15

20 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/218

1 7

New: [rhinstaller/anaconda/pulls/222 master] config the dnf-langpacks plugin
by dashea 20 Jul '15

20 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/222

1 12

Updated: [rhinstaller/anaconda/pulls/204 master] Source spoke master fix
by dashea 20 Jul '15

20 Jul '15

I want to fix source spoke which was somewhat broken and I found that this change will be somewhat bigger than I expected :). So in short: * Change hashing of repositories to special IDs (they are attached to existing RepoData instances) * Checks can now test even not selected objects * Check repositories URL before leaving spoke * Some minor fixes *This is some kind of RFE so please feel free to tell me if there is better solution* -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/204

1 1

Updated: [rhinstaller/python-meh/pulls/5 master] Use pocketlint for running pylint on python-meh
by dashea 20 Jul '15

20 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/python-meh/pull/5

1 14

Updated: [rhinstaller/anaconda/pulls/208 master] Fix possible to start installation without network (#1221109)
by dashea 20 Jul '15

20 Jul '15

Payload manager is started from network spoke if network settings change. This will start source spoke and software spoke reach-ability testing. *Resolves: rhbz#1221109* -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/208

1 6

New: [rhinstaller/anaconda/pulls/204 master] Source spoke master fix
by dashea 20 Jul '15

20 Jul '15

I want to fix source spoke which was somewhat broken and I found that this change will be somewhat bigger than I expected :). So in short: * Change hashing of repositories to special IDs (they are attached to existing RepoData instances) * Checks can now test even not selected objects * Check repositories URL before leaving spoke * Some minor fixes *This is some kind of RFE so please free to tell me if there is better solution* -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/204

1 12

New: [rhinstaller/anaconda/pulls/221 master] Fix 'q' (to quit) do not work in TUI hub
by dashea 20 Jul '15

20 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/221

1 6

[PATCH] Fix the validate functions in the btrfs kickstart_tests.
by Chris Lumens 20 Jul '15

20 Jul '15

This function is passed a directory containing the disk images, and not the path to the disk images itself. Use the same code I'm using elsewhere. Also, btrfs-1.ks needs to shutdown at the end of installation. --- tests/kickstart_tests/btrfs-1.ks | 2 +- tests/kickstart_tests/btrfs-1.sh | 5 +++-- tests/kickstart_tests/btrfs-2.sh | 5 +++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/kickstart_tests/btrfs-1.ks b/tests/kickstart_tests/btrfs-1.ks index 03eeeae..eb8f45f 100644 --- a/tests/kickstart_tests/btrfs-1.ks +++ b/tests/kickstart_tests/btrfs-1.ks @@ -19,7 +19,7 @@ keyboard us lang en timezone America/New_York rootpw qweqwe -#shutdown +shutdown %packages @core diff --git a/tests/kickstart_tests/btrfs-1.sh b/tests/kickstart_tests/btrfs-1.sh index dd83fb0..9b0c90a 100755 --- a/tests/kickstart_tests/btrfs-1.sh +++ b/tests/kickstart_tests/btrfs-1.sh @@ -20,12 +20,13 @@ . ${KSTESTDIR}/functions.sh validate() { - img=$1 + disksdir=$1 + args=$(for d in ${disksdir}/*img; do echo -a ${d}; done) # There should be a /root/root/RESULT file with results in it. Check # its contents and decide whether the test finally succeeded or # not. - result=$(virt-cat -a ${img} -m /dev/sda2 /root/root/RESULT) + result=$(virt-cat ${args} -m /dev/sda2 /root/root/RESULT) if [[ $? != 0 ]]; then status=1 echo '*** /root/RESULT does not exist in VM image.' diff --git a/tests/kickstart_tests/btrfs-2.sh b/tests/kickstart_tests/btrfs-2.sh index dd83fb0..9b0c90a 100755 --- a/tests/kickstart_tests/btrfs-2.sh +++ b/tests/kickstart_tests/btrfs-2.sh @@ -20,12 +20,13 @@ . ${KSTESTDIR}/functions.sh validate() { - img=$1 + disksdir=$1 + args=$(for d in ${disksdir}/*img; do echo -a ${d}; done) # There should be a /root/root/RESULT file with results in it. Check # its contents and decide whether the test finally succeeded or # not. - result=$(virt-cat -a ${img} -m /dev/sda2 /root/root/RESULT) + result=$(virt-cat ${args} -m /dev/sda2 /root/root/RESULT) if [[ $? != 0 ]]; then status=1 echo '*** /root/RESULT does not exist in VM image.' -- 2.4.3

2 1

[PATCH blivet] Don't pass createOptions along when creating the btrfs device.
by Chris Lumens 20 Jul '15

20 Jul '15

This only applies to the format, not the device. Thus this needs to be popped off before passing the rest of the kwargs along. This was found by kickstart_tests in anaconda. --- blivet/blivet.py | 1 + blivet/devices/btrfs.py | 4 +++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/blivet/blivet.py b/blivet/blivet.py index 3cdf629..d27e072 100644 --- a/blivet/blivet.py +++ b/blivet/blivet.py @@ -1013,6 +1013,7 @@ class Blivet(object): fmt_args["subvolspec"] = name kwargs.pop("metaDataLevel", None) kwargs.pop("dataLevel", None) + kwargs.pop("createOptions", None) else: dev_class = BTRFSVolumeDevice # set up the volume label, using hostname if necessary diff --git a/blivet/devices/btrfs.py b/blivet/devices/btrfs.py index d336f91..788ff83 100644 --- a/blivet/devices/btrfs.py +++ b/blivet/devices/btrfs.py @@ -179,6 +179,7 @@ class BTRFSVolumeDevice(BTRFSDevice, ContainerDevice, RaidDevice): # unrecognized keyword error in superclass constructor dataLevel = kwargs.pop("dataLevel", None) metaDataLevel = kwargs.pop("metaDataLevel", None) + createOptions = kwargs.pop("createOptions", None) super(BTRFSVolumeDevice, self).__init__(*args, **kwargs) @@ -207,7 +208,8 @@ class BTRFSVolumeDevice(BTRFSDevice, ContainerDevice, RaidDevice): volUUID=self.uuid, device=self.path, subvolspec=self.vol_id, - mountopts="subvolid=%d" % self.vol_id) + mountopts="subvolid=%d" % self.vol_id, + createOptions=createOptions) self.originalFormat = copy.deepcopy(self.format) self._defaultSubVolumeID = None -- 2.4.3

2 2

Updated: [rhinstaller/anaconda/pulls/199 master] Kickstart service test: enable / disable.
by dashea 20 Jul '15

20 Jul '15

Tested services: sshd (disable), systemd-timesyncd (enable), systemd-networkd (disabled in config, test). Signed-off-by: Karel Valek <kvalek(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/199

1 7

Updated: [rhinstaller/anaconda/pulls/174 rhel7-branch] Ask for encryption passphrase when not specified in ks (#1185466)
by dashea 18 Jul '15

18 Jul '15

New (and I hope better) version of https://github.com/rhinstaller/anaconda/pull/140 Kickstart installation fails when '--encrypted' is used without specifying '--passphrase'. This patch marks the storage spoke as unready and asks for a passphrase. Resolves: rhbz#1185466 Signed-off-by: Vojtech Trefny <vtrefny(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/174

1 5

Updated: [rhinstaller/blivet/pulls/59 master] Implement the __dir__ method of the LazyImportObject class
by dashea 17 Jul '15

17 Jul '15

This makes the 'TAB-TAB' completion in ipython and dir() calls work as if the lazy-imported object was imported in a normal way. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/59

1 2

New: [rhinstaller/lorax/pulls/30 master] Update Lorax documentation - 23.12
by dashea 17 Jul '15

17 Jul '15

Add documentation for the new monitor and mount modules. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/30

1 4

Updated: [rhinstaller/anaconda/pulls/182 master] Driverdisk refactor
by dashea 17 Jul '15

17 Jul '15

Okay, here it is - the big refactor of driver-updates. `README.dd` still needs to be updated, but the code is all here. It also adds a suite of unit tests for `driver-updates` and a kickstart test for the `driverdisk` command. Other than some minor text changes the overall behavior should be the same, except for one thing: we no longer attempt to unload running modules. (This is, I think, outside the scope of what problems the driver-updates stuff is designed to solve. `modprobe.blacklist` can handle the rare cases where a driver-updates disk needs to replace an existing module.) Resolves: RHBZ#1084197 Resolves: RHBZ#1164131 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/182

1 12

Updated: [rhinstaller/anaconda/pulls/208 master] Fix possible to start installation without network (#1221109)
by dashea 17 Jul '15

17 Jul '15

Payload manager is started from network spoke if network settings change. This will start source spoke and software spoke reach-ability testing. *Resolves: rhbz#1221109* -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/208

1 3

Updated: [rhinstaller/anaconda/pulls/220 master] act on the right objects when stripping URL protocols (#1243962)
by dashea 17 Jul '15

17 Jul '15

efa549ef introduced a _removeUrlPrefix() method which expected its 'editable' parameter to be a GtkEntry (either the base repo URL entry box, or an additional repo's URL entry box). However, it had the on_repoUrl_changed() handler call _removeUrlPrefix() with its own 'editable' parameter, and then had the protocol combo box call the on_repoUrl_changed() handler when it was changed, as well as the URL entry box. The intent is that if, say, you paste in 'https://www.repo.com' while the protocol is set to http://, then change the protocol to https://, the protocol will get stripped - but because 'editable' in this case is the GtkComboBoxText, not the GtkEntry, it all goes wrong and crashes. The crash is reproducible by adding a supplementary repo, entering a URL, then changing the protocol. This adjusts things so the handler functions that call _removeUrlPrefix() don't pass in their own 'editable' params but always pass in the appropriate GtkEntry. It also makes the protocol combo box for the base repo call the appropriate handler function as well as the text entry box - matching the behaviour the original commit introduced for the additional repo widgets (I guess this was simply overlooked at the time). I've tested this and all four widgets now behave as expected, and there are no crashes. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/220

1 1

New: [rhinstaller/anaconda/pulls/210 master] Fix 'App' object has no attribute 'queue' (#1243316)
by dashea 17 Jul '15

17 Jul '15

Bad name of App property queue. The name needs to be queue_instance. Fix import queue as queue :) *Resolves: rhbz#1243316* -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/210

1 7

[blivet] bump size of non-existent devices to format min
by David Lehman 17 Jul '15

17 Jul '15

This is another followup to the patch from last week that checks device size against new format limits. This one covers the case of a partition or lv instantiated with a size that's too small for its format metadata. This is going to happen regularly when people have kickstarts that do this: part pv.01 --size=1 --grow (The lvmpv format has a min size of 8 MiB.) This seems reasonable to me because I cannot imagine anyone actually wanting a device smaller than any estimated minimum size for the format. When that person does come along, he/she can be told that is something they will have to do outside of anaconda (and blivet). For the sake of completeness, the other options to handle this were: 1. raise an exception when the size is too small (current behavior) 2. add some machinery to blivet to postpone the checks for growable partitions and lvs until after they've been allocated My assessment: #1 is too user-hostile and #2 is too much work to accommodate a fairly silly corner case (user wants to make a really tiny PV or BTRFS member).

3 3

[PATCH blivet rhel7-branch] Fix two pylint problems.
by Chris Lumens 17 Jul '15

17 Jul '15

(1) is just pylint not liking something named "dir". (2) is a legitimate bug - it's disk.format.partedDevice elsewhere in this function. --- blivet/devicelibs/dasd.py | 4 ++-- tests/devices_test.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/blivet/devicelibs/dasd.py b/blivet/devicelibs/dasd.py index 965b4be..eb4da80 100644 --- a/blivet/devicelibs/dasd.py +++ b/blivet/devicelibs/dasd.py @@ -55,8 +55,8 @@ _IOC_NONE = 0 _IOC_WRITE = 1 _IOC_READ = 2 -def _IOC(dir, typ, nr, size): - return (((dir) << _IOC_DIRSHIFT) | \ +def _IOC(direction, typ, nr, size): + return (((direction) << _IOC_DIRSHIFT) | \ ((typ) << _IOC_TYPESHIFT) | \ ((nr) << _IOC_NRSHIFT) | \ ((size) << _IOC_SIZESHIFT)) diff --git a/tests/devices_test.py b/tests/devices_test.py index 3239049..3499341 100644 --- a/tests/devices_test.py +++ b/tests/devices_test.py @@ -797,7 +797,7 @@ class PartitionDeviceTestCase(unittest.TestCase): free = disk.format.partedDisk.getFreeSpaceRegions()[-1] raw_start = int(Size("9 MiB") / sector_size) start = disk.format.alignment.alignUp(free, raw_start) + 3 - disk.format.addPartition(start, disk.partedDevice.length - 1) + disk.format.addPartition(start, disk.format.partedDevice.length - 1) # Verify the end of the free region immediately following the first # partition is unaligned. -- 2.4.3

2 1

[PATCH] Don't try to iterate over threads directly in wait_all.
by Chris Lumens 17 Jul '15

17 Jul '15

Someone may add or remove a thread mid-iteration, which causes a RuntimeError. Instead, grab a copy of all the thread names and then iterate over that. --- pyanaconda/threads.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pyanaconda/threads.py b/pyanaconda/threads.py index 8f52260..1e8082f 100644 --- a/pyanaconda/threads.py +++ b/pyanaconda/threads.py @@ -120,7 +120,12 @@ class ThreadManager(object): def wait_all(self): """Wait for all threads to exit and if there was an error re-raise it. """ - for name in self._objs.keys(): + names = [] + + with self._objs_lock: + names = self._objs.keys() + + for name in names: if self.get(name) == threading.current_thread(): continue log.debug("Waiting for thread %s to exit", name) -- 2.4.3

2 1

New: [rhinstaller/anaconda/pulls/207 rhel7-branch] network: add s390 options to default ifcfg files (#1074570)
by dashea 17 Jul '15

17 Jul '15

Resolves: rhbz#1074570 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/207

1 10

[anaconda][rhel7-branch][PATCH] Backport architecture support for help files
by Martin Kolman 17 Jul '15

17 Jul '15

As Fedora does not have architecture specific help file variants, this change was overwritten by the rebase. So bring it back. Martin Kolman (1): Add support for architecture suffixes in help files (#1072033) pyanaconda/ihelp.py | 43 ++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 42 insertions(+), 1 deletion(-) -- 2.4.3

2 3

Updated: [rhinstaller/anaconda/pulls/220 master] act on the right objects when stripping URL protocols (#1243962)
by dashea 16 Jul '15

16 Jul '15

efa549ef introduced a _removeUrlPrefix() method which expected its 'editable' parameter to be a GtkEntry (either the base repo URL entry box, or an additional repo's URL entry box). However, it had the on_repoUrl_changed() handler call _removeUrlPrefix() with its own 'editable' parameter, and then had the protocol combo box call the on_repoUrl_changed() handler when it was changed, as well as the URL entry box. The intent is that if, say, you paste in 'https://www.repo.com' while the protocol is set to http://, then change the protocol to https://, the protocol will get stripped - but because 'editable' in this case is the GtkComboBoxText, not the GtkEntry, it all goes wrong and crashes. The crash is reproducible by adding a supplementary repo, entering a URL, then changing the protocol. This adjusts things so the handler functions that call _removeUrlPrefix() don't pass in their own 'editable' params but always pass in the appropriate GtkEntry. It also makes the protocol combo box for the base repo call the appropriate handler function as well as the text entry box - matching the behaviour the original commit introduced for the additional repo widgets (I guess this was simply overlooked at the time). I've tested this and all four widgets now behave as expected, and there are no crashes. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/220

1 0

Updated: [rhinstaller/anaconda/pulls/220 master] act on the right objects when stripping URL protocols (#1243962)
by dashea 16 Jul '15

16 Jul '15

efa549ef introduced a _removeUrlPrefix() method which expected its 'editable' parameter to be a GtkEntry (either the base repo URL entry box, or an additional repo's URL entry box). However, it had the on_repoUrl_changed() handler call _removeUrlPrefix() with its own 'editable' parameter, and then had the protocol combo box call the on_repoUrl_changed() handler when it was changed, as well as the URL entry box. The intent is that if, say, you paste in 'https://www.repo.com' while the protocol is set to http://, then change the protocol to https://, the protocol will get stripped - but because 'editable' in this case is the GtkComboBoxText, not the GtkEntry, it all goes wrong and crashes. The crash is reproducible by adding a supplementary repo, entering a URL, then changing the protocol. This adjusts things so the handler functions that call _removeUrlPrefix() don't pass in their own 'editable' params but always pass in the appropriate GtkEntry. It also makes the protocol combo box for the base repo call the appropriate handler function as well as the text entry box - matching the behaviour the original commit introduced for the additional repo widgets (I guess this was simply overlooked at the time). I've tested this and all four widgets now behave as expected, and there are no crashes. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/220

1 0

New: [rhinstaller/anaconda/pulls/220 master] act on the right objects when stripping URL protocols (#1243962)
by dashea 16 Jul '15

16 Jul '15

efa549ef introduced a _removeUrlPrefix() method which expected its 'editable' parameter to be a GtkEntry (either the base repo URL entry box, or an additional repo's URL entry box). However, it had the on_repoUrl_changed() handler call _removeUrlPrefix() with its own 'editable' parameter, and then had the protocol combo box call the on_repoUrl_changed() handler when it was changed, as well as the URL entry box. The intent is that if, say, you paste in 'https://www.repo.com' while the protocol is set to http://, then change the protocol to https://, the protocol will get stripped - but because 'editable' in this case is the GtkComboBoxText, not the GtkEntry, it all goes wrong and crashes. The crash is reproducible by adding a supplementary repo, entering a URL, then changing the protocol. This adjusts things so the handler functions that call _removeUrlPrefix() don't pass in their own 'editable' params but always pass in the appropriate GtkEntry. It also makes the protocol combo box for the base repo call the appropriate handler function as well as the text entry box - matching the behaviour the original commit introduced for the additional repo widgets (I guess this was simply overlooked at the time). I've tested this and all four widgets now behave as expected, and there are no crashes. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/220

1 1

Updated: [rhinstaller/anaconda/pulls/209 master] fix storage writing for live and ostree installs (#1236937)
by dashea 16 Jul '15

16 Jul '15

3e800998 broke storage writing in two cases: regular live installs and ostree installs. The old write_storage_late check checked for flags.livecdInstall and ksdata.ostreesetup.seen as well as ksdata.method.method == "liveimg". The new check in writeStorageLate() dropped those two, only keeping the method check. The method is only 'liveimg' when doing a kickstart-driven install with the 'liveimg' parameter, which is a fairly niche case - the method is not 'liveimg' on a regular live install (it's 'harddrive'). -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/209

1 5

New: [rhinstaller/python-meh/pulls/5 master] Use pocketlint for running pylint on python-meh
by dashea 16 Jul '15

16 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/python-meh/pull/5

1 8

Updated: [rhinstaller/anaconda/pulls/218 master] a couple more things related to the tests
by dashea 16 Jul '15

16 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/218

1 2

New: [rhinstaller/anaconda/pulls/219 master] Display source errors in the spoke's info bar
by dashea 16 Jul '15

16 Jul '15

also makes it clickable and shows verbose errors in a dialog. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/219

1 2

New: [rhinstaller/anaconda/pulls/218 master] a couple more things related to the tests
by dashea 16 Jul '15

16 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/218

1 2

Updated: [rhinstaller/anaconda/pulls/209 master] fix storage writing for live and ostree installs (#1236937)
by dashea 16 Jul '15

16 Jul '15

3e800998 broke storage writing in two cases: regular live installs and ostree installs. The old write_storage_late check checked for flags.livecdInstall and ksdata.ostreesetup.seen as well as ksdata.method.method == "liveimg". The new check in writeStorageLate() dropped those two, only keeping the method check. The method is only 'liveimg' when doing a kickstart-driven install with the 'liveimg' parameter, which is a fairly niche case - the method is not 'liveimg' on a regular live install (it's 'harddrive'). -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/209

1 1

New: [rhinstaller/anaconda/pulls/217 master] Add O_CREAT to the open flags when extracting rpm files.
by dashea 16 Jul '15

16 Jul '15

That chmod commit broke dd_extract. Oops. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/217

1 3

New: [rhinstaller/anaconda/pulls/216 master] Move ostree gobject version check next to the import (#1243543)
by dashea 16 Jul '15

16 Jul '15

ostree is optional and may not be included in the environment that anaconda is running in, so only check the version if it is actually going to be used. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/216

1 4

New: [rhinstaller/anaconda/pulls/209 master] fix storage writing for live and ostree installs (#1236937)
by dashea 16 Jul '15

16 Jul '15

3e800998 broke storage writing in two cases: regular live installs and ostree installs. The old write_storage_late check checked for flags.livecdInstall and ksdata.ostreesetup.seen as well as ksdata.method.method == "liveimg". The new check in writeStorageLate() dropped those two, only keeping the method check. The method is only 'liveimg' when doing a kickstart-driven install with the 'liveimg' parameter, which is a fairly niche case - the method is not 'liveimg' on a regular live install (it's 'harddrive'). -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/209

1 5

New: [rhinstaller/anaconda/pulls/215 master] Tests
by dashea 16 Jul '15

16 Jul '15

Maybe this will make jenkins work again -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/215

1 6

New: [rhinstaller/anaconda/pulls/202 master] Don't copy the environment when starting metacity.
by dashea 16 Jul '15

16 Jul '15

This was left in by mistake. The whole point of the env_add parameter to startProgram was to not have to do this. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/202

1 5

New: [rhinstaller/anaconda/pulls/206 master] Fix some chmod issues
by dashea 16 Jul '15

16 Jul '15

Most of our chmod calls were too late. Fixed those and a couple related issues. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/206

1 8

[PATCH] use the right baseurl in run_install_test.sh.
by Chris Lumens 16 Jul '15

16 Jul '15

We're now testing on a secondary architecture, and those don't use the same baseurl as primary ones. Thus, a need to differentiate. --- tests/install/run_install_test.sh | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/tests/install/run_install_test.sh b/tests/install/run_install_test.sh index 782ade6..ed9f286 100755 --- a/tests/install/run_install_test.sh +++ b/tests/install/run_install_test.sh @@ -49,11 +49,22 @@ enabled=1 [anaconda-rawhide] name=Fedora - Rawhide - Developmental packages for the next Fedora release failovermethod=priority -baseurl=http://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/\$basearch/os/ enabled=1 gpgcheck=0 EOF +# Primary and secondary arches do not use the same baseurl, so we have to figure it +# out here. +if [[ "$(uname -m)" == "x86_64" ]]; then + cat <<EOF >> ${tmpdir}/yum.conf +baseurl=http://dl.fedoraproject.org/pub/fedora/linux/development/rawhide/\$basearch/os/ +EOF +else + cat <<EOF >> ${tmpdir}/yum.conf +baseurl=http://mirrors.kernel.org/fedora-secondary/development/rawhide/\$basearch/os/ +EOF +fi + dnf install -y -c ${tmpdir}/yum.conf --installroot=${tmpdir} --releasever=rawhide \ --disablerepo=\* --enablerepo=anaconda --enablerepo=anaconda-rawhide \ anaconda -- 2.4.3

2 1

New: [rhinstaller/anaconda/pulls/212 master] Master f22 upd log
by dashea 16 Jul '15

16 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/212

1 32

New: [rhinstaller/anaconda/pulls/208 master] Fix possible to start installation without network (#1221109)
by dashea 16 Jul '15

16 Jul '15

Payload manager is started from network spoke if network settings change. This will start source spoke and software spoke reach-ability testing. *Resolves: rhbz#1221109* -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/208

1 4

Updated: [rhinstaller/python-meh/pulls/4 master] Use gi.require_version for Gtk import
by dashea 15 Jul '15

15 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/python-meh/pull/4

1 4

Updated: [rhinstaller/anaconda/pulls/203 master] Decode wifi SSIDs into strings. (#1240398)
by dashea 14 Jul '15

14 Jul '15

Use the chardet module to try to detect what encoding the SSID uses. Add a column to the wireless network ListStore in the network spoke to store the original byte sequence (also encoded as a string because GLib is awful at storing byte sequences). -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/203

1 3

[blivet][PATCH] Don't pass model to md fwraid constructor. (#1242610)
by David Lehman 14 Jul '15

14 Jul '15

--- blivet/populator.py | 1 + 1 file changed, 1 insertion(+) diff --git a/blivet/populator.py b/blivet/populator.py index f5d86bf..5ff972b 100644 --- a/blivet/populator.py +++ b/blivet/populator.py @@ -538,6 +538,7 @@ class Populator(object): kwargs["memberDevices"] = udev.device_get_md_devices(info) kwargs["uuid"] = udev.device_get_md_uuid(info) kwargs["exists"] = True + del kwargs["model"] del kwargs["serial"] del kwargs["vendor"] del kwargs["bus"] -- 2.4.3

2 1

[blivet][PATCH] Apply default size for new partition earlier...
by David Lehman 14 Jul '15

14 Jul '15

Otherwise, if no size was passed in, the size will be Size(0) when the format gets set, which is problematic for formats with a minimum size. --- blivet/devices/partition.py | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/blivet/devices/partition.py b/blivet/devices/partition.py index 02acf77..4ea0e97 100644 --- a/blivet/devices/partition.py +++ b/blivet/devices/partition.py @@ -134,6 +134,12 @@ class PartitionDevice(StorageDevice): self._partedPartition = None self._origPath = None + if not exists and size is None: + if start is not None and end is not None: + size = Size(0) + else: + size = self.defaultSize + StorageDevice.__init__(self, name, fmt=fmt, size=size, major=major, minor=minor, exists=exists, sysfsPath=sysfsPath, parents=parents) @@ -168,13 +174,6 @@ class PartitionDevice(StorageDevice): # XXX It might be worthwhile to create a shit-simple # PartitionRequest class and pass one to this constructor # for new partitions. - if not self._size: - if start is not None and end is not None: - self._size = Size(0) - else: - # default size for new partition requests - self._size = self.defaultSize - self.req_name = name self.req_partType = partType self.req_primary = primary -- 2.4.3

3 2

New: [rhinstaller/anaconda/pulls/197 master] Master sphinx 3 docs
by dashea 14 Jul '15

14 Jul '15

Update to use Sphinx for python3, fix a couple little bugs and add a helper script to build the docs in a mock. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/197

1 7

Updated: [rhinstaller/python-meh/pulls/4 master] Use gi.require_version for Gtk import
by dashea 14 Jul '15

14 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/python-meh/pull/4

1 2

New: [rhinstaller/python-meh/pulls/4 master] Use gi.require_version for Gtk import
by dashea 14 Jul '15

14 Jul '15

-- To view this pull request on github, visit https://github.com/rhinstaller/python-meh/pull/4

1 1

New: [rhinstaller/anaconda/pulls/203 master] Decode wifi SSIDs into strings. (#1240398)
by dashea 13 Jul '15

13 Jul '15

Use the chardet module to try to detect what encoding the SSID uses. Add a column to the wireless network ListStore in the network spoke to store the original byte sequence (also encoded as a string because GLib is awful at storing byte sequences). -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/203

1 6

New: [rhinstaller/anaconda/pulls/186 master] Add a bunch of gi.require_version calls
by dashea 13 Jul '15

13 Jul '15

pygobject differentiates between different versions of introspectable libraries in about the dumbest way possible, and now it complains if we don't play along. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/186

1 7

New: [rhinstaller/anaconda/pulls/198 master] Require new dracut-live package for anaconda-dracut
by dashea 13 Jul '15

13 Jul '15

The dmsquash module is moving into a new subpackage. (note that this will be held until new dracut is available) -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/198

1 4

New: [rhinstaller/anaconda/pulls/200 rhel7-branch] Restore RHEL-specific stylesheet data.
by dashea 13 Jul '15

13 Jul '15

Related: rhbz#1196721 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/200

1 3

[PATCH] Some dracut modules anaconda needs have been split into their own package.
by Chris Lumens 13 Jul '15

13 Jul '15

--- anaconda.spec.in | 1 + 1 file changed, 1 insertion(+) diff --git a/anaconda.spec.in b/anaconda.spec.in index 4d7d460..93c0052 100644 --- a/anaconda.spec.in +++ b/anaconda.spec.in @@ -212,6 +212,7 @@ documentation for working with this library. Summary: The anaconda dracut module Requires: dracut >= %{dracutver} Requires: dracut-network +Requires: dracut-live Requires: xz Requires: python3-kickstart -- 2.4.3

2 1

[PATCH rhel7-branch] Fix pylint errors in the new driver disk code.
by Chris Lumens 13 Jul '15

13 Jul '15

Related: rhbz#1084197 --- dracut/driver_updates.py | 2 +- tests/dracut_tests/test_driver_updates.py | 9 ++++----- tests/testenv.sh | 4 ++-- 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/dracut/driver_updates.py b/dracut/driver_updates.py index 0bf9648..79410dd 100755 --- a/dracut/driver_updates.py +++ b/dracut/driver_updates.py @@ -75,7 +75,7 @@ from logging.handlers import SysLogHandler # py2 compat try: - from subprocess import DEVNULL + from subprocess import DEVNULL # pylint: disable=no-name-in-module except ImportError: DEVNULL = open("/dev/null", 'a+') try: diff --git a/tests/dracut_tests/test_driver_updates.py b/tests/dracut_tests/test_driver_updates.py index 9b87c73..0e47c76 100644 --- a/tests/dracut_tests/test_driver_updates.py +++ b/tests/dracut_tests/test_driver_updates.py @@ -2,7 +2,7 @@ import unittest try: - import unittest.mock as mock + import unittest.mock as mock # pylint: disable=import-error,no-name-in-module except ImportError: import mock @@ -231,7 +231,7 @@ class TestSaveRepo(FileTestCaseBase): def test_basic(self): """save_repo: copies a directory to /run/install/DD-X""" makerepo(self.srcdir) - [repo] = find_repos(self.srcdir) + repo = find_repos(self.srcdir)[0] makefile(repo+'/fake-something.rpm') saved = save_repo(repo, target=self.destdir) self.assertEqual(set(os.listdir(saved)), set(["fake-something.rpm"])) @@ -547,7 +547,7 @@ TYPE=ext4 ''' disk_labels = { '/dev/sdb1': 'metroid_srv', - '/dev/loop0': 'I\\x20\u262d\\x20COMMUNISM', + '/dev/loop0': u'I\\x20\u262d\\x20COMMUNISM', '/dev/sda3': 'metroid_root' } devicelist = [ @@ -558,7 +558,7 @@ devicelist = [ DeviceInfo(DEVNAME='/dev/sda3', TYPE='btrfs', LABEL='metroid_root', UUID='4126dbb6-c7d3-47b4-b1fc-9bb461df0067'), DeviceInfo(DEVNAME='/dev/loop0', TYPE='ext4', - LABEL='I\\x20\u262d\\x20COMMUNISM', + LABEL=u'I\\x20\u262d\\x20COMMUNISM', UUID='6f16967e-0388-4276-bd8d-b88e5b217a55'), ] # also covers blkid, get_disk_labels, DeviceInfo @@ -584,7 +584,6 @@ class DeviceInfoTestCase(unittest.TestCase): # TODO: test TextMenu itself # py2/3 compat -import sys if sys.version_info.major == 3: from io import StringIO else: diff --git a/tests/testenv.sh b/tests/testenv.sh index 017559d..198b870 100644 --- a/tests/testenv.sh +++ b/tests/testenv.sh @@ -9,9 +9,9 @@ fi : "${top_builddir:=$top_srcdir}" if [ -z "$PYTHONPATH" ]; then - PYTHONPATH="${top_builddir}/pyanaconda/isys/.libs:${top_srcdir}/pyanaconda:${top_srcdir}:${top_srcdir}/tests/lib" + PYTHONPATH="${top_builddir}/pyanaconda/isys/.libs:${top_srcdir}/pyanaconda:${top_srcdir}:${top_srcdir}/tests/lib:${top_srcdir}/dracut" else - PYTHONPATH="${PYTHONPATH}:${top_builddir}/pyanaconda/isys/.libs:${top_srcdir}/pyanaconda:${top_srcdir}:${top_srcdir}/tests/lib" + PYTHONPATH="${PYTHONPATH}:${top_builddir}/pyanaconda/isys/.libs:${top_srcdir}/pyanaconda:${top_srcdir}:${top_srcdir}/tests/lib:${top_srcdir}/dracut" fi if [ -z "$LD_LIBRARY_PATH" ]; then -- 2.4.3

2 1

New: [rhinstaller/anaconda/pulls/193 master] Kickstart tests related to SELinux.
by dashea 13 Jul '15

13 Jul '15

Includes --permissive, --enforcing and --disabled switches. Signed-off-by: Karel Valek <kvalek(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/193

1 5

Updated: [rhinstaller/anaconda/pulls/184 master] User operation kickstart tests.
by dashea 13 Jul '15

13 Jul '15

Kickstart scripts for adding specified user during installation as well as check-up if the user was successfully added to the system, including password, /home/<user> directory and specified group. Signed-off-by: Karel Valek <kvalek(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/184

1 9

[PATCH][blivet][rhel7.1-branch] Improve format handling for lvm snapshots.
by Vojtěch Trefný 13 Jul '15

13 Jul '15

Non-existent lvm snapshots have a copy of the origin's format as their format. When an origin's format changes, all non-existent snapshots of that origin must have their formats updated as well. Related: rhbz#1236988 (cherry picked from commit 1c2d8a0b3633145b0528c4a0734e4ac7a7bffed8) Signed-off-by: Vojtech Trefny <vtrefny(a)redhat.com> --- blivet/devices.py | 47 ++++++++++++++++++++++++++++++++++++----------- 1 file changed, 36 insertions(+), 11 deletions(-) diff --git a/blivet/devices.py b/blivet/devices.py index c576a19..b389e31 100644 --- a/blivet/devices.py +++ b/blivet/devices.py @@ -3027,6 +3027,10 @@ class LVMLogicalVolumeDevice(DMDevice): raise ValueError("constructor requires a LVMVolumeGroupDevice instance") elif not isinstance(parents, LVMVolumeGroupDevice): raise ValueError("constructor requires a LVMVolumeGroupDevice instance") + + # When this device's format is set in the superclass constructor it will + # try to access self.snapshots. + self.snapshots = [] DMDevice.__init__(self, name, size=size, fmt=fmt, sysfsPath=sysfsPath, parents=parents, exists=exists) @@ -3036,7 +3040,6 @@ class LVMLogicalVolumeDevice(DMDevice): self.logSize = logSize self.metaDataSize = 0 self.segType = segType or "linear" - self.snapshots = [] self.req_grow = None self.req_max_size = Size(0) @@ -3107,6 +3110,11 @@ class LVMLogicalVolumeDevice(DMDevice): return (self.vg.align(self.size, roundup=True) * self.copies + self.logSize + self.metaDataSize) + def _setFormat(self, fmt): + super(LVMLogicalVolumeDevice, self)._setFormat(fmt) + for snapshot in (s for s in self.snapshots if not s.exists): + snapshot._updateFormatFromOrigin() + @property def vg(self): """ This Logical Volume's Volume Group. """ @@ -3337,8 +3345,8 @@ class LVMSnapShotBase(object): Normal/old snapshots must be removed with their origin, while thin snapshots can remain after their origin is removed. - It is also impossible to set the format for a snapshot explicitly as it - always has the same format as its origin. + It is also impossible to set the format for a non-existent snapshot + explicitly as it always has the same format as its origin. """ __metaclass__ = abc.ABCMeta @@ -3383,15 +3391,32 @@ class LVMSnapShotBase(object): if vorigin and not exists: raise ValueError("only existing vorigin snapshots are supported") - def _setFormat(self, fmt): - pass + def _updateFormatFromOrigin(self): + """ Update the snapshot's format to reflect the origin's. + .. note:: + This should only be called for non-existent snapshot devices. + Once a snapshot exists its format is distinct from that of its + origin. - def _getFormat(self): - if self.origin is None: - fmt = getFormat(None) + """ + fmt = copy.deepcopy(self.origin.format) + fmt.exists = False + if hasattr(fmt, "mountpoint"): + fmt.mountpoint = "" + fmt._chrootedMountpoint = None + fmt.device = self.path # pylint: disable=no-member + + super(LVMSnapShotBase, self)._setFormat(fmt) + + def _setFormat(self, fmt): + # If a snapshot exists it can have a format that is distinct from its + # origin's. If it does not exist its format must be a copy of its + # origin's. + if self.exists: # pylint: disable=no-member + super(LVMSnapShotBase, self)._setFormat(fmt) else: - fmt = self.origin.format - return fmt + log.info("copying %s origin's format", self.name) # pylint: disable=no-member + self._updateFormatFromOrigin() @abc.abstractmethod def _create(self): @@ -3736,7 +3761,7 @@ class LVMThinSnapShotDevice(LVMSnapShotBase, LVMThinLogicalVolumeDevice): LVMSnapShotBase.__init__(self, origin=origin, exists=exists) LVMThinLogicalVolumeDevice.__init__(self, name, parents=parents, - sysfsPath=sysfsPath,fmt=None, + sysfsPath=sysfsPath,fmt=fmt, segType=segType, uuid=uuid, size=size, exists=exists) -- 2.4.3

2 1

Updated: [rhinstaller/anaconda/pulls/185 master] Kickstart tests for UTC and LOCAL hwclock.
by dashea 13 Jul '15

13 Jul '15

Signed-off-by: Karel Valek <kvalek(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/185

1 8

New: [rhinstaller/anaconda/pulls/192 master] Kickstart firewall tests.
by dashea 13 Jul '15

13 Jul '15

Kickstart firewall test script for custom ports and service enabling. Signed-off-by: Karel Valek <kvalek(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/192

1 6

New: [rhinstaller/anaconda/pulls/199 master] Kickstart service test: enable / disable.
by dashea 13 Jul '15

13 Jul '15

Tested services: sshd (disable), systemd-timesyncd (enable), systemd-networkd (disabled in config, test). Signed-off-by: Karel Valek <kvalek(a)redhat.com> -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/199

1 1

New: [rhinstaller/anaconda/pulls/191 master] Fix Repository New_Repository has no mirror or baseurl (#1215963)
by dashea 13 Jul '15

13 Jul '15

Source spoke is set to error state instead of crash with empty repository. *Resolves: rhbz#1215963* It's base change from this PR https://github.com/rhinstaller/anaconda/pull/128. I want to make better warnings and I have something already done but the source spoke have so many bugs now that I decide to do this pull request which only fix crash with empty repository. In future I will create special patch set with reworked Source spoke. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/191

1 5

Updated: [rhinstaller/anaconda/pulls/190 rhel7-branch] rhel7 backports
by dashea 10 Jul '15

10 Jul '15

This is the commits from #181 and #182, backported for rhel7. The differences are minor but _just barely_ enough to make me want another quick review. The differences from the above commits are: - 231ac70: also reverts a66cb15 - 99c97dd: dnfpayload vs. yumpayload; the fix is the same, it's just in a different file. - d844db8: resolve some parse-kickstart conflicts - `commands.network.RHEL7_Network` vs. `commands.network.F22_Network`, etc. - faf2432: resolve conflict in dracut/module-setup.sh: RHEL7 doesn't have `PYTHONHASHSEED=42` - 679448a: RHEL7 handles chronyd and ntpd; rather than checking to see if the files exist, just try to modify them - the worst that can happen (AFAICT) is a warning in the log. NBD. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/190

1 2

New: [rhinstaller/anaconda/pulls/196 master] Ignore this commit.
by dashea 10 Jul '15

10 Jul '15

This is only a test. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/196

1 3

New: [rhinstaller/anaconda/pulls/195 rhel7-branch] Start the network before the display (#1240732)
by dashea 10 Jul '15

10 Jul '15

Sometimes the display is on the network. If there is a kickstart file containing a static network configuration, and dracut started the network using dhcp (for example, vnc was on the command line but no ip arguments were), it's possible to change addresses after VNC has started, which doesn't work real well. (cherry picked from commit cf50dc459ac756feee59c5bd7d5339ca8d932006) Resolves: rhbz#1240732 -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/195

1 5

New: [rhinstaller/anaconda/pulls/187 master] Catch blivet formatDevice ValueError in custom (#1240226)
by dashea 10 Jul '15

10 Jul '15

Trying to format when formatting isn't possible, eg. NTFS as /, raises ValueError so catch that and pass it on to the user. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/187

1 4

New: [rhinstaller/blivet/pulls/59 master] Implement the __dir__ method of the LazyImportObject class
by dashea 10 Jul '15

10 Jul '15

This makes the 'TAB-TAB' completion in ipython and dir() calls work as if the lazy-imported object was imported in a normal way. -- To view this pull request on github, visit https://github.com/rhinstaller/blivet/pull/59

1 4

[PATCH] Temporarily disable the error about not importing rpmfluff.
by Chris Lumens 10 Jul '15

10 Jul '15

There's not yet a python3 version of this package, and I don't want it to be the only thing keeping us from having a passing test suite. --- tests/dd_tests/dd_test.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/dd_tests/dd_test.py b/tests/dd_tests/dd_test.py index 60ff6b4..4705559 100644 --- a/tests/dd_tests/dd_test.py +++ b/tests/dd_tests/dd_test.py @@ -12,7 +12,8 @@ import subprocess from contextlib import contextmanager from collections import namedtuple -from rpmfluff import SourceFile, SimpleRpmBuild, expectedArch +# TODO: this pragma is temporary until there's a python3-rpmfluff +from rpmfluff import SourceFile, SimpleRpmBuild, expectedArch # pylint: disable=import-error TOP_SRCDIR = os.environ.get("top_srcdir", "../..") UTILDIR = os.path.join(TOP_SRCDIR, "utils/dd") -- 2.4.3

3 3

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches July 2015