anaconda-patches April 2016

anaconda-patches@lists.fedorahosted.org

9 participants
1157 discussions

Re: [rhinstaller/anaconda/pulls/574 master] Fix only one address is shown in anaconda (#1264400)
by dashea 01 Apr '16

01 Apr '16

> @@ -747,10 +750,36 @@ def add_device_to_list(self, device): > else: > self.add_dev_cfg(DeviceConfiguration(device=device, con=con)) > > - device.connect("notify::ip4-config", self.on_device_config_changed) > - device.connect("notify::ip6-config", self.on_device_config_changed) > + device.connect("notify::ip4-config", self.on_ip_obj_changed, IPV4_CONFIG) > + device.connect("notify::ip6-config", self.on_ip_obj_changed, IPV6_CONFIG) > device.connect("state-changed", self.on_device_state_changed) > > + def on_ip_obj_changed(self, device, *args): > + """Callback when ipX-config objects will be changed. > + > + Register callback on properties (IP address, gateway...) of these ipX-config > + objects when they are created. > + """ > + log.debug("%s object changed", args[1]) I've missed that, thank you. I'll fix it locally. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/574#discussion_r58195001

1 0

Re: [rhinstaller/anaconda/pulls/574 master] Fix only one address is shown in anaconda (#1264400)
by dashea 01 Apr '16

01 Apr '16

Added label: ACK. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/574

1 0

Re: [rhinstaller/anaconda/pulls/574 master] Fix only one address is shown in anaconda (#1264400)
by dashea 01 Apr '16

01 Apr '16

Looks good to me. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/574

1 0

Re: [rhinstaller/anaconda/pulls/574 master] Fix only one address is shown in anaconda (#1264400)
by dashea 01 Apr '16

01 Apr '16

> @@ -747,10 +750,36 @@ def add_device_to_list(self, device): > else: > self.add_dev_cfg(DeviceConfiguration(device=device, con=con)) > > - device.connect("notify::ip4-config", self.on_device_config_changed) > - device.connect("notify::ip6-config", self.on_device_config_changed) > + device.connect("notify::ip4-config", self.on_ip_obj_changed, IPV4_CONFIG) > + device.connect("notify::ip6-config", self.on_ip_obj_changed, IPV6_CONFIG) > device.connect("state-changed", self.on_device_state_changed) > > + def on_ip_obj_changed(self, device, *args): > + """Callback when ipX-config objects will be changed. > + > + Register callback on properties (IP address, gateway...) of these ipX-config > + objects when they are created. > + """ > + log.debug("%s object changed", args[1]) anaconda.log is already rather cluttered with networking log messages, to mitigate this a bit I'd add "network:" prefix like in most of messages from network spoke -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/574#discussion_r58194355

1 0

Re: [rhinstaller/anaconda/pulls/568 master] Don't crash if no groups are specified (#1316816)
by dashea 01 Apr '16

01 Apr '16

Added label: ACK. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/568

1 0

Re: [rhinstaller/anaconda/pulls/568 master] Don't crash if no groups are specified (#1316816)
by dashea 01 Apr '16

01 Apr '16

Looks good to me. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/568

1 0

Re: [rhinstaller/anaconda/pulls/573 master] Set CSS names on all of the anaconda classes. (#1322036)
by dashea 01 Apr '16

01 Apr '16

Added label: ACK. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/573

1 0

Re: [rhinstaller/anaconda/pulls/573 master] Set CSS names on all of the anaconda classes. (#1322036)
by dashea 01 Apr '16

01 Apr '16

Looks good to me. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/573

1 0

Re: [rhinstaller/lorax/pulls/111 master] Copying same file shouldn't crash (#1269213)
by dashea 01 Apr '16

01 Apr '16

Added label: ACK. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/111

1 0

Re: [rhinstaller/lorax/pulls/111 master] Copying same file shouldn't crash (#1269213)
by dashea 01 Apr '16

01 Apr '16

Looks good to me. -- To view this pull request on github, visit https://github.com/rhinstaller/lorax/pull/111

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches April 2016