anaconda-patches April 2016

anaconda-patches@lists.fedorahosted.org

9 participants
1157 discussions

Re: [rhinstaller/anaconda/pulls/572 rhel7-branch] Stop kickstart when space check fails (#1320436)
by dashea 01 Apr '16

01 Apr '16

I don't think we want this, or if we really do then we need to have something like this https://github.com/rhinstaller/anaconda/pull/472 . The space check requires always more space than you really need and for some special use cases it's almost impossible to create even good space check. If you want really small installation you can't do it with this patch any way. I always thought this KS behavior is on purpose. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/572

1 0

Re: [rhinstaller/anaconda/pulls/574 master] Fix only one address is shown in anaconda (#1264400)
by dashea 01 Apr '16

01 Apr '16

Updated: Add comments to public functions. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/574

1 0

Updated: [rhinstaller/anaconda/pulls/574 master] Fix only one address is shown in anaconda (#1264400)
by dashea 01 Apr '16

01 Apr '16

Only NMIP[4,6]Config object was connected to signal on change. But when inner objects (Addresses, Nameservers, Gateway) changed it doesn't notify us about this change. Fix by connecting this inner properties too. Resolves: *rhbz#1264400* Reported-by: Marek Hruscak <mhruscak(a)redhat.com> Master/F24 version of https://github.com/rhinstaller/anaconda/pull/556 . On master we need to disconnect signals so more code was required here. (cherry picked from commit b9323749c470ca3ef24bfee82f911a7b85d8f7fe) -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/574

1 0

[master 1/1] Fix only one address is shown in anaconda (#1264400)
by dashea 01 Apr '16

01 Apr '16

From: Jiri Konecny <jkonecny(a)redhat.com> Only NMIP[4,6]Config object was connected to signal on change. But when inner objects (Addresses, Nameservers, Gateway) changed it doesn't notify us about this change. Fix by connecting this inner properties too. Resolves: rhbz#1264400 Reported-by: Marek Hruscak <mhruscak(a)redhat.com> (cherry picked from commit b9323749c470ca3ef24bfee82f911a7b85d8f7fe) --- pyanaconda/ui/gui/spokes/network.py | 49 +++++++++++++++++++++++++++++++++++-- 1 file changed, 47 insertions(+), 2 deletions(-) diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py index 829ef4d..0ef00b6 100644 --- a/pyanaconda/ui/gui/spokes/network.py +++ b/pyanaconda/ui/gui/spokes/network.py @@ -67,6 +67,9 @@ AGENT_MANAGER_IFACE = 'org.freedesktop.NetworkManager.AgentManager' AGENT_MANAGER_PATH = "/org/freedesktop/NetworkManager/AgentManager" +IPV4_CONFIG = "IPv4" +IPV6_CONFIG = "IPv6" + DEVICES_COLUMN_TITLE = 2 DEVICES_COLUMN_OBJECT = 3 @@ -747,10 +750,36 @@ def add_device_to_list(self, device): else: self.add_dev_cfg(DeviceConfiguration(device=device, con=con)) - device.connect("notify::ip4-config", self.on_device_config_changed) - device.connect("notify::ip6-config", self.on_device_config_changed) + device.connect("notify::ip4-config", self.on_ip_obj_changed, IPV4_CONFIG) + device.connect("notify::ip6-config", self.on_ip_obj_changed, IPV6_CONFIG) device.connect("state-changed", self.on_device_state_changed) + def on_ip_obj_changed(self, device, *args): + """Callback when ipX-config objects will be changed. + + Register callback on properties (IP address, gateway...) of these ipX-config + objects when they are created. + """ + log.debug("%s object changed", args[1]) + self.on_device_config_changed(device) + if args[1] == IPV4_CONFIG: + config = device.props.ip4_config + else: + config = device.props.ip6_config + + if config: + # register callback when inner NMIP[4,6]Config object changed + config.connect("notify::addresses", self.on_config_changed, device) + config.connect("notify::gateway", self.on_config_changed, device) + config.connect("notify::nameservers", self.on_config_changed, device) + + def on_config_changed(self, config, *args): + """Callback on property change of ipX-config objects. + + Call method which show changed properties (IP, gateway...) to an user. + """ + self.on_device_config_changed(args[1]) + def _dev_icon_name(self, dev_cfg): icon_name = "" if dev_cfg.get_device_type() in self.wired_ui_device_types: @@ -1172,6 +1201,22 @@ def disconnect_client_callbacks(self): for device in self.client.get_devices(): _try_disconnect(device, self.on_device_config_changed) _try_disconnect(device, self.on_device_state_changed) + _try_disconnect(device, self.on_ip_obj_changed) + for config in self._get_ip_configs(device): + _try_disconnect(config, self.on_config_changed) + + def _get_ip_configs(self, device): + out = [] + try: + out.append(self.props.ip4_config) + except AttributeError: + pass + try: + out.append(self.props.ip6_config) + except AttributeError: + pass + + return out def _try_disconnect(obj, callback): try: -- To view this commit on github, visit https://github.com/rhinstaller/anaconda/commit/41bef5232b472423cecd4f4ba88a…

1 0

Re: [rhinstaller/anaconda/pulls/552 rhel7-branch] Fix bad sensitivity on boxes in source spoke (#1262833)
by dashea 01 Apr '16

01 Apr '16

Added label: ACK. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/552

1 0

Re: [rhinstaller/anaconda/pulls/552 rhel7-branch] Fix bad sensitivity on boxes in source spoke (#1262833)
by dashea 01 Apr '16

01 Apr '16

Looks good to me. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/552

1 0

Re: [rhinstaller/anaconda/pulls/575 master] Reset invalid disk selection before proceeding.
by dashea 31 Mar '16

31 Mar '16

Added label: ACK. -- To view this pull request on github, visit https://github.com/rhinstaller/anaconda/pull/575

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

anaconda-patches April 2016