Re: [pykickstart] [PATCH] Beware of possibly unicode strings (#876293)

[Vratislav Podzimek]

On Wed, 2012-12-05 at 12:46 +0100, Vratislav Podzimek wrote:
> On Tue, 2012-12-04 at 10:47 -0500, Chris Lumens wrote:
> > > __str__ method should return byte string, not unicode string. But
> > > as we don't have a check in every KS_OBJECT.__str__ method, let's at
> > > least add try-except block to prevent UnicodeDecodeError tracebacks.
> >
> > I think this is okay, but this is the kind of change I would very much
> > like to see some test cases for.
>
> Good idea, I'm sending another patch for that. I guess these two could
> be squashed before pushing.

I've improved the test a little bit and it showed me, that the original
patch doesn't cover all common cases. I'll send a new version of the
patch (test included) once I find out how to resolve the issue.