On Tue, Feb 25, 2014 at 01:06:53PM +0100, Jan Stodola wrote:
Samantha, does it mean that anaconda will format all unformatted disks without asking? It looks so from the video and in my opinion this should not happen, anaconda should ask.
All disks, no; just the ones which are selected. Since one could have many disks which are unformatted, and since it is time-consuming to run dasdfmt especially as your number of disks grows, it was decided to not blanket dasdfmt all of them, especially since a user might not wish to use all of them.
Another issue - after the formatting is finished, you are returned to main hub, so you have to enter the Installation destination spoke again - is it necessary to return to main hub? Also note that main hub says "No disks selected", but the "Begin Installation" button is enabled, which also doesn't look right.
Oops, I forgot this screencast had that trailing error. Sorry -- the user is definitely not returned to the main hub after the disks are formatted. The storage spoke is instead refreshed, so yes, the user stays there.
I did not see the button sensitivity for 'Begin Installation' had changed; thanks for pointing that out, I will look into why that happens.
Thanks for working on the "zerombr" kickstart command.
No problem, thanks for reminding me about it. :)
Samantha
Jan
On 02/25/2014 10:30 AM, Samantha N. Bueno wrote:
This includes fixes suggested from the first review. The flow of this is also a bit different from when I first posted as well, thanks to discussions with dlehman and mizmo (read: simpler and less clunky). The text install is basically the same, but for an updated screencast of the graphical version here's a link: http://sbueno.fedorapeople.org/1001070-graphical-25feb.webm
jstodola mentioned the "zerombr" kickstart command last time; support for that is here; if "zerombr" is in a ks file and unformatted DASDs are specified, they automatically have dasdfmt run against them.
A few points that are sort of minor but which bug me, all graphical:
The link on the dialog box back to the summary hub doesn't work, so I sort of force it myself in what's probably a less correct way. I'm not sure what format the URI should be, so if anyone knows, let me know.
Again following a return to the summary hub, while letting dasdfmt run in the background, the UI sort of freezes up; I'm guessing I need some sort of decorator somewhere, maybe?
I think my thread handling is jumbled and awkward in places (GUI storage), then again trying to cleanly work in the "zerombr" command was no picnic. I'd be greatly in favor of only allowing "zerombr" as valid if in text mode; the graphical code is hideous IMO.
anaconda-patches mailing list anaconda-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches