Hi David,
Thanks for the review! :) Comments inline below -
On Mon, Jan 6, 2014 at 1:38 PM, David Shea dshea@redhat.com wrote:
- GdkPixbuf *pixbuf_background =
gdk_pixbuf_new_from_file("/usr/share/anaconda/pixmaps/noise-texture.png", NULL);
Will this logo be part of anaconda or will it come from another package? I'd rather we not hardcode /usr/share/anaconda/pixmaps, but I guess get_widgets_datadir only works right for files in the anaconda source tree.
I think it should come from the fedora-logos or redhat-logos package (depending on what's being installed). At least, that's how it works today, right? I think trademarks have to be in the *-logos packages because of their licensing. Is that okay? I'm not sure how else to reference the images besides that path?
- GdkPixbuf *pixbuf_logo =
gdk_pixbuf_new_from_file("/usr/share/anaconda/pixmaps/redhat-logo.png", NULL);
Same question here, also will it always be redhat-logo.png or will the Fedora version be different. Also also, the two pixbufs are never unreferenced.
Fedora will definitely have a different logo.
And unreferencing - whoops. I'll try to figure out how to do that (if you couldn't already tell, I'm super-rusty and don't normally code in C!! :( )
~m