On Thu, 2013-09-05 at 15:29 -0700, Brian C. Lane wrote:
On Thu, Sep 05, 2013 at 03:32:42PM +0200, Vratislav Podzimek wrote:
This patch adds one more step to LiveCD installations -- generating new initrd after the installation. With the DracutHostOnly feature [1] dracut now includes only one keymap to the initrd image which makes the vconsole.keymap boot option not working. Users need the keymap they used in the installation in the initrd, especially when they use LUKS.
However, to save 3 MB (summed size of all keymaps) in the initrd size, all live installations would generate initrd twice -- when the kernel package is installed and at the end of the installation.
Live doesn't install packages, so it would only be once.
I'm not totally opposed to this, but I wonder if this should be fixed in the livecd tools instead? The kernel included on the iso should not be host-only and we're just rsyncing it over to the target system.
The drawback there is on the first kernel upgrade thing would be a lot different, introducing the possibility (small, but there) of something going wrong so maybe it is better to regenerate sooner.
I think I've just talked myself into acking this. Unless anyone else has concerns?
I found out that it affects both live and DVD installations so re-generating initrd would need to happen always. Also dracut generates an initrd for the currently running kernel, which might be different from the installed one. I've added '--regenerate-all' to the dracut invocation, but that may prolong the action.
I really think we shouldn't be bothering with that at all. But it seems nobody else will do any change, so we need to fix this dracut's bug on our side. We could write out keyboard and language configuration files before the package installation/copying files, but I don't want to play this game of hacks. Some more files like those might appear in the future and it would break again.