Re: [rhel7/blivet] prevent traceback when root device is not defined #rhbz883768

[Brian C. Lane]

On Tue, Feb 12, 2013 at 01:33:27PM -0500, Samantha N. Bueno wrote:
> root defined as None was causing tracebacks when attempts to
> determine root device's properties were run later in sanityCheck
> resolves: rhbz#883768
>
> blivet/__init__.py | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/blivet/__init__.py b/blivet/__init__.py
> index 9dc7f23..f7f03c2 100644
> --- a/blivet/__init__.py
> +++ b/blivet/__init__.py
> @@ -1412,6 +1412,7 @@ class Blivet(object):
>              errors.append(_("You have not defined a root partition (/),
> "
>                              "which is required for installation of %s "
>                              "to continue.") % (productName,))
>        return (errors, warnings)
>
>    if root and root.size < 250:
>        warnings.append(_("Your root partition is less than 250 "

The goal of sanityCheck is to gather up all the errors and return them
as one block instead of returning after some of them. You could add a
root check right before the checks there are failing and that will keep
it from raising an exception.