On Mon, Oct 07, 2013 at 10:38:50AM +0200, Ales Kozumplik wrote:
It would be nice if we could use the same names where the functionality is the same between the packaging modules.
I perceive your comments to this trivial patch as somewhat bully-ish. Notice also that because of the time gap between us I will not be able to push this at least the following 24 hours. This is not really helping as the process of developing for Anaconda for (now) an outsider is already quite difficult as it is.
Whoa! Slow down there. I in no way meant those comments to be 'bully-ish'. I was simply pointing out some things that I thought might improve understanding the code.
My comment about the dnf package was because I thought it would be good to keep things like that in one place, not spread through different methods in the module. We already have a mechanism for adding packages, why not take advantage of that.
As for naming conventions, I agree that underscores are more correct, and that private variables are private to a module -- but my motivation there was for readers of the code looking at what we currently have, not that either one of them is wrong. Anaconda has lots of inconsistent code, as you know. dnf is new, yum is the existing working module. When I'm looking at the two and both are doing similar things it is easier to figure out what's going on when things are named the same.