On Mon, 2014-06-30 at 15:41 -0400, David Shea wrote:
This class is an abstract class containing the shared parts of HubWindow and StandaloneWindow. It provides quit-button and continue-button properties, quit-clicked and continue-clicked signals emitted when the buttons are pressed, and the sidebar sizing and drawing methods.
Glade files using StandaloneWindow do not require any change. Glade files using HubWindow may need to be modified to connect the quit-button or continue-button properties.
On the python side, this removes the need for the register_event_cb proxy for quit and continue events. Connect GraphicalUserInterface directly to the now-shared signals.
po/POTFILES.in | 1 + pyanaconda/ui/gui/__init__.py | 17 +- pyanaconda/ui/gui/hubs/__init__.py | 27 +-- pyanaconda/ui/gui/hubs/progress.glade | 5 +- pyanaconda/ui/gui/hubs/progress.py | 11 +- pyanaconda/ui/gui/hubs/summary.glade | 6 +- pyanaconda/ui/gui/hubs/summary.py | 7 - pyanaconda/ui/gui/spokes/__init__.py | 12 +- pyanaconda/ui/gui/spokes/network.py | 4 +- pyanaconda/ui/gui/spokes/welcome.py | 4 +- pyanaconda/ui/gui/tools/run-spoke.py | 7 +- widgets/doc/AnacondaWidgets-docs.xml | 1 + widgets/glade/AnacondaWidgets.xml | 10 + widgets/src/BaseStandalone.c | 377 ++++++++++++++++++++++++++++++++++ widgets/src/BaseStandalone.h | 81 ++++++++ widgets/src/HubWindow.c | 83 +------- widgets/src/HubWindow.h | 6 +- widgets/src/Makefile.am | 2 + widgets/src/StandaloneWindow.c | 221 +++++--------------- widgets/src/StandaloneWindow.h | 15 +- 20 files changed, 569 insertions(+), 328 deletions(-) create mode 100644 widgets/src/BaseStandalone.c create mode 100644 widgets/src/BaseStandalone.h
...
+static int get_sidebar_width(GtkWidget *window) {
- GtkAllocation allocation;
- /* change value below to make sidebar bigger / smaller */
- float sidebar_width_percentage = STANDALONE_SIDEBAR_WIDTH_PCT;
Any reason for this assignment and the sidebar_width_percentage variable?