Re: [PATCH 2/2] Add language support spoke

[Chris Lumens]

> pyanaconda/ui/gui/spokes/langsupport.glade | 201 +++++++++++++++++++++++++++++
>  pyanaconda/ui/gui/spokes/langsupport.py    | 195 ++++++++++++++++++++++++++++
>  2 files changed, 396 insertions(+)
>  create mode 100644 pyanaconda/ui/gui/spokes/langsupport.glade
>  create mode 100644 pyanaconda/ui/gui/spokes/langsupport.py

Remember to add your new files to po/POTFILES.in or they won't get
translated.
>                <child>
>                  <object class="GtkEntry" id="langsupportEntry">
>                    <property name="visible">True</property>
>                    <property name="can_focus">True</property>
>                    <property name="valign">start</property>
>                    <property name="margin_top">6</property>
>                    <property name="hexpand">True</property>
>                    <property name="invisible_char">???</property>
>                    <property name="invisible_char_set">True</property>
>                    <property name="secondary_icon_name">edit-clear-symbolic</property>
>                    <signal name="changed" handler="on_entry_changed" swapped="no"/>
>                    <signal name="icon-release" handler="on_clear_icon_clicked" swapped="no"/>
>                  </object>

One thing we started doing on these kinds of widgets on the UI throwdown
day last week was add secondary text to indicate this is a search box.
Check out 9b632169e5b83d57d627d39f94f4315abbb9aabf for an example.  I
think we should do the same thing here, too.
> def apply(self):
>    self.data.lang.addsupport = [row[COL_LANG_SETTING]
>                                 for row in self._langsupportStore
>                                 if row[COL_SELECTED] and row[COL_IS_ADDITIONAL]]

I was kind of imagining that this would work by adding *-support
packages to the list of packages to be installed.  I suppose at this
point we don't necessarily have packaging set up, though, do we?
Passsing through kickstart elsewhere like this is probably for the best,
though.

You may not remember this, but a long time ago we even had a langsupport
kickstart command.  I wonder if it'd be better to bring that back than
to add additional options to existing commands.  Which way is more
confusing?
> @property
> def status(self):
>    # TODO: translate
>    infos = set(self._find_localeinfos_for_code(self.data.lang.lang, self.locale_infos_for_data)[:1])
>    for code in self.data.lang.addsupport:
>        infos.update(self._find_localeinfos_for_code(code, self.locale_infos_for_data))
>    return ", ".join(info.english_name for info in infos)

What happens if I select a lot of languages to add?

- Chris