Re: [PATCH 3/3] Don't pass md array UUID as member format UUID.

[Anne Mulhern]

----- Original Message -----
> From: "David Lehman" 
> To: [e-mail]
> Sent: Friday, August 1, 2014 12:16:04 AM
> Subject: [PATCH 3/3] Don't pass md array UUID as member format UUID.
> Related: rhbz#1070095
>
> blivet/devicetree.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blivet/devicetree.py b/blivet/devicetree.py
> index 73558df..03da94f 100644
> --- a/blivet/devicetree.py
> +++ b/blivet/devicetree.py
> @@ -1806,7 +1806,7 @@ class DeviceTree(object):
>          # attempt to reset the uuid using mdexamine info
>          # will succeed only if metadata version > 0.90
>        kwargs["uuid"] = udev.device_get_md_device_uuid(info) or
>
> kwargs["uuid"]
>        kwargs["uuid"] = udev.device_get_md_device_uuid(info)
>
>        kwargs["biosraid"] = udev.device_is_biosraid_member(info)
>    elif format_type == "LVM2_member":
>
> --
> 1.9.3
>
> anaconda-patches mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches

If it's really true that the value obtained from device_get_uuid()
is certain to be completely irrelevant here, so that we can
override it unconditionally, then device_get_uuid() can probably
be simplified to a 1-liner and maybe a comment added about the
nature of ID_FS_UUID (it's not clear to me what might be expected
to set it.)

Also, the comment should be changed to something like:

reset the device UUID using mdexamine info
UUID is None if metadata version <= 0.90

or something like that.

- mulhern