For example for GSM modems we don't care about control interface (eg ttyUSB0) but about data interface (eg ppp0). --- pyanaconda/nm.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pyanaconda/nm.py b/pyanaconda/nm.py index 40058f3..b6cade6 100644 --- a/pyanaconda/nm.py +++ b/pyanaconda/nm.py @@ -150,7 +150,7 @@ def nm_devices(): device_type = _get_property(device, "DeviceType", ".Device") if device_type not in supported_device_types: continue - iface = _get_property(device, "Interface", ".Device") + iface = _get_property(device, "IpInterface", ".Device") interfaces.append(iface)
return interfaces @@ -174,7 +174,7 @@ def nm_activated_devices(): continue devices = _get_property(ac, "Devices", ".Connection.Active") for device in devices: - iface = _get_property(device, "Interface", ".Device") + iface = _get_property(device, "IpInterface", ".Device") interfaces.append(iface)
return interfaces @@ -498,7 +498,7 @@ def nm_device_slaves(name):
slave_ifaces = [] for slave in slaves: - iface = _get_property(slave, "Interface", ".Device") + iface = _get_property(slave, "IpInterface", ".Device") slave_ifaces.append(iface)
return slave_ifaces
On Mon, 2014-05-26 at 14:35 +0200, Radek Vykydal wrote:
For example for GSM modems we don't care about control interface (eg ttyUSB0) but about data interface (eg ppp0).
pyanaconda/nm.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pyanaconda/nm.py b/pyanaconda/nm.py index 40058f3..b6cade6 100644 --- a/pyanaconda/nm.py +++ b/pyanaconda/nm.py @@ -150,7 +150,7 @@ def nm_devices(): device_type = _get_property(device, "DeviceType", ".Device") if device_type not in supported_device_types: continue
iface = _get_property(device, "Interface", ".Device")
iface = _get_property(device, "IpInterface", ".Device") interfaces.append(iface)return interfaces
@@ -174,7 +174,7 @@ def nm_activated_devices(): continue devices = _get_property(ac, "Devices", ".Connection.Active") for device in devices:
iface = _get_property(device, "Interface", ".Device")
iface = _get_property(device, "IpInterface", ".Device") interfaces.append(iface)return interfaces
@@ -498,7 +498,7 @@ def nm_device_slaves(name):
slave_ifaces = [] for slave in slaves:
iface = _get_property(slave, "Interface", ".Device")
iface = _get_property(slave, "IpInterface", ".Device") slave_ifaces.append(iface)return slave_ifaces
ACK.
On Mon, May 26, 2014 at 05:00:10PM +0200, Vratislav Podzimek wrote:
On Mon, 2014-05-26 at 14:35 +0200, Radek Vykydal wrote:
For example for GSM modems we don't care about control interface (eg ttyUSB0) but about data interface (eg ppp0).
pyanaconda/nm.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pyanaconda/nm.py b/pyanaconda/nm.py index 40058f3..b6cade6 100644 --- a/pyanaconda/nm.py +++ b/pyanaconda/nm.py @@ -150,7 +150,7 @@ def nm_devices(): device_type = _get_property(device, "DeviceType", ".Device") if device_type not in supported_device_types: continue
iface = _get_property(device, "Interface", ".Device")
iface = _get_property(device, "IpInterface", ".Device") interfaces.append(iface)return interfaces
@@ -174,7 +174,7 @@ def nm_activated_devices(): continue devices = _get_property(ac, "Devices", ".Connection.Active") for device in devices:
iface = _get_property(device, "Interface", ".Device")
iface = _get_property(device, "IpInterface", ".Device") interfaces.append(iface)return interfaces
@@ -498,7 +498,7 @@ def nm_device_slaves(name):
slave_ifaces = [] for slave in slaves:
iface = _get_property(slave, "Interface", ".Device")
iface = _get_property(slave, "IpInterface", ".Device") slave_ifaces.append(iface)return slave_ifaces
ACK.
This seems to have something to do with 1101781 and the device name being '', if I revert it I can boot with an updates.img of master.
On 05/28/2014 02:06 AM, Brian C. Lane wrote:
On Mon, May 26, 2014 at 05:00:10PM +0200, Vratislav Podzimek wrote:
On Mon, 2014-05-26 at 14:35 +0200, Radek Vykydal wrote:
For example for GSM modems we don't care about control interface (eg ttyUSB0) but about data interface (eg ppp0).
pyanaconda/nm.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/pyanaconda/nm.py b/pyanaconda/nm.py index 40058f3..b6cade6 100644 --- a/pyanaconda/nm.py +++ b/pyanaconda/nm.py @@ -150,7 +150,7 @@ def nm_devices(): device_type = _get_property(device, "DeviceType", ".Device") if device_type not in supported_device_types: continue
iface = _get_property(device, "Interface", ".Device")
iface = _get_property(device, "IpInterface", ".Device") interfaces.append(iface) return interfaces@@ -174,7 +174,7 @@ def nm_activated_devices(): continue devices = _get_property(ac, "Devices", ".Connection.Active") for device in devices:
iface = _get_property(device, "Interface", ".Device")
iface = _get_property(device, "IpInterface", ".Device") interfaces.append(iface) return interfaces@@ -498,7 +498,7 @@ def nm_device_slaves(name):
slave_ifaces = [] for slave in slaves:
iface = _get_property(slave, "Interface", ".Device")
iface = _get_property(slave, "IpInterface", ".Device") slave_ifaces.append(iface) return slave_ifacesACK.
This seems to have something to do with 1101781 and the device name being '', if I revert it I can boot with an updates.img of master.
Yes, thanks for the catch, I should have used IpInterface only for activated_devices as this property is set only when device is in ACTIVATED state. Sending a patch fixing this.
anaconda-patches@lists.fedorahosted.org