[master][PATCH] Make the keyboard layout preview dialog bigger (#1011140)

[Vratislav Podzimek]

Otherwise it may be hard to read some characters.

Signed-off-by: Vratislav Podzimek 
---
 pyanaconda/ui/gui/spokes/keyboard.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/pyanaconda/ui/gui/spokes/keyboard.py b/pyanaconda/ui/gui/spokes/keyboard.py
index ffab6da..d35eb2f 100644
--- a/pyanaconda/ui/gui/spokes/keyboard.py
+++ b/pyanaconda/ui/gui/spokes/keyboard.py
@@ -501,6 +501,7 @@ class KeyboardSpoke(NormalSpoke):
         dialog = Gkbd.KeyboardDrawing.dialog_new()
         Gkbd.KeyboardDrawing.dialog_set_layout(dialog, self._xkl_wrapper.configreg,
                                                layout_row[0])
+        dialog.set_size_request(750, 350)
         with enlightbox(self.window, dialog):
             dialog.show_all()
             dialog.run()

[Chris Lumens]

> diff --git a/pyanaconda/ui/gui/spokes/keyboard.py b/pyanaconda/ui/gui/spokes/keyboard.py
> index ffab6da..d35eb2f 100644
> --- a/pyanaconda/ui/gui/spokes/keyboard.py
> +++ b/pyanaconda/ui/gui/spokes/keyboard.py
> @@ -501,6 +501,7 @@ class KeyboardSpoke(NormalSpoke):
>          dialog = Gkbd.KeyboardDrawing.dialog_new()
>          Gkbd.KeyboardDrawing.dialog_set_layout(dialog, self._xkl_wrapper.configreg,
>                                                 layout_row[0])
>    dialog.set_size_request(750, 350)
>    with enlightbox(self.window, dialog):
>        dialog.show_all()
>        dialog.run()

Careful - 800 is the minimum horizontal size we are trying to support.
Does this still look okay?

- Chris

[Vratislav Podzimek]

On Tue, 2013-09-24 at 16:14 -0400, Chris Lumens wrote:
> > diff --git a/pyanaconda/ui/gui/spokes/keyboard.py b/pyanaconda/ui/gui/spokes/keyboard.py
> > index ffab6da..d35eb2f 100644
> > --- a/pyanaconda/ui/gui/spokes/keyboard.py
> > +++ b/pyanaconda/ui/gui/spokes/keyboard.py
> > @@ -501,6 +501,7 @@ class KeyboardSpoke(NormalSpoke):
> >          dialog = Gkbd.KeyboardDrawing.dialog_new()
> >          Gkbd.KeyboardDrawing.dialog_set_layout(dialog, self._xkl_wrapper.configreg,
> >                                                 layout_row[0])
> >    dialog.set_size_request(750, 350)
> >    with enlightbox(self.window, dialog):
> >        dialog.show_all()
> >        dialog.run()
>
> Careful - 800 is the minimum horizontal size we are trying to support.
> Does this still look okay?

I know, that's why it is 750. The bigger, the better in this case and
750 still leaves some space around it. [1] I just needed to add a code
that makes it centered.
(dialog.set_position(Gtk.WindowPosition.CENTER_ALWAYS))

[1] http://vpodzime.fedorapeople.org/layout_preview_750.png

[Chris Lumens]

> I know, that's why it is 750. The bigger, the better in this case and
> 750 still leaves some space around it. [1] I just needed to add a code
> that makes it centered.
> (dialog.set_position(Gtk.WindowPosition.CENTER_ALWAYS))
>
> [1] http://vpodzime.fedorapeople.org/layout_preview_750.png

Alright, thanks for the picture.  That looks fine to me.

- Chris