[PATCH] Add additional checks for HFS+ ESP (#1010495)

[Brian C. Lane]

From: "Brian C. Lane"

This checks to make sure any partition we use meets the normal
requirements for stage1 and is < 501.0MB and is not labeled "OSX"
---
 pyanaconda/bootloader.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
index 55a93a2..07b8703 100644
--- a/pyanaconda/bootloader.py
+++ b/pyanaconda/bootloader.py
@@ -1703,6 +1703,14 @@ class MacEFIGRUB(EFIGRUB):
         super(MacEFIGRUB, self).install()
         self.mactel_config()

+    def is_valid_stage1_device(self, device, early=False):
+        valid = super(MacEFIGRUB, self).is_valid_stage1_device(device, early)
+
+        # Make sure we don't pick the OSX root partition
+        if valid and device.size < 501.0 and device.format.label != "OSX":
+            return True
+
+        return False

class YabootBase(BootLoader):
     def write_config_password(self, config):

[David Lehman]

On Fri, 2013-09-27 at 15:24 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane"
>
> This checks to make sure any partition we use meets the normal
> requirements for stage1 and is < 501.0MB and is not labeled "OSX"

I'm a little concerned about the 501MB part. While we do limit autopart
reqs for hfs+ /boot/efi to 200MB we do not limit them at all in custom.
Would bumping this to 5GB or so help avoid a bunch of followup bug
reports?
> pyanaconda/bootloader.py | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
> index 55a93a2..07b8703 100644
> --- a/pyanaconda/bootloader.py
> +++ b/pyanaconda/bootloader.py
> @@ -1703,6 +1703,14 @@ class MacEFIGRUB(EFIGRUB):
>          super(MacEFIGRUB, self).install()
>          self.mactel_config()
> def is_valid_stage1_device(self, device, early=False):
>    valid = super(MacEFIGRUB, self).is_valid_stage1_device(device, early)
>    # Make sure we don't pick the OSX root partition
>    if valid and device.size < 501.0 and device.format.label != "OSX":
>        return True
>    return False
>
> class YabootBase(BootLoader):
>      def write_config_password(self, config):

[Brian C. Lane]

On Mon, Sep 30, 2013 at 09:40:18AM -0500, David Lehman wrote:
> On Fri, 2013-09-27 at 15:24 -0700, Brian C. Lane wrote:
> > From: "Brian C. Lane"
> >
> > This checks to make sure any partition we use meets the normal
> > requirements for stage1 and is < 501.0MB and is not labeled "OSX"
>
> I'm a little concerned about the 501MB part. While we do limit autopart
> reqs for hfs+ /boot/efi to 200MB we do not limit them at all in custom.
> Would bumping this to 5GB or so help avoid a bunch of followup bug
> reports?

mjg59 also has concerns that this is too simple. He'd like to also add a
custom partition name. I made a first pass at that on friday, but it
didn't work so I need to do a bit more on this.