New: [rhinstaller/anaconda/pulls/191 master] Fix Repository New_Repository has no mirror or baseurl (#1215963)
Source spoke is set to error state instead of crash with empty repository.
*Resolves: rhbz#1215963*
It's base change from this PR https://github.com/rhinstaller/anaconda/pull/128. I want to make better warnings and I have something already done but the source spoke have so many bugs now that I decide to do this pull request which only fix crash with empty repository. In future I will create special patch set with reworked Source spoke.
From: Jiri Konecny jkonecny@redhat.com
Source spoke is set to error state instead of crash with empty repository.
Resolves: rhbz#1215963 --- pyanaconda/packaging/dnfpayload.py | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/pyanaconda/packaging/dnfpayload.py b/pyanaconda/packaging/dnfpayload.py index 906c4c7..818eac4 100644 --- a/pyanaconda/packaging/dnfpayload.py +++ b/pyanaconda/packaging/dnfpayload.py @@ -767,6 +767,13 @@ def updateBaseRepo(self, fallback=True, checkmount=True): repo.enable()
for ksrepo in self.data.repo.dataList(): + log.debug("repo %s: mirrorlist %s, baseurl %s", + ksrepo.name, ksrepo.mirrorlist, ksrepo.baseurl) + # one of these must be set to create new repo + if not (ksrepo.mirrorlist or ksrepo.baseurl): + raise packaging.PayloadSetupError("Repository %s has no mirror or baseurl set" + % ksrepo.name) + self._add_repo(ksrepo)
ksnames = [r.name for r in self.data.repo.dataList()]
Added label: master.
Added label: ACK.
Closed.
Pushed
anaconda-patches@lists.fedorahosted.org
-
dashea