[PATCH rhel7-branch] network: detect also fcoe vlan device names exceeding IFNAMESIZ (#1051268)

[Radek Vykydal]

Related: rhbz#1051268
---
 pyanaconda/ui/gui/spokes/network.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
index c7c6ce1..cb0c2d9 100644
--- a/pyanaconda/ui/gui/spokes/network.py
+++ b/pyanaconda/ui/gui/spokes/network.py
@@ -656,7 +656,8 @@ class NetworkControlBox(GObject.GObject):
         if device.get_device_type() not in self.supported_device_types:
             return
         # ignore fcoe vlan devices
-        if device.get_iface().endswith('fcoe'):
+        # (can be chopped off to IFNAMSIZ kernel limit)
+        if device.get_iface().endswith(('-fcoe', '-fco', '-fc', '-f', '-')):
             return

try:

[Vratislav Podzimek]

On Tue, 2014-02-25 at 15:42 +0100, Radek Vykydal wrote:
> Related: rhbz#1051268
>
> pyanaconda/ui/gui/spokes/network.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py
> index c7c6ce1..cb0c2d9 100644
> --- a/pyanaconda/ui/gui/spokes/network.py
> +++ b/pyanaconda/ui/gui/spokes/network.py
> @@ -656,7 +656,8 @@ class NetworkControlBox(GObject.GObject):
>          if device.get_device_type() not in self.supported_device_types:
>              return
>          # ignore fcoe vlan devices
>    if device.get_iface().endswith('fcoe'):
>    # (can be chopped off to IFNAMSIZ kernel limit)
>    if device.get_iface().endswith(('-fcoe', '-fco', '-fc', '-f', '-')):

Crazy, but Radek explained to me that we cannot do anything better here.
So ACK.