[RHEL6] change missing boot partition error (#821336)

[Brian C. Lane]

From: "Brian C. Lane"

X86 is a subclass of EFI, so the error message may apply to non EFI
systems.

Resolves: rhbz#821336
---
 platform.py |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/platform.py b/platform.py
index 3cd9116..31552ab 100644
--- a/platform.py
+++ b/platform.py
@@ -272,8 +272,10 @@ class EFI(Platform):
             NOTE: X86 does not have a separate checkBootRequest method,
                   so this one must work for x86 as well as EFI.
         """
-        if not req:
+        if not req and self.isEfi:
             return [_("You have not created a /boot/efi partition.")]
+        elif not req:
+            return [_("You have not created a bootable partition.")]

errors = Platform.checkBootRequest(self, req)

[Jesse Keating]

On 07/16/2012 11:10 AM, Brian C. Lane wrote:
> From: "Brian C. Lane"
>
> X86 is a subclass of EFI, so the error message may apply to non EFI
> systems.
> Resolves: rhbz#821336
>
> platform.py |    4 +++-
>   1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/platform.py b/platform.py
> index 3cd9116..31552ab 100644
> --- a/platform.py
> +++ b/platform.py
> @@ -272,8 +272,10 @@ class EFI(Platform):
>               NOTE: X86 does not have a separate checkBootRequest method,
>                     so this one must work for x86 as well as EFI.
>           """
>    if not req:
>    if not req and self.isEfi:
>         return [_("You have not created a /boot/efi partition.")]
>    elif not req:
>        return [_("You have not created a bootable partition.")]
>
>     errors = Platform.checkBootRequest(self, req)

ACK

[Vladimir Serbinenko]

On 16.07.2012 20:10, Brian C. Lane wrote:
> From: "Brian C. Lane"
>
> X86 is a subclass of EFI, so the error message may apply to non EFI
> systems.

This would only confuse users since bootable partition may refer to e.g.
primary partitions. If you want to improve this message, use "EFI system
partition" instead.
> Resolves: rhbz#821336
>
> platform.py |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/platform.py b/platform.py
> index 3cd9116..31552ab 100644
> --- a/platform.py
> +++ b/platform.py
> @@ -272,8 +272,10 @@ class EFI(Platform):
>              NOTE: X86 does not have a separate checkBootRequest method,
>                    so this one must work for x86 as well as EFI.
>          """
>    if not req:
>    if not req and self.isEfi:
>        return [_("You have not created a /boot/efi partition.")]
>    elif not req:
>        return [_("You have not created a bootable partition.")]
>
>    errors = Platform.checkBootRequest(self, req)