Updated: [rhinstaller/anaconda/pulls/169 rhel7-branch] Allowed /boot partition on iscsi with ibft (#1164195)
Fix testing of ibft attribute on device.
Fix for the [bug 1164195](https://bugzilla.redhat.com/show_bug.cgi?id=1164195) was pushed already but with an issue. When I used iscsi with ibft I have found that I can't add `/boot` on iscsi drive with `ip=ibft` set.
*Related: rhbz#1164195*
@@ -121,6 +121,11 @@ def _is_on_iscsi(device): return all(isinstance(disk, blivet.devices.iScsiDiskDevice) for disk in device.disks)
+def _is_ibft(device):
- """Tells whether a given device is ibft disk or not."""
Minor thing - I'd name the function _is_on_ibft because, same as in _is_on_iscsi, we are not actually checking if the device (ie /boot partition) is ibft disk but if it is *on* ibft disk(s).
@@ -121,6 +121,11 @@ def _is_on_iscsi(device): return all(isinstance(disk, blivet.devices.iScsiDiskDevice) for disk in device.disks)
+def _is_ibft(device):
- """Tells whether a given device is ibft disk or not."""
True, I'll change it locally.
Looks good to me other than @rvykydal's comment.
Added label: ACK.
I agree with rvykydal and vpodzime. Thanks for catching this.
Closed.
I pushed this to *rhel7-branch* and *master* too. Thank you for the code revision.
anaconda-patches@lists.fedorahosted.org
-
dashea