The alternative is to update LVMLogicalVolumeDevice.updateKSData() so that it records a size for an existing device.
I think I prefer the alternative I've posted, but it is a little hard to tell given how long and puzzling LogVolData.execute() is.
mulhern (1): If using pre-existing, no size needs to be specified in ksdata (#1172172)
pyanaconda/kickstart.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Resolves: fed#1172172
Signed-off-by: mulhern amulhern@redhat.com --- pyanaconda/kickstart.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py index 72d77f3..17844c7 100644 --- a/pyanaconda/kickstart.py +++ b/pyanaconda/kickstart.py @@ -832,7 +832,7 @@ class LogVolData(commands.logvol.F21_LogVolData): else: ty = storage.defaultFSType
- if size is None: + if size is None and not self.preexist: if not self.size: raise KickstartValueError(formatErrorMsg(self.lineno, msg="Size can not be decided on from kickstart nor obtained from device."))
On Fri, 2015-01-02 at 11:56 -0500, mulhern wrote:
Resolves: fed#1172172
Signed-off-by: mulhern amulhern@redhat.com
pyanaconda/kickstart.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pyanaconda/kickstart.py b/pyanaconda/kickstart.py index 72d77f3..17844c7 100644 --- a/pyanaconda/kickstart.py +++ b/pyanaconda/kickstart.py @@ -832,7 +832,7 @@ class LogVolData(commands.logvol.F21_LogVolData): else: ty = storage.defaultFSType
if size is None:
if size is None and not self.preexist: if not self.size: raise KickstartValueError(formatErrorMsg(self.lineno, msg="Size can not be decided on from kickstart nor obtained from device."))
ACK.
anaconda-patches@lists.fedorahosted.org