[PATCH] ProgressHub no longer exists in pyanaconda/ui/tui/hubs.

[Chris Lumens]

---
 pyanaconda/ui/tui/__init__.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/pyanaconda/ui/tui/__init__.py b/pyanaconda/ui/tui/__init__.py
index 31bcff5..f97b0fb 100644
--- a/pyanaconda/ui/tui/__init__.py
+++ b/pyanaconda/ui/tui/__init__.py
@@ -27,7 +27,6 @@ from pyanaconda.flags import flags
 from pyanaconda.threads import threadMgr
 import simpleline as tui
 from hubs.summary import SummaryHub
-from hubs.progress import ProgressHub
 from spokes import StandaloneSpoke
 from tuiobject import YesNoDialog, ErrorDialog

@@ -126,7 +125,7 @@ class TextUserInterface(ui.UserInterface):

def _list_hubs(self):
         """returns the list of hubs to use"""
-        return [SummaryHub, ProgressHub]
+        return [SummaryHub]

def _is_standalone(self, spoke):
         """checks if the passed spoke is standalone"""

[Samantha N. Bueno]

Ack.

On Wed, Sep 18, 2013 at 10:26:06AM -0400, Chris Lumens wrote:
> pyanaconda/ui/tui/__init__.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/pyanaconda/ui/tui/__init__.py b/pyanaconda/ui/tui/__init__.py
> index 31bcff5..f97b0fb 100644
> --- a/pyanaconda/ui/tui/__init__.py
> +++ b/pyanaconda/ui/tui/__init__.py
> @@ -27,7 +27,6 @@ from pyanaconda.flags import flags
>  from pyanaconda.threads import threadMgr
>  import simpleline as tui
>  from hubs.summary import SummaryHub
> -from hubs.progress import ProgressHub
>  from spokes import StandaloneSpoke
>  from tuiobject import YesNoDialog, ErrorDialog
>
> @@ -126,7 +125,7 @@ class TextUserInterface(ui.UserInterface):
>  def _list_hubs(self):
>      """returns the list of hubs to use"""
>    return [SummaryHub, ProgressHub]
>    return [SummaryHub]
>
> def _is_standalone(self, spoke):
>        """checks if the passed spoke is standalone"""
>
> -- 
> 1.8.1.2
>
> anaconda-patches mailing list
> [e-mail]
> https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches

[Vratislav Podzimek]

On Wed, 2013-09-18 at 10:26 -0400, Chris Lumens wrote:
> pyanaconda/ui/tui/__init__.py | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/pyanaconda/ui/tui/__init__.py b/pyanaconda/ui/tui/__init__.py
> index 31bcff5..f97b0fb 100644
> --- a/pyanaconda/ui/tui/__init__.py
> +++ b/pyanaconda/ui/tui/__init__.py
> @@ -27,7 +27,6 @@ from pyanaconda.flags import flags
>  from pyanaconda.threads import threadMgr
>  import simpleline as tui
>  from hubs.summary import SummaryHub
> -from hubs.progress import ProgressHub
>  from spokes import StandaloneSpoke
>  from tuiobject import YesNoDialog, ErrorDialog
>
> @@ -126,7 +125,7 @@ class TextUserInterface(ui.UserInterface):
>  def _list_hubs(self):
>      """returns the list of hubs to use"""
>    return [SummaryHub, ProgressHub]
>    return [SummaryHub]
>
> def _is_standalone(self, spoke):
>        """checks if the passed spoke is standalone"""

Thanks for fixing this. I wonder if we could patch makeupdates to
include some stubs in place of removed files to make errors like these
visible when testing.

[Chris Lumens]

> Thanks for fixing this. I wonder if we could patch makeupdates to
> include some stubs in place of removed files to make errors like these
> visible when testing.

Possibly, but I am not optimistic.  A stub would still mean you could
"import blah", but "from blah import crud" would fail, as would
"blah.whatever".  I guess that's some improvement.

- Chris

[David Shea]

On 09/19/2013 11:35 AM, Chris Lumens wrote:
> > Thanks for fixing this. I wonder if we could patch makeupdates to
> > include some stubs in place of removed files to make errors like these
> > visible when testing.
>
> Possibly, but I am not optimistic.  A stub would still mean you could
> "import blah", but "from blah import crud" would fail, as would
> "blah.whatever".  I guess that's some improvement.

Instead of an empty stub it could raise an ImportError

[PATCH] Replace removed python modules with stubs in makeupdates

[Vratislav Podzimek]

If some python module is removed in a patch, running installation with an
updates.img may not reveal the issues with overlooked imports of the remove
module. By using a stub raising an error when the removed module is imported
it's easy to detect such issues.

Signed-off-by: Vratislav Podzimek 
---
 scripts/makeupdates | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/makeupdates b/scripts/makeupdates
index b49cac6..8b0634b 100755
--- a/scripts/makeupdates
+++ b/scripts/makeupdates
@@ -227,6 +227,12 @@ def copyUpdatedFiles(tag, updates, cwd):
         file = fields[1]

if status == "D":
+            if file.startswith('pyanaconda/'):
+                # deleted python module, write out a stub raising ImportError
+                file_path = os.path.join(tmpupdates, file)
+                with open(file_path, "w") as fobj:
+                    fobj.write('raise ImportError("This module no longer exists!")')
+
             continue

if file.endswith('.spec.in') or (file.find('Makefile') != -1) or \

[PATCH] Replace removed python modules with stubs in makeupdates

[Chris Lumens]

> If some python module is removed in a patch, running installation with an
> updates.img may not reveal the issues with overlooked imports of the remove
> module. By using a stub raising an error when the removed module is imported
> it's easy to detect such issues.
>
> Signed-off-by: Vratislav Podzimek

Yes, yes, push this right now!

- Chris