New: [rhinstaller/anaconda/pulls/215 master] Tests

[dashea]

Maybe this will make jenkins work again

[master 1/2] Only import readline if readline is necessary.

[dashea]

From: David Shea

Weird things can happen when attempting to use readline when not
connected to a tty. Sometimes strange escape characters will appear, or
sometimes python will attempt to manipulate settings that do not exist,
or sometimes libedit will crash the party and break all your glassware.
It is all very mysterious and crash-prone.
---
 dracut/driver_updates.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/dracut/driver_updates.py b/dracut/driver_updates.py
index e50eae9..f60480e 100755
--- a/dracut/driver_updates.py
+++ b/dracut/driver_updates.py
@@ -71,7 +71,12 @@
 import os
 import subprocess
 import fnmatch
-import readline # pylint:disable=unused-import
+
+# Import readline so raw_input gets readline features, like history, and
+# backspace working right. Do not import readline if not connected to a tty
+# because it breaks sometimes.
+if os.isatty(0):
+    import readline # pylint:disable=unused-import

from contextlib import contextmanager
 from logging.handlers import SysLogHandler

[master 2/2] Remove rpmfluff from the buildrequires.

[dashea]

From: David Shea

We don't care about the python2 version of rpmfluff anymore, and we
don't generally have test requirements in the spec file anyway.
---
 anaconda.spec.in | 1 -
 1 file changed, 1 deletion(-)

diff --git a/anaconda.spec.in b/anaconda.spec.in
index a2e14b0..aaaeca8 100644
--- a/anaconda.spec.in
+++ b/anaconda.spec.in
@@ -59,7 +59,6 @@ BuildRequires: python3-bugzilla
 %endif
 BuildRequires: python3-devel
 BuildRequires: python3-nose
-BuildRequires: python-rpmfluff
 BuildRequires: systemd
 # rpm and libarchive are needed for driver disk handling
 BuildRequires: rpm-devel >= %{rpmver}

[rhinstaller/anaconda/pulls/215 master] Tests

[dashea]

Added label: ACK.

[rhinstaller/anaconda/pulls/215 master] Tests

[dashea]

This would have passed had I not mis-configured the -PR job, but I've fixed that now.  So, ACK.

[rhinstaller/anaconda/pulls/215 master] Tests

[dashea]

Closed.

[rhinstaller/anaconda/pulls/215 master] Tests

[dashea]

Pushed.