As we are only calling the createrepo utility with the path to the folder containing the RPM files, no changes other than changing the command name when calling createrepo and changing the package name in the spec file should be needed.
Martin Kolman (1): Use createrepo_c in place of createrepo
anaconda.spec.in | 2 +- pyanaconda/packaging/yumpayload.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Createrepo is Python 2 only and uses yum which will never be ported to Python 3. So use createrepo_c which is written in C and thus Python independent and faster.
Signed-off-by: Martin Kolman mkolman@redhat.com --- anaconda.spec.in | 2 +- pyanaconda/packaging/yumpayload.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/anaconda.spec.in b/anaconda.spec.in index 11a51af..0f5d55a 100644 --- a/anaconda.spec.in +++ b/anaconda.spec.in @@ -122,7 +122,7 @@ Requires: openssh %endif Requires: isomd5sum >= %{isomd5sum} Requires: yum-utils >= %{yumutilsver} -Requires: createrepo +Requires: createrepo_c Requires: NetworkManager >= %{nmver} Requires: dhclient Requires: libselinux-python diff --git a/pyanaconda/packaging/yumpayload.py b/pyanaconda/packaging/yumpayload.py index c05d36a..9b75ffd 100644 --- a/pyanaconda/packaging/yumpayload.py +++ b/pyanaconda/packaging/yumpayload.py @@ -1289,7 +1289,7 @@ reposdir=%s if not rpms: continue log.info("Running createrepo on %s", repo) - iutil.execWithRedirect("createrepo", [repo]) + iutil.execWithRedirect("createrepo_c", [repo])
ks_repo = self.data.RepoData(name="DD-%d" % dir_num, baseurl="file://"+repo,
On 06/27/2014 06:59 AM, Martin Kolman wrote:
As we are only calling the createrepo utility with the path to the folder containing the RPM files, no changes other than changing the command name when calling createrepo and changing the package name in the spec file should be needed.
Martin Kolman (1): Use createrepo_c in place of createrepo
anaconda.spec.in | 2 +- pyanaconda/packaging/yumpayload.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
If this is for python3 because yum will not be part of the brave new python3 world, and the only place we use createrepo is in yumpayload, what's the point?
On Fri, 2014-06-27 at 08:49 -0400, David Shea wrote:
On 06/27/2014 06:59 AM, Martin Kolman wrote:
As we are only calling the createrepo utility with the path to the folder containing the RPM files, no changes other than changing the command name when calling createrepo and changing the package name in the spec file should be needed.
Martin Kolman (1): Use createrepo_c in place of createrepo
anaconda.spec.in | 2 +- pyanaconda/packaging/yumpayload.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
If this is for python3 because yum will not be part of the brave new python3 world, and the only place we use createrepo is in yumpayload, what's the point?
Yeah, I also kinda wondered about that. But the code using it is part of the driver disk machinery, so I guess it will just be moved somewhere once yumpayload is nuked. Because how could we even LIVE without driver disk support! ;-)
anaconda-patches mailing list anaconda-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/anaconda-patches
On Fri, 2014-06-27 at 14:59 +0200, Martin Kolman wrote:
On Fri, 2014-06-27 at 08:49 -0400, David Shea wrote:
On 06/27/2014 06:59 AM, Martin Kolman wrote:
As we are only calling the createrepo utility with the path to the folder containing the RPM files, no changes other than changing the command name when calling createrepo and changing the package name in the spec file should be needed.
Martin Kolman (1): Use createrepo_c in place of createrepo
anaconda.spec.in | 2 +- pyanaconda/packaging/yumpayload.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
If this is for python3 because yum will not be part of the brave new python3 world, and the only place we use createrepo is in yumpayload, what's the point?
Yeah, I also kinda wondered about that. But the code using it is part of the driver disk machinery, so I guess it will just be moved somewhere once yumpayload is nuked. Because how could we even LIVE without driver disk support! ;-)
Exactly. Actually, it should be used in the DNFPayload as well, but DNFPayload is "Did Not Finish", you know.
On Fri, Jun 27, 2014 at 06:43:30PM +0200, Vratislav Podzimek wrote:
On Fri, 2014-06-27 at 14:59 +0200, Martin Kolman wrote:
On Fri, 2014-06-27 at 08:49 -0400, David Shea wrote:
On 06/27/2014 06:59 AM, Martin Kolman wrote:
As we are only calling the createrepo utility with the path to the folder containing the RPM files, no changes other than changing the command name when calling createrepo and changing the package name in the spec file should be needed.
Martin Kolman (1): Use createrepo_c in place of createrepo
anaconda.spec.in | 2 +- pyanaconda/packaging/yumpayload.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
If this is for python3 because yum will not be part of the brave new python3 world, and the only place we use createrepo is in yumpayload, what's the point?
Yeah, I also kinda wondered about that. But the code using it is part of the driver disk machinery, so I guess it will just be moved somewhere once yumpayload is nuked. Because how could we even LIVE without driver disk support! ;-)
Exactly. Actually, it should be used in the DNFPayload as well, but DNFPayload is "Did Not Finish", you know.
I should probably move it up into PackagePayload.
On Mon, 2014-06-30 at 16:39 -0700, Brian C. Lane wrote:
On Fri, Jun 27, 2014 at 06:43:30PM +0200, Vratislav Podzimek wrote:
On Fri, 2014-06-27 at 14:59 +0200, Martin Kolman wrote:
On Fri, 2014-06-27 at 08:49 -0400, David Shea wrote:
On 06/27/2014 06:59 AM, Martin Kolman wrote:
As we are only calling the createrepo utility with the path to the folder containing the RPM files, no changes other than changing the command name when calling createrepo and changing the package name in the spec file should be needed.
Martin Kolman (1): Use createrepo_c in place of createrepo
anaconda.spec.in | 2 +- pyanaconda/packaging/yumpayload.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
If this is for python3 because yum will not be part of the brave new python3 world, and the only place we use createrepo is in yumpayload, what's the point?
Yeah, I also kinda wondered about that. But the code using it is part of the driver disk machinery, so I guess it will just be moved somewhere once yumpayload is nuked. Because how could we even LIVE without driver disk support! ;-)
Exactly. Actually, it should be used in the DNFPayload as well, but DNFPayload is "Did Not Finish", you know.
I should probably move it up into PackagePayload.
Sounds good to me.
anaconda-patches@lists.fedorahosted.org
-
Brian C. Lane -
David Shea -
Martin Kolman -
Vratislav Podzimek