custom UI patches

[Chris Lumens]

These couple patches affect widgets being hidden/shown and made sensitive in
the custom part UI.  They could be applied to f18-branch without hurting
anything, if we want.

- Chris

[PATCH 1/2] Hide VG-related widgets when displaying a non-LV mountpoint first (#885131).

[Chris Lumens]

Remember that after the refresh method, a show_all() will be called.  Thus it's
not good enough to call hide.  You must also call set_no_show_all(True) on the
widgets you want to be hidden.
---
 pyanaconda/ui/gui/spokes/custom.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index d819dc9..8a326c8 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -2321,17 +2321,17 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
             if default_vg is None:
                 vg_combo.set_active(len(vg_combo.get_model()) - 1)

-            vg_combo.show()
-            vg_button.show()
-            vg_label.show()
+            for widget in [vg_label, vg_combo, vg_button]:
+                widget.set_no_show_all(False)
+                widget.show()

# make the combo and button insensitive for existing LVs
             can_change_vg = (device is not None and not device.exists)
             vg_combo.set_sensitive(can_change_vg)
         else:
-            vg_label.hide()
-            vg_combo.hide()
-            vg_button.hide()
+            for widget in [vg_label, vg_combo, vg_button]:
+                widget.set_no_show_all(True)
+                widget.hide()

def on_device_type_changed(self, combo):
         if not self._initialized:

[PATCH 2/2] Take device type into account when making the config button sensitive (#885051).

[Chris Lumens]

We were doing this elsewhere, but not when a selector was clicked on.
---
 pyanaconda/ui/gui/spokes/custom.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index 8a326c8..41d089d 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -2157,7 +2157,8 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker):
         selector.set_chosen(True)
         self._current_selector = selector

-        self._configButton.set_sensitive(not selector._device.protected)
+        self._configButton.set_sensitive(not selector._device.protected and
+                                         getDeviceType(selector._device) != DEVICE_TYPE_LVM)
         self._removeButton.set_sensitive(not selector._device.protected)
         return True

[Brian C. Lane]

On Fri, Dec 07, 2012 at 02:17:28PM -0500, Chris Lumens wrote:
> These couple patches affect widgets being hidden/shown and made sensitive in
> the custom part UI.  They could be applied to f18-branch without hurting
> anything, if we want.

Ack.

I'll git am 'em for a build tonight.