New: [rhinstaller/anaconda/pulls/240 rhel7-branch] Fix Initial PPC PReP Boot Selector Name (#1172755)

[dashea]

The auto partition tool added the PPC PReP Boot partition and named it
prepboot in the selector view in the GUI installer. This was due to the
mountpoint being named by the device format type. Changed the mountpoint
namer so that it is named after the device name instead.

Change required adding BIOS Boot as a name in the mountpoint types to
avoid unexpected behavior as a side effect from this change.

Resolves: rhbz#1172755

[rhel7-branch 1/1] Fix Initial PPC PReP Boot Selector Name (#1172755)

[dashea]

From: Robert Marshall

The auto partition tool added the PPC PReP Boot partition and named it
prepboot in the selector view in the GUI installer. This was due to the
mountpoint being named by the device format type. Changed the mountpoint
namer so that it is named after the device name instead.

Change required adding BIOS Boot as a name in the mountpoint types to
avoid unexpected behavior as a side effect from this change.

Resolves: rhbz#1172755
---
 pyanaconda/ui/gui/spokes/custom.py        | 2 +-
 pyanaconda/ui/gui/spokes/lib/accordion.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py
index 1f9d21e..2382190 100644
--- a/pyanaconda/ui/gui/spokes/custom.py
+++ b/pyanaconda/ui/gui/spokes/custom.py
@@ -493,7 +493,7 @@ def _populate_accordion(self):

for device in new_devices:
                 if device in self.bootLoaderDevices:
-                    mounts[device.format.type] = device
+                    mounts[device.format.name] = device

new_root = Root(mounts=mounts, swaps=swaps, name=translated_new_install_name())
             ui_roots.insert(0, new_root)
diff --git a/pyanaconda/ui/gui/spokes/lib/accordion.py b/pyanaconda/ui/gui/spokes/lib/accordion.py
index 844f725..95fa4dd 100644
--- a/pyanaconda/ui/gui/spokes/lib/accordion.py
+++ b/pyanaconda/ui/gui/spokes/lib/accordion.py
@@ -203,7 +203,7 @@ def removeSelector(self, selector):

def _mountpointType(self, mountpoint):
         if not mountpoint or mountpoint in ["/", "/boot", "/boot/efi", "/tmp", "/usr", "/var",
-                                            "biosboot", "prepboot", "swap"]:
+                                            "swap", "PPC PReP Boot", "BIOS Boot"]:
             return SYSTEM_DEVICE
         else:
             return DATA_DEVICE

[rhinstaller/anaconda/pulls/240 rhel7-branch] Fix Initial PPC PReP Boot Selector Name (#1172755)

[dashea]

When pull requests targeted for multiple branches won't be very different you can just set the 'master' and 'rhel7-branch' labels on it instead of creating multiple pull requests.

[rhinstaller/anaconda/pulls/240 rhel7-branch] Fix Initial PPC PReP Boot Selector Name (#1172755)

[dashea]

Added label: rhel7-branch.

[rhinstaller/anaconda/pulls/240 rhel7-branch] Fix Initial PPC PReP Boot Selector Name (#1172755)

[dashea]

Added label: master.

[rhinstaller/anaconda/pulls/240 rhel7-branch] Fix Initial PPC PReP Boot Selector Name (#1172755)

[dashea]

Added label: ACK.

[rhinstaller/anaconda/pulls/240 rhel7-branch] Fix Initial PPC PReP Boot Selector Name (#1172755)

[dashea]

> @@ -203,7 +203,7 @@ def removeSelector(self, selector):
>  def _mountpointType(self, mountpoint):
>      if not mountpoint or mountpoint in ["/", "/boot", "/boot/efi", "/tmp", "/usr", "/var",
>                                        "biosboot", "prepboot", "swap"]:
>                                        "swap", "PPC PReP Boot", "BIOS Boot"]:

Are you sure this works with partitions/devices created by users in custom partitioning? AFAICT we still expect them to type in/choose ``prepboot`` as the mountpoint not ``PPC PReP Boot``.

[rhinstaller/anaconda/pulls/240 rhel7-branch] Fix Initial PPC PReP Boot Selector Name (#1172755)

[dashea]

Closed.