New: [rhinstaller/anaconda/pulls/244 master] Fix crash when adding new device in Welcome spoke (#1245960)
When anaconda is starting then existing interfaces dumping their configurations and after NetworkSpoke is initialized there is registered signal for new devices to handle this. Problem happens in Welcome spoke which is after start but before signals are registered.
*Resolves: rhbz#[1245960](https://bugzilla.redhat.com/show_bug.cgi?id=1245960)*
Added label: master.
From: Jiri Konecny jkonecny@redhat.com
When anaconda is starting then existing interfaces dumping their configurations and after NetworkSpoke is initialized there is registered signal for new devices to handle this. Problem happens in Welcome spoke which is after start but before signals are registered.
Resolves: rhbz#1245960 --- pyanaconda/ui/gui/spokes/network.py | 6 ++++++ 1 file changed, 6 insertions(+)
diff --git a/pyanaconda/ui/gui/spokes/network.py b/pyanaconda/ui/gui/spokes/network.py index 3e0d770..7b98c22 100644 --- a/pyanaconda/ui/gui/spokes/network.py +++ b/pyanaconda/ui/gui/spokes/network.py @@ -459,6 +459,12 @@ def add_connection_to_list(self, uuid): return True
def initialize(self): + # There is signal for newly added devices from NetworkManager but this + # is registered after the initialize method. + # So if someone add new device in Welcome screen ifconf file won't + # be created which causing anaconda to crash. + log.debug("Dump missing interfaces in NetworkControlBox initialize method") + network.dumpMissingDefaultIfcfgs() for device in self.client.get_devices(): self.add_device_to_list(device)
I'm sorry, but I'm missing a connection between the commit message and the changes in the code. Do you really mean the Welcome spoke or do you mean the Network Standalone spoke?
Yeah I really mean Welcome spoke but this seems to be more complicated so I think this fix won't be enough. I'm closing this one and I will try for better description text on the next one.
Closed.
anaconda-patches@lists.fedorahosted.org
-
dashea