New: [rhinstaller/anaconda/pulls/381 master] Limit DNF's parallel downloads to 1 connection when using a proxy
When using a proxy all connections are funneled through a single system, parallel downloads can overwhelm the proxy and don't add any benefit so limit it to 1.
From: "Brian C. Lane" bcl@redhat.com
When using a proxy all connections are funneled through a single system, parallel downloads can overwhelm the proxy and don't add any benefit so limit it to 1. --- pyanaconda/packaging/dnfpayload.py | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/pyanaconda/packaging/dnfpayload.py b/pyanaconda/packaging/dnfpayload.py index db49d66..9c9256c 100644 --- a/pyanaconda/packaging/dnfpayload.py +++ b/pyanaconda/packaging/dnfpayload.py @@ -409,6 +409,9 @@ def _configure(self): if proxy.password: conf.proxy_password = proxy.password log.info("Using %s as proxy", self.data.method.proxy) + + # Prevent parallel downloads from swamping the proxy + conf.max_parallel_downloads = 1 except ProxyStringError as e: log.error("Failed to parse proxy for dnf configure %s: %s", self.data.method.proxy, e)
Added label: ACK.
Looks good to me too.
Removed label: ACK.
The only time this would be an issue would be a manually configured non-transparent proxy.
For those cases, it is most likely not a home user, and would be up to the network administrator to deal with traffic and congestion. I would high recommend against this being the default behavior.
Added label: NACK.
The only time this would be an issue would be a manually configured non-transparent proxy.
Which is why it's set when the user manually configures a non-transparent proxy?
Correct - but we are making the assumption that the proxy has less upload than the client can handle - having a non-transparent proxy is not the standard home-user scenario.
Given a non-transparent proxy already requires some level of advanced knowledge both in proxy and client configuration - an option like this might be better as an additional option in a kickstart or at the CLI placing the power into the network administrator's hands as to whether to throttle the number of client connections or increase the proxy's bandwidth.
Closed.
Yeah, making this non-configurable would end up causing problems. I'll ponder whether or not it should be yet another switch.
anaconda-patches@lists.fedorahosted.org
-
dashea