[PATCH] Use different colors for different message types.

[David Shea]

This is how the GtkInfoBar we have used to work, but at some point the
gnome-themes developers decided that they didn't like that anymore. See
https://bugzilla.gnome.org/show_bug.cgi?id=704266. The white-on-blue bar
is kind of terrible to read, anaconda uses the warning and error colors
to attract attention to warnings and errors, so this style change undoes
the color changes and makes the infobar colors jarring again.
---
 data/anaconda-gtk.css | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/data/anaconda-gtk.css b/data/anaconda-gtk.css
index 92669ba..0bd85ae 100644
--- a/data/anaconda-gtk.css
+++ b/data/anaconda-gtk.css
@@ -1,3 +1,5 @@
+/* Anaconda gtk style overrides */
+
 /* Define styles to apply to the GtkLevelBar widgets for different values.
  *
  * This stylesheet defines properties for "low", "medium" and "high" level bar
@@ -60,3 +62,50 @@
     background-image: none;
     border-color: alpha(#000000, 0.1);
 }
+
+/* As of gnome-themes-standard 3.9.90, the Adwaita theme uses the same color
+ * for all GtkInfoBars regardless of the MessageType.
+ * (https://bugzilla.gnome.org/show_bug.cgi?id=704266, commit 6bfa3aa0). The
+ * colors were actually kind of ok, and also the new colors are borderline
+ * unreadable, so these rules revert that change and set different colors.
+ */
+
+@define-color info_fg_color black;
+@define-color info_bg_color rgb (252, 252, 189);
+@define-color warning_fg_color black;
+@define-color warning_bg_color rgb (250, 173, 61);
+@define-color question_fg_color white;
+@define-color question_bg_color rgb (138, 173, 212);
+@define-color error_fg_color white;
+@define-color error_bg_color rgb (237, 54, 54);
+
+.info {
+    background-color: @info_bg_color;
+    color: @info_fg_color;
+    border-color: darker(@info_bg_color);
+}
+
+.warning {
+    background-color: @warning_bg_color;
+    color: @warning_fg_color;
+    border-color: darker(@warning_bg_color);
+}
+
+.question {
+    background-color: @question_bg_color;
+    color: @question_fg_color;
+    border-color: darker(@question_bg_color);
+}
+
+.error {
+    background-color: @error_bg_color;
+    color: @error_fg_color;
+    border-color: darker(@error_bg_color);
+}
+
+.info,
+.warning,
+.question,
+.error {
+    text-shadow: none;
+}

[Chris Lumens]

> This is how the GtkInfoBar we have used to work, but at some point the
> gnome-themes developers decided that they didn't like that anymore. See
> https://bugzilla.gnome.org/show_bug.cgi?id=704266. The white-on-blue bar
> is kind of terrible to read, anaconda uses the warning and error colors
> to attract attention to warnings and errors, so this style change undoes
> the color changes and makes the infobar colors jarring again.

ACK.

- Chris