Updated: [rhinstaller/anaconda/pulls/412 rhel7-branch] network: Don't set --device link default for hostname only network cm…
…d (#1272274)
network --hostname=blah
used in %pre section could override a device configuration with dhcp which is a regression caused by commit 7473be3d9c5f0c2b434e4c86231b73e72ffe64f9
Resolves: rhbz#1272274
Looks good to me
Added label: ACK.
@@ -1070,6 +1070,19 @@ def execute(self, *args): logger.updateRemote(remote_server)
class Network(commands.network.RHEL7_Network):
- def parse(self, args):
nd = commands.network.RHEL7_Network.parse(self, args)setting_only_hostname = nd.hostname and len(args) <= 2
What are the two args that could be specified here? AFAICT, *network --hostname=blah* has no args.
@@ -1070,6 +1070,19 @@ def execute(self, *args): logger.updateRemote(remote_server)
class Network(commands.network.RHEL7_Network):
- def parse(self, args):
nd = commands.network.RHEL7_Network.parse(self, args)setting_only_hostname = nd.hostname and len(args) <= 2
Args are either ["--hostname=blah'] or ["--hostname", "blah"] for network --hostname blah
@@ -1070,6 +1070,19 @@ def execute(self, *args): logger.updateRemote(remote_server)
class Network(commands.network.RHEL7_Network):
- def parse(self, args):
nd = commands.network.RHEL7_Network.parse(self, args)setting_only_hostname = nd.hostname and len(args) <= 2
Oh, I always thought these are parsed as options and args are only the extra args not related to any option.
Pushed
Closed.
anaconda-patches@lists.fedorahosted.org
-
dashea