This is a relic from when I didn't know how error handling would work in newui. It clearly doesn't do anything anymore, and should just raise an exception that we can handle elsewhere. --- pyanaconda/storage/formats/fs.py | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/pyanaconda/storage/formats/fs.py b/pyanaconda/storage/formats/fs.py index 505e76e..e9c8463 100644 --- a/pyanaconda/storage/formats/fs.py +++ b/pyanaconda/storage/formats/fs.py @@ -505,23 +505,7 @@ class FS(DeviceFormat): {"type": self.type, "device": self.device}
msg = self._fsckErrorMessage(ret) - - # FIXME: Bluh? - if False: - help = _("Errors like this usually mean there is a problem " - "with the filesystem that will require user " - "interaction to repair. Before restarting " - "installation, reboot to rescue mode or another " - "system that allows you to repair the filesystem " - "interactively. Restart installation after you " - "have corrected the problems on the filesystem.") - - intf.messageWindow(_("Unrecoverable Error"), - hdr + "\n\n" + msg + "\n\n" + help, - custom_icon='error') - sys.exit(0) - else: - raise FSError(hdr + msg) + raise FSError(hdr + msg)
def loadModule(self): """Load whatever kernel module is required to support this filesystem."""
On Tue, Dec 18, 2012 at 04:27:33PM -0500, Chris Lumens wrote:
This is a relic from when I didn't know how error handling would work in newui. It clearly doesn't do anything anymore, and should just raise an exception that we can handle elsewhere.
pyanaconda/storage/formats/fs.py | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-)
ACK
anaconda-patches@lists.fedorahosted.org
-
Brian C. Lane -
Chris Lumens