New: [rhinstaller/anaconda/pulls/232 rhel7-branch] Catch NoSuchGroup error (#1245296)

[dashea]

self.environment can be None if you start with no repository setup.
Catch it and show 'Nothing selected'. Also added a catch-all for
environmentDescription() which can raise NoSuchGroup and display
'Selected environment is not valid'.

Resolves: rhbz#1245296

[rhel7-branch 1/1] Catch NoSuchGroup error (#1245296)

[dashea]

From: "Brian C. Lane"

self.environment can be None if you start with no repository setup.
Catch it and show 'Nothing selected'. Also added a catch-all for
environmentDescription() which can raise NoSuchGroup and display
'Selected environment is not valid'.

Resolves: rhbz#1245296
---
 pyanaconda/ui/gui/spokes/software.py | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/pyanaconda/ui/gui/spokes/software.py b/pyanaconda/ui/gui/spokes/software.py
index 25eb596..12894af 100644
--- a/pyanaconda/ui/gui/spokes/software.py
+++ b/pyanaconda/ui/gui/spokes/software.py
@@ -281,15 +281,20 @@ def status(self):
             # we have no packages section in the kickstart
             else:
                 return _("Nothing selected")
+        else:
+            if not self.environment_valid:
+                # selected environment is not valid, this can happen when a valid environment
+                # is selected (by default, manually or from kickstart) and then the installation
+                # source is switched to one where the selected environment is no longer valid
+                return _("Selected environment is not valid")
+            elif not self.environment:
+                return _("Nothing selected")

-        if not flags.automatedInstall and not self.environment_valid:
-            # selected environment is not valid, this can happen when a valid environment
-            # is selected (by default, manually or from kickstart) and then the installation
-            # source is switched to one where the selected environment is no longer valid
+        try:
+            return self.payload.environmentDescription(self.environment)[0]
+        except NoSuchGroup:
             return _("Selected environment is not valid")

-        return self.payload.environmentDescription(self.environment)[0]
-
     def initialize(self):
         NormalSpoke.initialize(self)
         threadMgr.add(AnacondaThread(name=constants.THREAD_SOFTWARE_WATCHER,

[rhinstaller/anaconda/pulls/232 rhel7-branch] Catch NoSuchGroup error (#1245296)

[dashea]

Seems like two separate issues which should go into two patches to me. Or at least the commit message should be made a little more generic. The code changes look good to me though.

[rhinstaller/anaconda/pulls/232 rhel7-branch] Catch NoSuchGroup error (#1245296)

[dashea]

Added label: ACK.

[rhinstaller/anaconda/pulls/232 rhel7-branch] Catch NoSuchGroup error (#1245296)

[dashea]

Changes seems ok for me too.

[rhinstaller/anaconda/pulls/232 rhel7-branch] Catch NoSuchGroup error (#1245296)

[dashea]

pushed with a clearer commit message.

[rhinstaller/anaconda/pulls/232 rhel7-branch] Catch NoSuchGroup error (#1245296)

[dashea]

Closed.