[blivet:rhel7/master] Make error message more informative (#1022497)

[Anne Mulhern]

Resolves: rhbz#1022497

Make the error message indicate the nature of the problem a little better so
that it is less misleading when it pops up in the GUI.

Making the error message indicate the precise problem is actually kind of
tricky, since it would involve changing the return values for
getNextPartitionType() to record this information
and then propagating those values carefully througout
a large chunk of allocatePartitions().

Signed-off-by: mulhern 
---
 blivet/partitioning.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/blivet/partitioning.py b/blivet/partitioning.py
index abaf1b3..33bda27 100644
--- a/blivet/partitioning.py
+++ b/blivet/partitioning.py
@@ -1064,7 +1064,7 @@ def allocatePartitions(storage, disks, partitions, freespace):
                 break

if free is None:
-            raise PartitioningError(_("not enough free space on disks"))
+            raise PartitioningError(_("unable to allocate a large enough partition"))

_disk = use_disk
         disklabel = _disk.format

[Vratislav Podzimek]

On Fri, 2014-01-31 at 09:14 -0500, mulhern wrote:
> Resolves: rhbz#1022497
>
> Make the error message indicate the nature of the problem a little better so
> that it is less misleading when it pops up in the GUI.
>
> Making the error message indicate the precise problem is actually kind of
> tricky, since it would involve changing the return values for
> getNextPartitionType() to record this information
> and then propagating those values carefully througout
> a large chunk of allocatePartitions().
> Signed-off-by: mulhern
>
> blivet/partitioning.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/blivet/partitioning.py b/blivet/partitioning.py
> index abaf1b3..33bda27 100644
> --- a/blivet/partitioning.py
> +++ b/blivet/partitioning.py
> @@ -1064,7 +1064,7 @@ def allocatePartitions(storage, disks, partitions, freespace):
>                  break
>      if free is None:
>        raise PartitioningError(_("not enough free space on disks"))
>        raise PartitioningError(_("unable to allocate a large enough partition"))
>
>    _disk = use_disk
>    disklabel = _disk.format

Looks like a better wording to me. ACK.