We don't want to lock the user into a particular spoke. Resetting the RHS clears out whatever changes were made that produced an error, but the user can still continue if they want the previous settings. --- pyanaconda/ui/gui/spokes/custom.py | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py index 404f844..a2e9e07 100644 --- a/pyanaconda/ui/gui/spokes/custom.py +++ b/pyanaconda/ui/gui/spokes/custom.py @@ -935,6 +935,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker): self._error = mountpoint_validation_msgs[error] self.window.set_info(Gtk.MessageType.WARNING, self._error) self.window.show_all() + self._populate_right_side(selector) return
raid_level = self._get_raid_level() @@ -960,6 +961,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker): if error: self.window.set_info(Gtk.MessageType.WARNING, error) self.window.show_all() + self._populate_right_side(selector) return
with ui_storage_logger():
On Tue, 2012-10-30 at 18:27 -0400, Chris Lumens wrote:
We don't want to lock the user into a particular spoke. Resetting the RHS clears out whatever changes were made that produced an error, but the user can still continue if they want the previous settings.
ACK.
pyanaconda/ui/gui/spokes/custom.py | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/pyanaconda/ui/gui/spokes/custom.py b/pyanaconda/ui/gui/spokes/custom.py index 404f844..a2e9e07 100644 --- a/pyanaconda/ui/gui/spokes/custom.py +++ b/pyanaconda/ui/gui/spokes/custom.py @@ -935,6 +935,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker): self._error = mountpoint_validation_msgs[error] self.window.set_info(Gtk.MessageType.WARNING, self._error) self.window.show_all()
self._populate_right_side(selector) return raid_level = self._get_raid_level()
@@ -960,6 +961,7 @@ class CustomPartitioningSpoke(NormalSpoke, StorageChecker): if error: self.window.set_info(Gtk.MessageType.WARNING, error) self.window.show_all()
self._populate_right_side(selector) return with ui_storage_logger():
anaconda-patches@lists.fedorahosted.org