Architecture specific change in rpms/eclipse-epic.git
by githook-noreply＠fedoraproject.org
The package rpms/eclipse-epic.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/eclipse-epic.git/commit/?id=1af77....
Change:
+ExcludeArch: s390 %{arm} %{ix86}
Thanks.
Full change:
============
commit 1af7739cfd59046229df07b50997b5c9f6588d28
Author: Mat Booth <mat.booth(a)redhat.com>
Date: Mon Mar 18 10:48:55 2019 +0000
Restrict to same architectures as Eclipse itself
diff --git a/eclipse-epic.spec b/eclipse-epic.spec
index 970296a..c894747 100644
--- a/eclipse-epic.spec
+++ b/eclipse-epic.spec
@@ -2,7 +2,7 @@
Name: eclipse-epic
Version: 0.7.5
-Release: 3%{?dist}
+Release: 4%{?dist}
Summary: Perl Eclipse plug-in
License: CPL
URL: http://www.epic-ide.org/
@@ -17,6 +17,9 @@ Patch1: photon-build.patch
BuildArch: noarch
+# Upstream Eclipse no longer supports non-64bit arches
+ExcludeArch: s390 %{arm} %{ix86}
+
BuildRequires: perl-generators
BuildRequires: tycho
BuildRequires: antlr
@@ -111,6 +114,9 @@ popd
%{_datadir}/appdata/eclipse-epic.metainfo.xml
%changelog
+* Mon Mar 18 2019 Mat Booth <mat.booth(a)redhat.com> - 0.7.5-4
+- Restrict to same architectures as Eclipse itself
+
* Thu Jan 31 2019 Fedora Release Engineering <releng(a)fedoraproject.org> - 0.7.5-3
- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
5 years, 3 months
Architecture specific change in rpms/eclipse-epic.git
by githook-noreply＠fedoraproject.org
The package rpms/eclipse-epic.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/eclipse-epic.git/commit/?id=1af77....
Change:
+ExcludeArch: s390 %{arm} %{ix86}
Thanks.
Full change:
============
commit 1af7739cfd59046229df07b50997b5c9f6588d28
Author: Mat Booth <mat.booth(a)redhat.com>
Date: Mon Mar 18 10:48:55 2019 +0000
Restrict to same architectures as Eclipse itself
diff --git a/eclipse-epic.spec b/eclipse-epic.spec
index 970296a..c894747 100644
--- a/eclipse-epic.spec
+++ b/eclipse-epic.spec
@@ -2,7 +2,7 @@
Name: eclipse-epic
Version: 0.7.5
-Release: 3%{?dist}
+Release: 4%{?dist}
Summary: Perl Eclipse plug-in
License: CPL
URL: http://www.epic-ide.org/
@@ -17,6 +17,9 @@ Patch1: photon-build.patch
BuildArch: noarch
+# Upstream Eclipse no longer supports non-64bit arches
+ExcludeArch: s390 %{arm} %{ix86}
+
BuildRequires: perl-generators
BuildRequires: tycho
BuildRequires: antlr
@@ -111,6 +114,9 @@ popd
%{_datadir}/appdata/eclipse-epic.metainfo.xml
%changelog
+* Mon Mar 18 2019 Mat Booth <mat.booth(a)redhat.com> - 0.7.5-4
+- Restrict to same architectures as Eclipse itself
+
* Thu Jan 31 2019 Fedora Release Engineering <releng(a)fedoraproject.org> - 0.7.5-3
- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
5 years, 3 months
Architecture specific change in rpms/eclipse-color-theme.git
by githook-noreply＠fedoraproject.org
The package rpms/eclipse-color-theme.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/eclipse-color-theme.git/commit/?i....
Change:
+ExcludeArch: s390 %{arm} %{ix86}
Thanks.
Full change:
============
commit eb29de298def63e7a6ab2cacde2a66b6bbf85eae
Author: Mat Booth <mat.booth(a)redhat.com>
Date: Mon Mar 18 10:28:21 2019 +0000
Update license tag
Restrict to same architectures as Eclipse itself
diff --git a/eclipse-color-theme.spec b/eclipse-color-theme.spec
index f56d4ce..eade0fb 100644
--- a/eclipse-color-theme.spec
+++ b/eclipse-color-theme.spec
@@ -4,8 +4,8 @@
Summary: An Eclipse plugin which permits color theme switching
Name: eclipse-color-theme
Version: 1.0.0
-Release: 10%{?dist}
-License: EPL
+Release: 11%{?dist}
+License: EPL-1.0
URL: http://www.eclipsecolorthemes.org/
# http://github.com/eclipse-color-theme/eclipse-color-theme/tarball/v%{vers...
Source0: %{name}-%{name}-v%{version}-0-g%{git_tag}.tar.gz
@@ -13,13 +13,15 @@ Source0: %{name}-%{name}-v%{version}-0-g%{git_tag}.tar.gz
# Patch submitted upstream https://github.com/eclipse-color-theme/eclipse-color-theme/pull/218
Patch0: explicit-hamcrest-use.patch
-BuildRequires: eclipse-pde >= 1:3.4.0
+BuildRequires: eclipse-pde
BuildRequires: tycho
-
-Requires: eclipse-platform >= 3.4.0
+Requires: eclipse-platform
BuildArch: noarch
+# Upstream Eclipse no longer supports non-64bit arches
+ExcludeArch: s390 %{arm} %{ix86}
+
%description
The Eclipse Color Theme plugin makes it possible to switch color themes
conveniently and without side effects. It includes the most popular themes
@@ -39,9 +41,14 @@ by exporting it as XML.
%mvn_install
%files -f .mfiles
-%doc README.md CHANGES.md COPYING
+%doc README.md CHANGES.md
+%license COPYING
%changelog
+* Mon Mar 18 2019 Mat Booth <mat.booth(a)redhat.com> - 1.0.0-11
+- Update license tag
+- Restrict to same architectures as Eclipse itself
+
* Thu Jan 31 2019 Fedora Release Engineering <releng(a)fedoraproject.org> - 1.0.0-10
- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
5 years, 3 months
Architecture specific change in rpms/eclipse-color-theme.git
by githook-noreply＠fedoraproject.org
The package rpms/eclipse-color-theme.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/eclipse-color-theme.git/commit/?i....
Change:
+ExcludeArch: s390 %{arm} %{ix86}
Thanks.
Full change:
============
commit eb29de298def63e7a6ab2cacde2a66b6bbf85eae
Author: Mat Booth <mat.booth(a)redhat.com>
Date: Mon Mar 18 10:28:21 2019 +0000
Update license tag
Restrict to same architectures as Eclipse itself
diff --git a/eclipse-color-theme.spec b/eclipse-color-theme.spec
index f56d4ce..eade0fb 100644
--- a/eclipse-color-theme.spec
+++ b/eclipse-color-theme.spec
@@ -4,8 +4,8 @@
Summary: An Eclipse plugin which permits color theme switching
Name: eclipse-color-theme
Version: 1.0.0
-Release: 10%{?dist}
-License: EPL
+Release: 11%{?dist}
+License: EPL-1.0
URL: http://www.eclipsecolorthemes.org/
# http://github.com/eclipse-color-theme/eclipse-color-theme/tarball/v%{vers...
Source0: %{name}-%{name}-v%{version}-0-g%{git_tag}.tar.gz
@@ -13,13 +13,15 @@ Source0: %{name}-%{name}-v%{version}-0-g%{git_tag}.tar.gz
# Patch submitted upstream https://github.com/eclipse-color-theme/eclipse-color-theme/pull/218
Patch0: explicit-hamcrest-use.patch
-BuildRequires: eclipse-pde >= 1:3.4.0
+BuildRequires: eclipse-pde
BuildRequires: tycho
-
-Requires: eclipse-platform >= 3.4.0
+Requires: eclipse-platform
BuildArch: noarch
+# Upstream Eclipse no longer supports non-64bit arches
+ExcludeArch: s390 %{arm} %{ix86}
+
%description
The Eclipse Color Theme plugin makes it possible to switch color themes
conveniently and without side effects. It includes the most popular themes
@@ -39,9 +41,14 @@ by exporting it as XML.
%mvn_install
%files -f .mfiles
-%doc README.md CHANGES.md COPYING
+%doc README.md CHANGES.md
+%license COPYING
%changelog
+* Mon Mar 18 2019 Mat Booth <mat.booth(a)redhat.com> - 1.0.0-11
+- Update license tag
+- Restrict to same architectures as Eclipse itself
+
* Thu Jan 31 2019 Fedora Release Engineering <releng(a)fedoraproject.org> - 1.0.0-10
- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
5 years, 3 months
Architecture specific change in rpms/firefox.git
by githook-noreply＠fedoraproject.org
The package rpms/firefox.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/firefox.git/commit/?id=a99b4bf95a....
Change:
+ExcludeArch: s390x
Thanks.
Full change:
============
commit a99b4bf95a197a3d07d1aca2f8c62a3b709c0dea
Author: Martin Stransky <stransky(a)redhat.com>
Date: Mon Mar 18 11:14:09 2019 +0100
Added fix for mozbz#1468911
diff --git a/firefox.spec b/firefox.spec
index 6ff7864..74bc291 100644
--- a/firefox.spec
+++ b/firefox.spec
@@ -1,10 +1,10 @@
# Set to true if it's going to be submitted as update.
-%global release_build 1
+%global release_build 0
# Disabled arm due to rhbz#1658940
ExcludeArch: armv7hl
# Disabled due to https://pagure.io/fedora-infrastructure/issue/7581
-# ExcludeArch: s390x
+ExcludeArch: s390x
%global system_nss 1
%global system_ffi 1
@@ -95,7 +95,7 @@ ExcludeArch: armv7hl
Summary: Mozilla Firefox Web browser
Name: firefox
Version: 66.0
-Release: 4%{?pre_tag}%{?dist}
+Release: 5%{?pre_tag}%{?dist}
URL: https://www.mozilla.org/firefox/
License: MPLv1.1 or GPLv2+ or LGPLv2+
Source0: https://archive.mozilla.org/pub/firefox/releases/%{version}%{?pre_version...
@@ -156,6 +156,7 @@ Patch575: mozilla-1423598-popup.patch
Patch576: mozilla-1532643-popup.patch
Patch577: mozilla-1535567.patch
Patch578: mozilla-1431399.patch
+Patch579: mozilla-1468911.patch
# PGO/LTO patches
Patch600: pgo.patch
@@ -363,6 +364,7 @@ This package contains results of tests executed during build.
%patch576 -p1 -b .mozilla-1532643-popup
%patch577 -p1 -b .mozilla-1535567
%patch578 -p1 -b .mozilla-1431399
+%patch579 -p1 -b .mozilla-1468911
# PGO patches
%patch600 -p1 -b .pgo
@@ -910,6 +912,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
#---------------------------------------------------------------------
%changelog
+* Mon Mar 18 2019 Martin Stransky <stransky(a)redhat.com> - 66.0-5
+- Added fix for mozbz#1468911
+
* Mon Mar 18 2019 Martin Stransky <stransky(a)redhat.com> - 66.0-4
- Release build
diff --git a/mozilla-1468911.patch b/mozilla-1468911.patch
new file mode 100644
index 0000000..d3177ac
--- /dev/null
+++ b/mozilla-1468911.patch
@@ -0,0 +1,300 @@
+changeset: 465236:be9a6c98a4a7
+tag: tip
+user: Martin Stransky <stransky(a)redhat.com>
+date: Mon Mar 18 10:42:48 2019 +0100
+summary: tearing
+
+diff --git a/widget/gtk/WindowSurfaceWayland.cpp b/widget/gtk/WindowSurfaceWayland.cpp
+--- a/widget/gtk/WindowSurfaceWayland.cpp
++++ b/widget/gtk/WindowSurfaceWayland.cpp
+@@ -15,16 +15,32 @@
+ #include "nsTArray.h"
+ #include "base/message_loop.h" // for MessageLoop
+ #include "base/task.h" // for NewRunnableMethod, etc
+
+ #include <sys/mman.h>
+ #include <fcntl.h>
+ #include <errno.h>
+
++#undef LOG
++#ifdef MOZ_LOGGING
++
++# include "mozilla/Logging.h"
++# include "nsTArray.h"
++# include "Units.h"
++
++extern mozilla::LazyLogModule gWidgetWaylandLog;
++# define LOGWAYLAND(args) MOZ_LOG(gWidgetWaylandLog, mozilla::LogLevel::Debug, args)
++
++#else
++
++# define LOGWAYLAND(args)
++
++#endif /* MOZ_LOGGING */
++
+ namespace mozilla {
+ namespace widget {
+
+ /*
+ Wayland multi-thread rendering scheme
+
+ Every rendering thread (main thread, compositor thread) contains its own
+ nsWaylandDisplay object connected to Wayland compositor (Mutter, Weston, etc.)
+@@ -283,23 +299,30 @@ WindowBackBuffer::WindowBackBuffer(nsWay
+ Create(aWidth, aHeight);
+ }
+
+ WindowBackBuffer::~WindowBackBuffer() { Release(); }
+
+ bool WindowBackBuffer::Resize(int aWidth, int aHeight) {
+ if (aWidth == mWidth && aHeight == mHeight) return true;
+
++ LOGWAYLAND(("WindowBackBuffer::Resize [%p] %d %d\n",
++ (void*)this, aWidth, aHeight));
++
+ Release();
+ Create(aWidth, aHeight);
++ Clear();
+
+ return (mWaylandBuffer != nullptr);
+ }
+
+ void WindowBackBuffer::Attach(wl_surface* aSurface) {
++ LOGWAYLAND(("WindowBackBuffer::Attach [%p] wl_surface %p\n",
++ (void*)this, (void *)aSurface));
++
+ wl_surface_attach(aSurface, mWaylandBuffer, 0, 0);
+ wl_surface_commit(aSurface);
+ wl_display_flush(mWaylandDisplay->GetDisplay());
+ mAttached = true;
+ }
+
+ void WindowBackBuffer::Detach() { mAttached = false; }
+
+@@ -340,17 +363,18 @@ WindowSurfaceWayland::WindowSurfaceWayla
+ mFrameCallback(nullptr),
+ mLastCommittedSurface(nullptr),
+ mDisplayThreadMessageLoop(MessageLoop::current()),
+ mDelayedCommitHandle(nullptr),
+ mDrawToWaylandBufferDirectly(true),
+ mPendingCommit(false),
+ mWaylandBufferFullScreenDamage(false),
+ mIsMainThread(NS_IsMainThread()),
+- mNeedScaleFactorUpdate(true) {
++ mNeedScaleFactorUpdate(true),
++ mNeedFullScreenUpdate(true) {
+ for (int i = 0; i < BACK_BUFFER_NUM; i++) mBackupBuffer[i] = nullptr;
+ }
+
+ WindowSurfaceWayland::~WindowSurfaceWayland() {
+ if (mPendingCommit) {
+ NS_WARNING("Deleted WindowSurfaceWayland with a pending commit!");
+ }
+
+@@ -392,16 +416,17 @@ WindowBackBuffer* WindowSurfaceWayland::
+ }
+
+ if (!mWaylandBuffer->IsAttached()) {
+ if (!mWaylandBuffer->IsMatchingSize(aWidth, aHeight)) {
+ mWaylandBuffer->Resize(aWidth, aHeight);
+ // There's a chance that scale factor has been changed
+ // when buffer size changed
+ mNeedScaleFactorUpdate = true;
++ mNeedFullScreenUpdate = true;
+ }
+ return mWaylandBuffer;
+ }
+
+ MOZ_ASSERT(!mPendingCommit,
+ "Uncommitted buffer switch, screen artifacts ahead.");
+
+ // Front buffer is used by compositor, select a back buffer
+@@ -490,39 +515,36 @@ already_AddRefed<gfx::DrawTarget> Window
+
+ B) Lock() is requested for part(s) of screen. We need to provide temporary
+ surface to draw into and copy result (clipped) to target wl_surface.
+ */
+ already_AddRefed<gfx::DrawTarget> WindowSurfaceWayland::Lock(
+ const LayoutDeviceIntRegion& aRegion) {
+ MOZ_ASSERT(mIsMainThread == NS_IsMainThread());
+
+- LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+- gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
+- gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
++ LOGWAYLAND(("WindowSurfaceWayland::Lock [%p]\n", (void*)this));
+
+ // Are we asked for entire nsWindow to draw?
+- mDrawToWaylandBufferDirectly =
+- (aRegion.GetNumRects() == 1 && bounds.x == 0 && bounds.y == 0 &&
+- lockSize.width == screenRect.width &&
+- lockSize.height == screenRect.height);
+-
++ mDrawToWaylandBufferDirectly = IsFullScreenDraw(aRegion);
+ if (mDrawToWaylandBufferDirectly) {
++ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+ RefPtr<gfx::DrawTarget> dt =
+ LockWaylandBuffer(screenRect.width, screenRect.height,
+ mWindow->WaylandSurfaceNeedsClear());
+ if (dt) {
+ return dt.forget();
+ }
+
+ // We don't have any front buffer available. Try indirect drawing
+ // to mImageSurface which is mirrored to front buffer at commit.
+ mDrawToWaylandBufferDirectly = false;
+ }
+
++ gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
++ gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
+ return LockImageSurface(lockSize);
+ }
+
+ bool WindowSurfaceWayland::CommitImageSurfaceToWaylandBuffer(
+ const LayoutDeviceIntRegion& aRegion) {
+ MOZ_ASSERT(!mDrawToWaylandBufferDirectly);
+
+ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+@@ -611,31 +633,42 @@ void WindowSurfaceWayland::CommitWayland
+ // If our stored wl_surface does not match the actual one it means the frame
+ // callback is no longer active and we should release it.
+ wl_callback_destroy(mFrameCallback);
+ mFrameCallback = nullptr;
+ mLastCommittedSurface = nullptr;
+ }
+
+ if (mWaylandBufferFullScreenDamage) {
++ // We know we can safely redraw whole screen.
+ LayoutDeviceIntRect rect = mWindow->GetBounds();
+ wl_surface_damage(waylandSurface, 0, 0, rect.width, rect.height);
+ mWaylandBufferFullScreenDamage = false;
+ } else {
+ gint scaleFactor = mWindow->GdkScaleFactor();
+ for (auto iter = mWaylandBufferDamage.RectIter(); !iter.Done();
+ iter.Next()) {
+ const mozilla::LayoutDeviceIntRect& r = iter.Get();
+ // We need to remove the scale factor because the wl_surface_damage
+ // also multiplies by current scale factor.
+ wl_surface_damage(waylandSurface, r.x / scaleFactor, r.y / scaleFactor,
+ r.width / scaleFactor, r.height / scaleFactor);
+ }
++
++ // We have to wait untill whole screen is drawn by Gecko, that happens
++ // when window is created or resized.
++ if (mNeedFullScreenUpdate) {
++ if (!IsFullScreenDraw(mWaylandBufferDamage)) {
++ return;
++ }
++ }
+ }
+
++ mNeedFullScreenUpdate = false;
++
+ // Clear all back buffer damage as we're committing
+ // all requested regions.
+ mWaylandBufferDamage.SetEmpty();
+
+ mFrameCallback = wl_surface_frame(waylandSurface);
+ wl_callback_add_listener(mFrameCallback, &frame_listener, this);
+
+ if (mNeedScaleFactorUpdate || mLastCommittedSurface != waylandSurface) {
+@@ -648,16 +681,18 @@ void WindowSurfaceWayland::CommitWayland
+
+ // There's no pending commit, all changes are sent to compositor.
+ mPendingCommit = false;
+ }
+
+ void WindowSurfaceWayland::Commit(const LayoutDeviceIntRegion& aInvalidRegion) {
+ MOZ_ASSERT(mIsMainThread == NS_IsMainThread());
+
++ LOGWAYLAND(("WindowSurfaceWayland::Commit [%p]\n", (void*)this));
++
+ // We have new content at mImageSurface - copy data to mWaylandBuffer first.
+ if (!mDrawToWaylandBufferDirectly) {
+ CommitImageSurfaceToWaylandBuffer(aInvalidRegion);
+ }
+
+ // If we're not at fullscreen damage add drawing area from aInvalidRegion
+ if (!mWaylandBufferFullScreenDamage) {
+ mWaylandBufferDamage.OrWith(aInvalidRegion);
+@@ -690,10 +725,22 @@ void WindowSurfaceWayland::DelayedCommit
+ free(mDelayedCommitHandle);
+ mDelayedCommitHandle = nullptr;
+
+ if (mPendingCommit) {
+ CommitWaylandBuffer();
+ }
+ }
+
++bool WindowSurfaceWayland::IsFullScreenDraw(
++ const LayoutDeviceIntRegion& aRegion) {
++ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
++ gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
++ gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
++
++ // Are we asked to update entire nsWindow?
++ return (bounds.x == 0 && bounds.y == 0 &&
++ lockSize.width == screenRect.width &&
++ lockSize.height == screenRect.height);
++}
++
+ } // namespace widget
+ } // namespace mozilla
+diff --git a/widget/gtk/WindowSurfaceWayland.h b/widget/gtk/WindowSurfaceWayland.h
+--- a/widget/gtk/WindowSurfaceWayland.h
++++ b/widget/gtk/WindowSurfaceWayland.h
+@@ -94,16 +94,17 @@ class WindowSurfaceWayland : public Wind
+
+ private:
+ WindowBackBuffer* GetWaylandBufferToDraw(int aWidth, int aHeight);
+
+ already_AddRefed<gfx::DrawTarget> LockWaylandBuffer(int aWidth, int aHeight,
+ bool aClearBuffer);
+ already_AddRefed<gfx::DrawTarget> LockImageSurface(
+ const gfx::IntSize& aLockSize);
++ bool IsFullScreenDraw(const LayoutDeviceIntRegion& aRegion);
+ bool CommitImageSurfaceToWaylandBuffer(const LayoutDeviceIntRegion& aRegion);
+ void CommitWaylandBuffer();
+
+ // TODO: Do we need to hold a reference to nsWindow object?
+ nsWindow* mWindow;
+ nsWaylandDisplay* mWaylandDisplay;
+ WindowBackBuffer* mWaylandBuffer;
+ LayoutDeviceIntRegion mWaylandBufferDamage;
+@@ -113,14 +114,15 @@ class WindowSurfaceWayland : public Wind
+ wl_surface* mLastCommittedSurface;
+ MessageLoop* mDisplayThreadMessageLoop;
+ WindowSurfaceWayland** mDelayedCommitHandle;
+ bool mDrawToWaylandBufferDirectly;
+ bool mPendingCommit;
+ bool mWaylandBufferFullScreenDamage;
+ bool mIsMainThread;
+ bool mNeedScaleFactorUpdate;
++ bool mNeedFullScreenUpdate;
+ };
+
+ } // namespace widget
+ } // namespace mozilla
+
+ #endif // _MOZILLA_WIDGET_GTK_WINDOW_SURFACE_WAYLAND_H
+diff --git a/widget/gtk/nsAppShell.cpp b/widget/gtk/nsAppShell.cpp
+--- a/widget/gtk/nsAppShell.cpp
++++ b/widget/gtk/nsAppShell.cpp
+@@ -35,16 +35,17 @@ using mozilla::widget::ScreenHelperGTK;
+ using mozilla::widget::ScreenManager;
+
+ #define NOTIFY_TOKEN 0xFA
+
+ LazyLogModule gWidgetLog("Widget");
+ LazyLogModule gWidgetFocusLog("WidgetFocus");
+ LazyLogModule gWidgetDragLog("WidgetDrag");
+ LazyLogModule gWidgetDrawLog("WidgetDraw");
++LazyLogModule gWidgetWaylandLog("WidgetWayland");
+
+ static GPollFunc sPollFunc;
+
+ // Wrapper function to disable hang monitoring while waiting in poll().
+ static gint PollWrapper(GPollFD* ufds, guint nfsd, gint timeout_) {
+ mozilla::BackgroundHangMonitor().NotifyWait();
+ gint result;
+ {
+
5 years, 3 months
Architecture specific change in rpms/firefox.git
by githook-noreply＠fedoraproject.org
The package rpms/firefox.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/firefox.git/commit/?id=a99b4bf95a....
Change:
+ExcludeArch: s390x
Thanks.
Full change:
============
commit a99b4bf95a197a3d07d1aca2f8c62a3b709c0dea
Author: Martin Stransky <stransky(a)redhat.com>
Date: Mon Mar 18 11:14:09 2019 +0100
Added fix for mozbz#1468911
diff --git a/firefox.spec b/firefox.spec
index 6ff7864..74bc291 100644
--- a/firefox.spec
+++ b/firefox.spec
@@ -1,10 +1,10 @@
# Set to true if it's going to be submitted as update.
-%global release_build 1
+%global release_build 0
# Disabled arm due to rhbz#1658940
ExcludeArch: armv7hl
# Disabled due to https://pagure.io/fedora-infrastructure/issue/7581
-# ExcludeArch: s390x
+ExcludeArch: s390x
%global system_nss 1
%global system_ffi 1
@@ -95,7 +95,7 @@ ExcludeArch: armv7hl
Summary: Mozilla Firefox Web browser
Name: firefox
Version: 66.0
-Release: 4%{?pre_tag}%{?dist}
+Release: 5%{?pre_tag}%{?dist}
URL: https://www.mozilla.org/firefox/
License: MPLv1.1 or GPLv2+ or LGPLv2+
Source0: https://archive.mozilla.org/pub/firefox/releases/%{version}%{?pre_version...
@@ -156,6 +156,7 @@ Patch575: mozilla-1423598-popup.patch
Patch576: mozilla-1532643-popup.patch
Patch577: mozilla-1535567.patch
Patch578: mozilla-1431399.patch
+Patch579: mozilla-1468911.patch
# PGO/LTO patches
Patch600: pgo.patch
@@ -363,6 +364,7 @@ This package contains results of tests executed during build.
%patch576 -p1 -b .mozilla-1532643-popup
%patch577 -p1 -b .mozilla-1535567
%patch578 -p1 -b .mozilla-1431399
+%patch579 -p1 -b .mozilla-1468911
# PGO patches
%patch600 -p1 -b .pgo
@@ -910,6 +912,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
#---------------------------------------------------------------------
%changelog
+* Mon Mar 18 2019 Martin Stransky <stransky(a)redhat.com> - 66.0-5
+- Added fix for mozbz#1468911
+
* Mon Mar 18 2019 Martin Stransky <stransky(a)redhat.com> - 66.0-4
- Release build
diff --git a/mozilla-1468911.patch b/mozilla-1468911.patch
new file mode 100644
index 0000000..d3177ac
--- /dev/null
+++ b/mozilla-1468911.patch
@@ -0,0 +1,300 @@
+changeset: 465236:be9a6c98a4a7
+tag: tip
+user: Martin Stransky <stransky(a)redhat.com>
+date: Mon Mar 18 10:42:48 2019 +0100
+summary: tearing
+
+diff --git a/widget/gtk/WindowSurfaceWayland.cpp b/widget/gtk/WindowSurfaceWayland.cpp
+--- a/widget/gtk/WindowSurfaceWayland.cpp
++++ b/widget/gtk/WindowSurfaceWayland.cpp
+@@ -15,16 +15,32 @@
+ #include "nsTArray.h"
+ #include "base/message_loop.h" // for MessageLoop
+ #include "base/task.h" // for NewRunnableMethod, etc
+
+ #include <sys/mman.h>
+ #include <fcntl.h>
+ #include <errno.h>
+
++#undef LOG
++#ifdef MOZ_LOGGING
++
++# include "mozilla/Logging.h"
++# include "nsTArray.h"
++# include "Units.h"
++
++extern mozilla::LazyLogModule gWidgetWaylandLog;
++# define LOGWAYLAND(args) MOZ_LOG(gWidgetWaylandLog, mozilla::LogLevel::Debug, args)
++
++#else
++
++# define LOGWAYLAND(args)
++
++#endif /* MOZ_LOGGING */
++
+ namespace mozilla {
+ namespace widget {
+
+ /*
+ Wayland multi-thread rendering scheme
+
+ Every rendering thread (main thread, compositor thread) contains its own
+ nsWaylandDisplay object connected to Wayland compositor (Mutter, Weston, etc.)
+@@ -283,23 +299,30 @@ WindowBackBuffer::WindowBackBuffer(nsWay
+ Create(aWidth, aHeight);
+ }
+
+ WindowBackBuffer::~WindowBackBuffer() { Release(); }
+
+ bool WindowBackBuffer::Resize(int aWidth, int aHeight) {
+ if (aWidth == mWidth && aHeight == mHeight) return true;
+
++ LOGWAYLAND(("WindowBackBuffer::Resize [%p] %d %d\n",
++ (void*)this, aWidth, aHeight));
++
+ Release();
+ Create(aWidth, aHeight);
++ Clear();
+
+ return (mWaylandBuffer != nullptr);
+ }
+
+ void WindowBackBuffer::Attach(wl_surface* aSurface) {
++ LOGWAYLAND(("WindowBackBuffer::Attach [%p] wl_surface %p\n",
++ (void*)this, (void *)aSurface));
++
+ wl_surface_attach(aSurface, mWaylandBuffer, 0, 0);
+ wl_surface_commit(aSurface);
+ wl_display_flush(mWaylandDisplay->GetDisplay());
+ mAttached = true;
+ }
+
+ void WindowBackBuffer::Detach() { mAttached = false; }
+
+@@ -340,17 +363,18 @@ WindowSurfaceWayland::WindowSurfaceWayla
+ mFrameCallback(nullptr),
+ mLastCommittedSurface(nullptr),
+ mDisplayThreadMessageLoop(MessageLoop::current()),
+ mDelayedCommitHandle(nullptr),
+ mDrawToWaylandBufferDirectly(true),
+ mPendingCommit(false),
+ mWaylandBufferFullScreenDamage(false),
+ mIsMainThread(NS_IsMainThread()),
+- mNeedScaleFactorUpdate(true) {
++ mNeedScaleFactorUpdate(true),
++ mNeedFullScreenUpdate(true) {
+ for (int i = 0; i < BACK_BUFFER_NUM; i++) mBackupBuffer[i] = nullptr;
+ }
+
+ WindowSurfaceWayland::~WindowSurfaceWayland() {
+ if (mPendingCommit) {
+ NS_WARNING("Deleted WindowSurfaceWayland with a pending commit!");
+ }
+
+@@ -392,16 +416,17 @@ WindowBackBuffer* WindowSurfaceWayland::
+ }
+
+ if (!mWaylandBuffer->IsAttached()) {
+ if (!mWaylandBuffer->IsMatchingSize(aWidth, aHeight)) {
+ mWaylandBuffer->Resize(aWidth, aHeight);
+ // There's a chance that scale factor has been changed
+ // when buffer size changed
+ mNeedScaleFactorUpdate = true;
++ mNeedFullScreenUpdate = true;
+ }
+ return mWaylandBuffer;
+ }
+
+ MOZ_ASSERT(!mPendingCommit,
+ "Uncommitted buffer switch, screen artifacts ahead.");
+
+ // Front buffer is used by compositor, select a back buffer
+@@ -490,39 +515,36 @@ already_AddRefed<gfx::DrawTarget> Window
+
+ B) Lock() is requested for part(s) of screen. We need to provide temporary
+ surface to draw into and copy result (clipped) to target wl_surface.
+ */
+ already_AddRefed<gfx::DrawTarget> WindowSurfaceWayland::Lock(
+ const LayoutDeviceIntRegion& aRegion) {
+ MOZ_ASSERT(mIsMainThread == NS_IsMainThread());
+
+- LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+- gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
+- gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
++ LOGWAYLAND(("WindowSurfaceWayland::Lock [%p]\n", (void*)this));
+
+ // Are we asked for entire nsWindow to draw?
+- mDrawToWaylandBufferDirectly =
+- (aRegion.GetNumRects() == 1 && bounds.x == 0 && bounds.y == 0 &&
+- lockSize.width == screenRect.width &&
+- lockSize.height == screenRect.height);
+-
++ mDrawToWaylandBufferDirectly = IsFullScreenDraw(aRegion);
+ if (mDrawToWaylandBufferDirectly) {
++ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+ RefPtr<gfx::DrawTarget> dt =
+ LockWaylandBuffer(screenRect.width, screenRect.height,
+ mWindow->WaylandSurfaceNeedsClear());
+ if (dt) {
+ return dt.forget();
+ }
+
+ // We don't have any front buffer available. Try indirect drawing
+ // to mImageSurface which is mirrored to front buffer at commit.
+ mDrawToWaylandBufferDirectly = false;
+ }
+
++ gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
++ gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
+ return LockImageSurface(lockSize);
+ }
+
+ bool WindowSurfaceWayland::CommitImageSurfaceToWaylandBuffer(
+ const LayoutDeviceIntRegion& aRegion) {
+ MOZ_ASSERT(!mDrawToWaylandBufferDirectly);
+
+ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+@@ -611,31 +633,42 @@ void WindowSurfaceWayland::CommitWayland
+ // If our stored wl_surface does not match the actual one it means the frame
+ // callback is no longer active and we should release it.
+ wl_callback_destroy(mFrameCallback);
+ mFrameCallback = nullptr;
+ mLastCommittedSurface = nullptr;
+ }
+
+ if (mWaylandBufferFullScreenDamage) {
++ // We know we can safely redraw whole screen.
+ LayoutDeviceIntRect rect = mWindow->GetBounds();
+ wl_surface_damage(waylandSurface, 0, 0, rect.width, rect.height);
+ mWaylandBufferFullScreenDamage = false;
+ } else {
+ gint scaleFactor = mWindow->GdkScaleFactor();
+ for (auto iter = mWaylandBufferDamage.RectIter(); !iter.Done();
+ iter.Next()) {
+ const mozilla::LayoutDeviceIntRect& r = iter.Get();
+ // We need to remove the scale factor because the wl_surface_damage
+ // also multiplies by current scale factor.
+ wl_surface_damage(waylandSurface, r.x / scaleFactor, r.y / scaleFactor,
+ r.width / scaleFactor, r.height / scaleFactor);
+ }
++
++ // We have to wait untill whole screen is drawn by Gecko, that happens
++ // when window is created or resized.
++ if (mNeedFullScreenUpdate) {
++ if (!IsFullScreenDraw(mWaylandBufferDamage)) {
++ return;
++ }
++ }
+ }
+
++ mNeedFullScreenUpdate = false;
++
+ // Clear all back buffer damage as we're committing
+ // all requested regions.
+ mWaylandBufferDamage.SetEmpty();
+
+ mFrameCallback = wl_surface_frame(waylandSurface);
+ wl_callback_add_listener(mFrameCallback, &frame_listener, this);
+
+ if (mNeedScaleFactorUpdate || mLastCommittedSurface != waylandSurface) {
+@@ -648,16 +681,18 @@ void WindowSurfaceWayland::CommitWayland
+
+ // There's no pending commit, all changes are sent to compositor.
+ mPendingCommit = false;
+ }
+
+ void WindowSurfaceWayland::Commit(const LayoutDeviceIntRegion& aInvalidRegion) {
+ MOZ_ASSERT(mIsMainThread == NS_IsMainThread());
+
++ LOGWAYLAND(("WindowSurfaceWayland::Commit [%p]\n", (void*)this));
++
+ // We have new content at mImageSurface - copy data to mWaylandBuffer first.
+ if (!mDrawToWaylandBufferDirectly) {
+ CommitImageSurfaceToWaylandBuffer(aInvalidRegion);
+ }
+
+ // If we're not at fullscreen damage add drawing area from aInvalidRegion
+ if (!mWaylandBufferFullScreenDamage) {
+ mWaylandBufferDamage.OrWith(aInvalidRegion);
+@@ -690,10 +725,22 @@ void WindowSurfaceWayland::DelayedCommit
+ free(mDelayedCommitHandle);
+ mDelayedCommitHandle = nullptr;
+
+ if (mPendingCommit) {
+ CommitWaylandBuffer();
+ }
+ }
+
++bool WindowSurfaceWayland::IsFullScreenDraw(
++ const LayoutDeviceIntRegion& aRegion) {
++ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
++ gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
++ gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
++
++ // Are we asked to update entire nsWindow?
++ return (bounds.x == 0 && bounds.y == 0 &&
++ lockSize.width == screenRect.width &&
++ lockSize.height == screenRect.height);
++}
++
+ } // namespace widget
+ } // namespace mozilla
+diff --git a/widget/gtk/WindowSurfaceWayland.h b/widget/gtk/WindowSurfaceWayland.h
+--- a/widget/gtk/WindowSurfaceWayland.h
++++ b/widget/gtk/WindowSurfaceWayland.h
+@@ -94,16 +94,17 @@ class WindowSurfaceWayland : public Wind
+
+ private:
+ WindowBackBuffer* GetWaylandBufferToDraw(int aWidth, int aHeight);
+
+ already_AddRefed<gfx::DrawTarget> LockWaylandBuffer(int aWidth, int aHeight,
+ bool aClearBuffer);
+ already_AddRefed<gfx::DrawTarget> LockImageSurface(
+ const gfx::IntSize& aLockSize);
++ bool IsFullScreenDraw(const LayoutDeviceIntRegion& aRegion);
+ bool CommitImageSurfaceToWaylandBuffer(const LayoutDeviceIntRegion& aRegion);
+ void CommitWaylandBuffer();
+
+ // TODO: Do we need to hold a reference to nsWindow object?
+ nsWindow* mWindow;
+ nsWaylandDisplay* mWaylandDisplay;
+ WindowBackBuffer* mWaylandBuffer;
+ LayoutDeviceIntRegion mWaylandBufferDamage;
+@@ -113,14 +114,15 @@ class WindowSurfaceWayland : public Wind
+ wl_surface* mLastCommittedSurface;
+ MessageLoop* mDisplayThreadMessageLoop;
+ WindowSurfaceWayland** mDelayedCommitHandle;
+ bool mDrawToWaylandBufferDirectly;
+ bool mPendingCommit;
+ bool mWaylandBufferFullScreenDamage;
+ bool mIsMainThread;
+ bool mNeedScaleFactorUpdate;
++ bool mNeedFullScreenUpdate;
+ };
+
+ } // namespace widget
+ } // namespace mozilla
+
+ #endif // _MOZILLA_WIDGET_GTK_WINDOW_SURFACE_WAYLAND_H
+diff --git a/widget/gtk/nsAppShell.cpp b/widget/gtk/nsAppShell.cpp
+--- a/widget/gtk/nsAppShell.cpp
++++ b/widget/gtk/nsAppShell.cpp
+@@ -35,16 +35,17 @@ using mozilla::widget::ScreenHelperGTK;
+ using mozilla::widget::ScreenManager;
+
+ #define NOTIFY_TOKEN 0xFA
+
+ LazyLogModule gWidgetLog("Widget");
+ LazyLogModule gWidgetFocusLog("WidgetFocus");
+ LazyLogModule gWidgetDragLog("WidgetDrag");
+ LazyLogModule gWidgetDrawLog("WidgetDraw");
++LazyLogModule gWidgetWaylandLog("WidgetWayland");
+
+ static GPollFunc sPollFunc;
+
+ // Wrapper function to disable hang monitoring while waiting in poll().
+ static gint PollWrapper(GPollFD* ufds, guint nfsd, gint timeout_) {
+ mozilla::BackgroundHangMonitor().NotifyWait();
+ gint result;
+ {
+
5 years, 3 months
Architecture specific change in rpms/firefox.git
by githook-noreply＠fedoraproject.org
The package rpms/firefox.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/firefox.git/commit/?id=a99b4bf95a....
Change:
+ExcludeArch: s390x
Thanks.
Full change:
============
commit a99b4bf95a197a3d07d1aca2f8c62a3b709c0dea
Author: Martin Stransky <stransky(a)redhat.com>
Date: Mon Mar 18 11:14:09 2019 +0100
Added fix for mozbz#1468911
diff --git a/firefox.spec b/firefox.spec
index 6ff7864..74bc291 100644
--- a/firefox.spec
+++ b/firefox.spec
@@ -1,10 +1,10 @@
# Set to true if it's going to be submitted as update.
-%global release_build 1
+%global release_build 0
# Disabled arm due to rhbz#1658940
ExcludeArch: armv7hl
# Disabled due to https://pagure.io/fedora-infrastructure/issue/7581
-# ExcludeArch: s390x
+ExcludeArch: s390x
%global system_nss 1
%global system_ffi 1
@@ -95,7 +95,7 @@ ExcludeArch: armv7hl
Summary: Mozilla Firefox Web browser
Name: firefox
Version: 66.0
-Release: 4%{?pre_tag}%{?dist}
+Release: 5%{?pre_tag}%{?dist}
URL: https://www.mozilla.org/firefox/
License: MPLv1.1 or GPLv2+ or LGPLv2+
Source0: https://archive.mozilla.org/pub/firefox/releases/%{version}%{?pre_version...
@@ -156,6 +156,7 @@ Patch575: mozilla-1423598-popup.patch
Patch576: mozilla-1532643-popup.patch
Patch577: mozilla-1535567.patch
Patch578: mozilla-1431399.patch
+Patch579: mozilla-1468911.patch
# PGO/LTO patches
Patch600: pgo.patch
@@ -363,6 +364,7 @@ This package contains results of tests executed during build.
%patch576 -p1 -b .mozilla-1532643-popup
%patch577 -p1 -b .mozilla-1535567
%patch578 -p1 -b .mozilla-1431399
+%patch579 -p1 -b .mozilla-1468911
# PGO patches
%patch600 -p1 -b .pgo
@@ -910,6 +912,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
#---------------------------------------------------------------------
%changelog
+* Mon Mar 18 2019 Martin Stransky <stransky(a)redhat.com> - 66.0-5
+- Added fix for mozbz#1468911
+
* Mon Mar 18 2019 Martin Stransky <stransky(a)redhat.com> - 66.0-4
- Release build
diff --git a/mozilla-1468911.patch b/mozilla-1468911.patch
new file mode 100644
index 0000000..d3177ac
--- /dev/null
+++ b/mozilla-1468911.patch
@@ -0,0 +1,300 @@
+changeset: 465236:be9a6c98a4a7
+tag: tip
+user: Martin Stransky <stransky(a)redhat.com>
+date: Mon Mar 18 10:42:48 2019 +0100
+summary: tearing
+
+diff --git a/widget/gtk/WindowSurfaceWayland.cpp b/widget/gtk/WindowSurfaceWayland.cpp
+--- a/widget/gtk/WindowSurfaceWayland.cpp
++++ b/widget/gtk/WindowSurfaceWayland.cpp
+@@ -15,16 +15,32 @@
+ #include "nsTArray.h"
+ #include "base/message_loop.h" // for MessageLoop
+ #include "base/task.h" // for NewRunnableMethod, etc
+
+ #include <sys/mman.h>
+ #include <fcntl.h>
+ #include <errno.h>
+
++#undef LOG
++#ifdef MOZ_LOGGING
++
++# include "mozilla/Logging.h"
++# include "nsTArray.h"
++# include "Units.h"
++
++extern mozilla::LazyLogModule gWidgetWaylandLog;
++# define LOGWAYLAND(args) MOZ_LOG(gWidgetWaylandLog, mozilla::LogLevel::Debug, args)
++
++#else
++
++# define LOGWAYLAND(args)
++
++#endif /* MOZ_LOGGING */
++
+ namespace mozilla {
+ namespace widget {
+
+ /*
+ Wayland multi-thread rendering scheme
+
+ Every rendering thread (main thread, compositor thread) contains its own
+ nsWaylandDisplay object connected to Wayland compositor (Mutter, Weston, etc.)
+@@ -283,23 +299,30 @@ WindowBackBuffer::WindowBackBuffer(nsWay
+ Create(aWidth, aHeight);
+ }
+
+ WindowBackBuffer::~WindowBackBuffer() { Release(); }
+
+ bool WindowBackBuffer::Resize(int aWidth, int aHeight) {
+ if (aWidth == mWidth && aHeight == mHeight) return true;
+
++ LOGWAYLAND(("WindowBackBuffer::Resize [%p] %d %d\n",
++ (void*)this, aWidth, aHeight));
++
+ Release();
+ Create(aWidth, aHeight);
++ Clear();
+
+ return (mWaylandBuffer != nullptr);
+ }
+
+ void WindowBackBuffer::Attach(wl_surface* aSurface) {
++ LOGWAYLAND(("WindowBackBuffer::Attach [%p] wl_surface %p\n",
++ (void*)this, (void *)aSurface));
++
+ wl_surface_attach(aSurface, mWaylandBuffer, 0, 0);
+ wl_surface_commit(aSurface);
+ wl_display_flush(mWaylandDisplay->GetDisplay());
+ mAttached = true;
+ }
+
+ void WindowBackBuffer::Detach() { mAttached = false; }
+
+@@ -340,17 +363,18 @@ WindowSurfaceWayland::WindowSurfaceWayla
+ mFrameCallback(nullptr),
+ mLastCommittedSurface(nullptr),
+ mDisplayThreadMessageLoop(MessageLoop::current()),
+ mDelayedCommitHandle(nullptr),
+ mDrawToWaylandBufferDirectly(true),
+ mPendingCommit(false),
+ mWaylandBufferFullScreenDamage(false),
+ mIsMainThread(NS_IsMainThread()),
+- mNeedScaleFactorUpdate(true) {
++ mNeedScaleFactorUpdate(true),
++ mNeedFullScreenUpdate(true) {
+ for (int i = 0; i < BACK_BUFFER_NUM; i++) mBackupBuffer[i] = nullptr;
+ }
+
+ WindowSurfaceWayland::~WindowSurfaceWayland() {
+ if (mPendingCommit) {
+ NS_WARNING("Deleted WindowSurfaceWayland with a pending commit!");
+ }
+
+@@ -392,16 +416,17 @@ WindowBackBuffer* WindowSurfaceWayland::
+ }
+
+ if (!mWaylandBuffer->IsAttached()) {
+ if (!mWaylandBuffer->IsMatchingSize(aWidth, aHeight)) {
+ mWaylandBuffer->Resize(aWidth, aHeight);
+ // There's a chance that scale factor has been changed
+ // when buffer size changed
+ mNeedScaleFactorUpdate = true;
++ mNeedFullScreenUpdate = true;
+ }
+ return mWaylandBuffer;
+ }
+
+ MOZ_ASSERT(!mPendingCommit,
+ "Uncommitted buffer switch, screen artifacts ahead.");
+
+ // Front buffer is used by compositor, select a back buffer
+@@ -490,39 +515,36 @@ already_AddRefed<gfx::DrawTarget> Window
+
+ B) Lock() is requested for part(s) of screen. We need to provide temporary
+ surface to draw into and copy result (clipped) to target wl_surface.
+ */
+ already_AddRefed<gfx::DrawTarget> WindowSurfaceWayland::Lock(
+ const LayoutDeviceIntRegion& aRegion) {
+ MOZ_ASSERT(mIsMainThread == NS_IsMainThread());
+
+- LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+- gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
+- gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
++ LOGWAYLAND(("WindowSurfaceWayland::Lock [%p]\n", (void*)this));
+
+ // Are we asked for entire nsWindow to draw?
+- mDrawToWaylandBufferDirectly =
+- (aRegion.GetNumRects() == 1 && bounds.x == 0 && bounds.y == 0 &&
+- lockSize.width == screenRect.width &&
+- lockSize.height == screenRect.height);
+-
++ mDrawToWaylandBufferDirectly = IsFullScreenDraw(aRegion);
+ if (mDrawToWaylandBufferDirectly) {
++ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+ RefPtr<gfx::DrawTarget> dt =
+ LockWaylandBuffer(screenRect.width, screenRect.height,
+ mWindow->WaylandSurfaceNeedsClear());
+ if (dt) {
+ return dt.forget();
+ }
+
+ // We don't have any front buffer available. Try indirect drawing
+ // to mImageSurface which is mirrored to front buffer at commit.
+ mDrawToWaylandBufferDirectly = false;
+ }
+
++ gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
++ gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
+ return LockImageSurface(lockSize);
+ }
+
+ bool WindowSurfaceWayland::CommitImageSurfaceToWaylandBuffer(
+ const LayoutDeviceIntRegion& aRegion) {
+ MOZ_ASSERT(!mDrawToWaylandBufferDirectly);
+
+ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+@@ -611,31 +633,42 @@ void WindowSurfaceWayland::CommitWayland
+ // If our stored wl_surface does not match the actual one it means the frame
+ // callback is no longer active and we should release it.
+ wl_callback_destroy(mFrameCallback);
+ mFrameCallback = nullptr;
+ mLastCommittedSurface = nullptr;
+ }
+
+ if (mWaylandBufferFullScreenDamage) {
++ // We know we can safely redraw whole screen.
+ LayoutDeviceIntRect rect = mWindow->GetBounds();
+ wl_surface_damage(waylandSurface, 0, 0, rect.width, rect.height);
+ mWaylandBufferFullScreenDamage = false;
+ } else {
+ gint scaleFactor = mWindow->GdkScaleFactor();
+ for (auto iter = mWaylandBufferDamage.RectIter(); !iter.Done();
+ iter.Next()) {
+ const mozilla::LayoutDeviceIntRect& r = iter.Get();
+ // We need to remove the scale factor because the wl_surface_damage
+ // also multiplies by current scale factor.
+ wl_surface_damage(waylandSurface, r.x / scaleFactor, r.y / scaleFactor,
+ r.width / scaleFactor, r.height / scaleFactor);
+ }
++
++ // We have to wait untill whole screen is drawn by Gecko, that happens
++ // when window is created or resized.
++ if (mNeedFullScreenUpdate) {
++ if (!IsFullScreenDraw(mWaylandBufferDamage)) {
++ return;
++ }
++ }
+ }
+
++ mNeedFullScreenUpdate = false;
++
+ // Clear all back buffer damage as we're committing
+ // all requested regions.
+ mWaylandBufferDamage.SetEmpty();
+
+ mFrameCallback = wl_surface_frame(waylandSurface);
+ wl_callback_add_listener(mFrameCallback, &frame_listener, this);
+
+ if (mNeedScaleFactorUpdate || mLastCommittedSurface != waylandSurface) {
+@@ -648,16 +681,18 @@ void WindowSurfaceWayland::CommitWayland
+
+ // There's no pending commit, all changes are sent to compositor.
+ mPendingCommit = false;
+ }
+
+ void WindowSurfaceWayland::Commit(const LayoutDeviceIntRegion& aInvalidRegion) {
+ MOZ_ASSERT(mIsMainThread == NS_IsMainThread());
+
++ LOGWAYLAND(("WindowSurfaceWayland::Commit [%p]\n", (void*)this));
++
+ // We have new content at mImageSurface - copy data to mWaylandBuffer first.
+ if (!mDrawToWaylandBufferDirectly) {
+ CommitImageSurfaceToWaylandBuffer(aInvalidRegion);
+ }
+
+ // If we're not at fullscreen damage add drawing area from aInvalidRegion
+ if (!mWaylandBufferFullScreenDamage) {
+ mWaylandBufferDamage.OrWith(aInvalidRegion);
+@@ -690,10 +725,22 @@ void WindowSurfaceWayland::DelayedCommit
+ free(mDelayedCommitHandle);
+ mDelayedCommitHandle = nullptr;
+
+ if (mPendingCommit) {
+ CommitWaylandBuffer();
+ }
+ }
+
++bool WindowSurfaceWayland::IsFullScreenDraw(
++ const LayoutDeviceIntRegion& aRegion) {
++ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
++ gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
++ gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
++
++ // Are we asked to update entire nsWindow?
++ return (bounds.x == 0 && bounds.y == 0 &&
++ lockSize.width == screenRect.width &&
++ lockSize.height == screenRect.height);
++}
++
+ } // namespace widget
+ } // namespace mozilla
+diff --git a/widget/gtk/WindowSurfaceWayland.h b/widget/gtk/WindowSurfaceWayland.h
+--- a/widget/gtk/WindowSurfaceWayland.h
++++ b/widget/gtk/WindowSurfaceWayland.h
+@@ -94,16 +94,17 @@ class WindowSurfaceWayland : public Wind
+
+ private:
+ WindowBackBuffer* GetWaylandBufferToDraw(int aWidth, int aHeight);
+
+ already_AddRefed<gfx::DrawTarget> LockWaylandBuffer(int aWidth, int aHeight,
+ bool aClearBuffer);
+ already_AddRefed<gfx::DrawTarget> LockImageSurface(
+ const gfx::IntSize& aLockSize);
++ bool IsFullScreenDraw(const LayoutDeviceIntRegion& aRegion);
+ bool CommitImageSurfaceToWaylandBuffer(const LayoutDeviceIntRegion& aRegion);
+ void CommitWaylandBuffer();
+
+ // TODO: Do we need to hold a reference to nsWindow object?
+ nsWindow* mWindow;
+ nsWaylandDisplay* mWaylandDisplay;
+ WindowBackBuffer* mWaylandBuffer;
+ LayoutDeviceIntRegion mWaylandBufferDamage;
+@@ -113,14 +114,15 @@ class WindowSurfaceWayland : public Wind
+ wl_surface* mLastCommittedSurface;
+ MessageLoop* mDisplayThreadMessageLoop;
+ WindowSurfaceWayland** mDelayedCommitHandle;
+ bool mDrawToWaylandBufferDirectly;
+ bool mPendingCommit;
+ bool mWaylandBufferFullScreenDamage;
+ bool mIsMainThread;
+ bool mNeedScaleFactorUpdate;
++ bool mNeedFullScreenUpdate;
+ };
+
+ } // namespace widget
+ } // namespace mozilla
+
+ #endif // _MOZILLA_WIDGET_GTK_WINDOW_SURFACE_WAYLAND_H
+diff --git a/widget/gtk/nsAppShell.cpp b/widget/gtk/nsAppShell.cpp
+--- a/widget/gtk/nsAppShell.cpp
++++ b/widget/gtk/nsAppShell.cpp
+@@ -35,16 +35,17 @@ using mozilla::widget::ScreenHelperGTK;
+ using mozilla::widget::ScreenManager;
+
+ #define NOTIFY_TOKEN 0xFA
+
+ LazyLogModule gWidgetLog("Widget");
+ LazyLogModule gWidgetFocusLog("WidgetFocus");
+ LazyLogModule gWidgetDragLog("WidgetDrag");
+ LazyLogModule gWidgetDrawLog("WidgetDraw");
++LazyLogModule gWidgetWaylandLog("WidgetWayland");
+
+ static GPollFunc sPollFunc;
+
+ // Wrapper function to disable hang monitoring while waiting in poll().
+ static gint PollWrapper(GPollFD* ufds, guint nfsd, gint timeout_) {
+ mozilla::BackgroundHangMonitor().NotifyWait();
+ gint result;
+ {
+
5 years, 3 months
Architecture specific change in rpms/firefox.git
by githook-noreply＠fedoraproject.org
The package rpms/firefox.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/firefox.git/commit/?id=a99b4bf95a....
Change:
+ExcludeArch: s390x
Thanks.
Full change:
============
commit a99b4bf95a197a3d07d1aca2f8c62a3b709c0dea
Author: Martin Stransky <stransky(a)redhat.com>
Date: Mon Mar 18 11:14:09 2019 +0100
Added fix for mozbz#1468911
diff --git a/firefox.spec b/firefox.spec
index 6ff7864..74bc291 100644
--- a/firefox.spec
+++ b/firefox.spec
@@ -1,10 +1,10 @@
# Set to true if it's going to be submitted as update.
-%global release_build 1
+%global release_build 0
# Disabled arm due to rhbz#1658940
ExcludeArch: armv7hl
# Disabled due to https://pagure.io/fedora-infrastructure/issue/7581
-# ExcludeArch: s390x
+ExcludeArch: s390x
%global system_nss 1
%global system_ffi 1
@@ -95,7 +95,7 @@ ExcludeArch: armv7hl
Summary: Mozilla Firefox Web browser
Name: firefox
Version: 66.0
-Release: 4%{?pre_tag}%{?dist}
+Release: 5%{?pre_tag}%{?dist}
URL: https://www.mozilla.org/firefox/
License: MPLv1.1 or GPLv2+ or LGPLv2+
Source0: https://archive.mozilla.org/pub/firefox/releases/%{version}%{?pre_version...
@@ -156,6 +156,7 @@ Patch575: mozilla-1423598-popup.patch
Patch576: mozilla-1532643-popup.patch
Patch577: mozilla-1535567.patch
Patch578: mozilla-1431399.patch
+Patch579: mozilla-1468911.patch
# PGO/LTO patches
Patch600: pgo.patch
@@ -363,6 +364,7 @@ This package contains results of tests executed during build.
%patch576 -p1 -b .mozilla-1532643-popup
%patch577 -p1 -b .mozilla-1535567
%patch578 -p1 -b .mozilla-1431399
+%patch579 -p1 -b .mozilla-1468911
# PGO patches
%patch600 -p1 -b .pgo
@@ -910,6 +912,9 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor &>/dev/null || :
#---------------------------------------------------------------------
%changelog
+* Mon Mar 18 2019 Martin Stransky <stransky(a)redhat.com> - 66.0-5
+- Added fix for mozbz#1468911
+
* Mon Mar 18 2019 Martin Stransky <stransky(a)redhat.com> - 66.0-4
- Release build
diff --git a/mozilla-1468911.patch b/mozilla-1468911.patch
new file mode 100644
index 0000000..d3177ac
--- /dev/null
+++ b/mozilla-1468911.patch
@@ -0,0 +1,300 @@
+changeset: 465236:be9a6c98a4a7
+tag: tip
+user: Martin Stransky <stransky(a)redhat.com>
+date: Mon Mar 18 10:42:48 2019 +0100
+summary: tearing
+
+diff --git a/widget/gtk/WindowSurfaceWayland.cpp b/widget/gtk/WindowSurfaceWayland.cpp
+--- a/widget/gtk/WindowSurfaceWayland.cpp
++++ b/widget/gtk/WindowSurfaceWayland.cpp
+@@ -15,16 +15,32 @@
+ #include "nsTArray.h"
+ #include "base/message_loop.h" // for MessageLoop
+ #include "base/task.h" // for NewRunnableMethod, etc
+
+ #include <sys/mman.h>
+ #include <fcntl.h>
+ #include <errno.h>
+
++#undef LOG
++#ifdef MOZ_LOGGING
++
++# include "mozilla/Logging.h"
++# include "nsTArray.h"
++# include "Units.h"
++
++extern mozilla::LazyLogModule gWidgetWaylandLog;
++# define LOGWAYLAND(args) MOZ_LOG(gWidgetWaylandLog, mozilla::LogLevel::Debug, args)
++
++#else
++
++# define LOGWAYLAND(args)
++
++#endif /* MOZ_LOGGING */
++
+ namespace mozilla {
+ namespace widget {
+
+ /*
+ Wayland multi-thread rendering scheme
+
+ Every rendering thread (main thread, compositor thread) contains its own
+ nsWaylandDisplay object connected to Wayland compositor (Mutter, Weston, etc.)
+@@ -283,23 +299,30 @@ WindowBackBuffer::WindowBackBuffer(nsWay
+ Create(aWidth, aHeight);
+ }
+
+ WindowBackBuffer::~WindowBackBuffer() { Release(); }
+
+ bool WindowBackBuffer::Resize(int aWidth, int aHeight) {
+ if (aWidth == mWidth && aHeight == mHeight) return true;
+
++ LOGWAYLAND(("WindowBackBuffer::Resize [%p] %d %d\n",
++ (void*)this, aWidth, aHeight));
++
+ Release();
+ Create(aWidth, aHeight);
++ Clear();
+
+ return (mWaylandBuffer != nullptr);
+ }
+
+ void WindowBackBuffer::Attach(wl_surface* aSurface) {
++ LOGWAYLAND(("WindowBackBuffer::Attach [%p] wl_surface %p\n",
++ (void*)this, (void *)aSurface));
++
+ wl_surface_attach(aSurface, mWaylandBuffer, 0, 0);
+ wl_surface_commit(aSurface);
+ wl_display_flush(mWaylandDisplay->GetDisplay());
+ mAttached = true;
+ }
+
+ void WindowBackBuffer::Detach() { mAttached = false; }
+
+@@ -340,17 +363,18 @@ WindowSurfaceWayland::WindowSurfaceWayla
+ mFrameCallback(nullptr),
+ mLastCommittedSurface(nullptr),
+ mDisplayThreadMessageLoop(MessageLoop::current()),
+ mDelayedCommitHandle(nullptr),
+ mDrawToWaylandBufferDirectly(true),
+ mPendingCommit(false),
+ mWaylandBufferFullScreenDamage(false),
+ mIsMainThread(NS_IsMainThread()),
+- mNeedScaleFactorUpdate(true) {
++ mNeedScaleFactorUpdate(true),
++ mNeedFullScreenUpdate(true) {
+ for (int i = 0; i < BACK_BUFFER_NUM; i++) mBackupBuffer[i] = nullptr;
+ }
+
+ WindowSurfaceWayland::~WindowSurfaceWayland() {
+ if (mPendingCommit) {
+ NS_WARNING("Deleted WindowSurfaceWayland with a pending commit!");
+ }
+
+@@ -392,16 +416,17 @@ WindowBackBuffer* WindowSurfaceWayland::
+ }
+
+ if (!mWaylandBuffer->IsAttached()) {
+ if (!mWaylandBuffer->IsMatchingSize(aWidth, aHeight)) {
+ mWaylandBuffer->Resize(aWidth, aHeight);
+ // There's a chance that scale factor has been changed
+ // when buffer size changed
+ mNeedScaleFactorUpdate = true;
++ mNeedFullScreenUpdate = true;
+ }
+ return mWaylandBuffer;
+ }
+
+ MOZ_ASSERT(!mPendingCommit,
+ "Uncommitted buffer switch, screen artifacts ahead.");
+
+ // Front buffer is used by compositor, select a back buffer
+@@ -490,39 +515,36 @@ already_AddRefed<gfx::DrawTarget> Window
+
+ B) Lock() is requested for part(s) of screen. We need to provide temporary
+ surface to draw into and copy result (clipped) to target wl_surface.
+ */
+ already_AddRefed<gfx::DrawTarget> WindowSurfaceWayland::Lock(
+ const LayoutDeviceIntRegion& aRegion) {
+ MOZ_ASSERT(mIsMainThread == NS_IsMainThread());
+
+- LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+- gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
+- gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
++ LOGWAYLAND(("WindowSurfaceWayland::Lock [%p]\n", (void*)this));
+
+ // Are we asked for entire nsWindow to draw?
+- mDrawToWaylandBufferDirectly =
+- (aRegion.GetNumRects() == 1 && bounds.x == 0 && bounds.y == 0 &&
+- lockSize.width == screenRect.width &&
+- lockSize.height == screenRect.height);
+-
++ mDrawToWaylandBufferDirectly = IsFullScreenDraw(aRegion);
+ if (mDrawToWaylandBufferDirectly) {
++ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+ RefPtr<gfx::DrawTarget> dt =
+ LockWaylandBuffer(screenRect.width, screenRect.height,
+ mWindow->WaylandSurfaceNeedsClear());
+ if (dt) {
+ return dt.forget();
+ }
+
+ // We don't have any front buffer available. Try indirect drawing
+ // to mImageSurface which is mirrored to front buffer at commit.
+ mDrawToWaylandBufferDirectly = false;
+ }
+
++ gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
++ gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
+ return LockImageSurface(lockSize);
+ }
+
+ bool WindowSurfaceWayland::CommitImageSurfaceToWaylandBuffer(
+ const LayoutDeviceIntRegion& aRegion) {
+ MOZ_ASSERT(!mDrawToWaylandBufferDirectly);
+
+ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
+@@ -611,31 +633,42 @@ void WindowSurfaceWayland::CommitWayland
+ // If our stored wl_surface does not match the actual one it means the frame
+ // callback is no longer active and we should release it.
+ wl_callback_destroy(mFrameCallback);
+ mFrameCallback = nullptr;
+ mLastCommittedSurface = nullptr;
+ }
+
+ if (mWaylandBufferFullScreenDamage) {
++ // We know we can safely redraw whole screen.
+ LayoutDeviceIntRect rect = mWindow->GetBounds();
+ wl_surface_damage(waylandSurface, 0, 0, rect.width, rect.height);
+ mWaylandBufferFullScreenDamage = false;
+ } else {
+ gint scaleFactor = mWindow->GdkScaleFactor();
+ for (auto iter = mWaylandBufferDamage.RectIter(); !iter.Done();
+ iter.Next()) {
+ const mozilla::LayoutDeviceIntRect& r = iter.Get();
+ // We need to remove the scale factor because the wl_surface_damage
+ // also multiplies by current scale factor.
+ wl_surface_damage(waylandSurface, r.x / scaleFactor, r.y / scaleFactor,
+ r.width / scaleFactor, r.height / scaleFactor);
+ }
++
++ // We have to wait untill whole screen is drawn by Gecko, that happens
++ // when window is created or resized.
++ if (mNeedFullScreenUpdate) {
++ if (!IsFullScreenDraw(mWaylandBufferDamage)) {
++ return;
++ }
++ }
+ }
+
++ mNeedFullScreenUpdate = false;
++
+ // Clear all back buffer damage as we're committing
+ // all requested regions.
+ mWaylandBufferDamage.SetEmpty();
+
+ mFrameCallback = wl_surface_frame(waylandSurface);
+ wl_callback_add_listener(mFrameCallback, &frame_listener, this);
+
+ if (mNeedScaleFactorUpdate || mLastCommittedSurface != waylandSurface) {
+@@ -648,16 +681,18 @@ void WindowSurfaceWayland::CommitWayland
+
+ // There's no pending commit, all changes are sent to compositor.
+ mPendingCommit = false;
+ }
+
+ void WindowSurfaceWayland::Commit(const LayoutDeviceIntRegion& aInvalidRegion) {
+ MOZ_ASSERT(mIsMainThread == NS_IsMainThread());
+
++ LOGWAYLAND(("WindowSurfaceWayland::Commit [%p]\n", (void*)this));
++
+ // We have new content at mImageSurface - copy data to mWaylandBuffer first.
+ if (!mDrawToWaylandBufferDirectly) {
+ CommitImageSurfaceToWaylandBuffer(aInvalidRegion);
+ }
+
+ // If we're not at fullscreen damage add drawing area from aInvalidRegion
+ if (!mWaylandBufferFullScreenDamage) {
+ mWaylandBufferDamage.OrWith(aInvalidRegion);
+@@ -690,10 +725,22 @@ void WindowSurfaceWayland::DelayedCommit
+ free(mDelayedCommitHandle);
+ mDelayedCommitHandle = nullptr;
+
+ if (mPendingCommit) {
+ CommitWaylandBuffer();
+ }
+ }
+
++bool WindowSurfaceWayland::IsFullScreenDraw(
++ const LayoutDeviceIntRegion& aRegion) {
++ LayoutDeviceIntRect screenRect = mWindow->GetBounds();
++ gfx::IntRect bounds = aRegion.GetBounds().ToUnknownRect();
++ gfx::IntSize lockSize(bounds.XMost(), bounds.YMost());
++
++ // Are we asked to update entire nsWindow?
++ return (bounds.x == 0 && bounds.y == 0 &&
++ lockSize.width == screenRect.width &&
++ lockSize.height == screenRect.height);
++}
++
+ } // namespace widget
+ } // namespace mozilla
+diff --git a/widget/gtk/WindowSurfaceWayland.h b/widget/gtk/WindowSurfaceWayland.h
+--- a/widget/gtk/WindowSurfaceWayland.h
++++ b/widget/gtk/WindowSurfaceWayland.h
+@@ -94,16 +94,17 @@ class WindowSurfaceWayland : public Wind
+
+ private:
+ WindowBackBuffer* GetWaylandBufferToDraw(int aWidth, int aHeight);
+
+ already_AddRefed<gfx::DrawTarget> LockWaylandBuffer(int aWidth, int aHeight,
+ bool aClearBuffer);
+ already_AddRefed<gfx::DrawTarget> LockImageSurface(
+ const gfx::IntSize& aLockSize);
++ bool IsFullScreenDraw(const LayoutDeviceIntRegion& aRegion);
+ bool CommitImageSurfaceToWaylandBuffer(const LayoutDeviceIntRegion& aRegion);
+ void CommitWaylandBuffer();
+
+ // TODO: Do we need to hold a reference to nsWindow object?
+ nsWindow* mWindow;
+ nsWaylandDisplay* mWaylandDisplay;
+ WindowBackBuffer* mWaylandBuffer;
+ LayoutDeviceIntRegion mWaylandBufferDamage;
+@@ -113,14 +114,15 @@ class WindowSurfaceWayland : public Wind
+ wl_surface* mLastCommittedSurface;
+ MessageLoop* mDisplayThreadMessageLoop;
+ WindowSurfaceWayland** mDelayedCommitHandle;
+ bool mDrawToWaylandBufferDirectly;
+ bool mPendingCommit;
+ bool mWaylandBufferFullScreenDamage;
+ bool mIsMainThread;
+ bool mNeedScaleFactorUpdate;
++ bool mNeedFullScreenUpdate;
+ };
+
+ } // namespace widget
+ } // namespace mozilla
+
+ #endif // _MOZILLA_WIDGET_GTK_WINDOW_SURFACE_WAYLAND_H
+diff --git a/widget/gtk/nsAppShell.cpp b/widget/gtk/nsAppShell.cpp
+--- a/widget/gtk/nsAppShell.cpp
++++ b/widget/gtk/nsAppShell.cpp
+@@ -35,16 +35,17 @@ using mozilla::widget::ScreenHelperGTK;
+ using mozilla::widget::ScreenManager;
+
+ #define NOTIFY_TOKEN 0xFA
+
+ LazyLogModule gWidgetLog("Widget");
+ LazyLogModule gWidgetFocusLog("WidgetFocus");
+ LazyLogModule gWidgetDragLog("WidgetDrag");
+ LazyLogModule gWidgetDrawLog("WidgetDraw");
++LazyLogModule gWidgetWaylandLog("WidgetWayland");
+
+ static GPollFunc sPollFunc;
+
+ // Wrapper function to disable hang monitoring while waiting in poll().
+ static gint PollWrapper(GPollFD* ufds, guint nfsd, gint timeout_) {
+ mozilla::BackgroundHangMonitor().NotifyWait();
+ gint result;
+ {
+
5 years, 3 months
Architecture specific change in rpms/eclipse-moreunit.git
by githook-noreply＠fedoraproject.org
The package rpms/eclipse-moreunit.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/eclipse-moreunit.git/commit/?id=6....
Change:
+ExcludeArch: s390 %{arm} %{ix86}
Thanks.
Full change:
============
commit 6c4ea5f9055fbedadaeddc6e93a8ba72c4e20e69
Author: Mat Booth <mat.booth(a)redhat.com>
Date: Mon Mar 18 10:02:36 2019 +0000
Update to latest upstream release
Update license tag
Restrict to same architectures as Eclipse itself
diff --git a/.gitignore b/.gitignore
index 83339fb..6c62a93 100644
--- a/.gitignore
+++ b/.gitignore
@@ -10,3 +10,4 @@ eclipse-moreunit-2.4.6.tar.xz
/moreunit-code-2f5ff2681f9aa396fedbf8ff4f8db14563929e0e.zip
/v3.1.0.tar.gz
/v3.1.1.tar.gz
+/v3.2.1.tar.gz
diff --git a/eclipse-moreunit.spec b/eclipse-moreunit.spec
index 5f5c426..0b46703 100644
--- a/eclipse-moreunit.spec
+++ b/eclipse-moreunit.spec
@@ -1,18 +1,20 @@
Name: eclipse-moreunit
-Version: 3.1.1
-Release: 6%{?dist}
+Version: 3.2.1
+Release: 1%{?dist}
Summary: An Eclipse plugin that assists with writing more unit tests
-License: EPL
-URL: http://moreunit.sourceforge.net
+License: EPL-1.0
+URL: https://moreunit.github.io/MoreUnit-Eclipse/
Source0: https://github.com/MoreUnit/MoreUnit-Eclipse/archive/v%{version}.tar.gz
BuildArch: noarch
-BuildRequires: eclipse-pde >= 1:3.6.0
+# Upstream Eclipse no longer supports non-64bit arches
+ExcludeArch: s390 %{arm} %{ix86}
+
+BuildRequires: eclipse-pde
BuildRequires: tycho
BuildRequires: mvn(org.codehaus.mojo:exec-maven-plugin)
-Requires: eclipse-jdt >= 3.6.0
%description
MoreUnit is an Eclipse plugin that should assist with writing more unit tests.
@@ -46,8 +48,14 @@ popd
%mvn_install
%files -f .mfiles
+%doc README.md
%changelog
+* Mon Mar 18 2019 Mat Booth <mat.booth(a)redhat.com> - 3.2.1-1
+- Update to latest upstream release
+- Update license tag
+- Restrict to same architectures as Eclipse itself
+
* Thu Jan 31 2019 Fedora Release Engineering <releng(a)fedoraproject.org> - 3.1.1-6
- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
diff --git a/sources b/sources
index 5b4372c..3b63d4d 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-48cc98de84bb08d1e0fecbad25ddf9c6 v3.1.1.tar.gz
+SHA512 (v3.2.1.tar.gz) = 12a36b956d9325b9ae907196833875dc32bd26df9cd191cabb7a821084970cc8843ef88dc99cb479179b642e2ef53b5d69dce7da43ba90e35680c4b3ee79359d
5 years, 3 months
Architecture specific change in rpms/eclipse-moreunit.git
by githook-noreply＠fedoraproject.org
The package rpms/eclipse-moreunit.git has added or updated architecture specific content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/eclipse-moreunit.git/commit/?id=6....
Change:
+ExcludeArch: s390 %{arm} %{ix86}
Thanks.
Full change:
============
commit 6c4ea5f9055fbedadaeddc6e93a8ba72c4e20e69
Author: Mat Booth <mat.booth(a)redhat.com>
Date: Mon Mar 18 10:02:36 2019 +0000
Update to latest upstream release
Update license tag
Restrict to same architectures as Eclipse itself
diff --git a/.gitignore b/.gitignore
index 83339fb..6c62a93 100644
--- a/.gitignore
+++ b/.gitignore
@@ -10,3 +10,4 @@ eclipse-moreunit-2.4.6.tar.xz
/moreunit-code-2f5ff2681f9aa396fedbf8ff4f8db14563929e0e.zip
/v3.1.0.tar.gz
/v3.1.1.tar.gz
+/v3.2.1.tar.gz
diff --git a/eclipse-moreunit.spec b/eclipse-moreunit.spec
index 5f5c426..0b46703 100644
--- a/eclipse-moreunit.spec
+++ b/eclipse-moreunit.spec
@@ -1,18 +1,20 @@
Name: eclipse-moreunit
-Version: 3.1.1
-Release: 6%{?dist}
+Version: 3.2.1
+Release: 1%{?dist}
Summary: An Eclipse plugin that assists with writing more unit tests
-License: EPL
-URL: http://moreunit.sourceforge.net
+License: EPL-1.0
+URL: https://moreunit.github.io/MoreUnit-Eclipse/
Source0: https://github.com/MoreUnit/MoreUnit-Eclipse/archive/v%{version}.tar.gz
BuildArch: noarch
-BuildRequires: eclipse-pde >= 1:3.6.0
+# Upstream Eclipse no longer supports non-64bit arches
+ExcludeArch: s390 %{arm} %{ix86}
+
+BuildRequires: eclipse-pde
BuildRequires: tycho
BuildRequires: mvn(org.codehaus.mojo:exec-maven-plugin)
-Requires: eclipse-jdt >= 3.6.0
%description
MoreUnit is an Eclipse plugin that should assist with writing more unit tests.
@@ -46,8 +48,14 @@ popd
%mvn_install
%files -f .mfiles
+%doc README.md
%changelog
+* Mon Mar 18 2019 Mat Booth <mat.booth(a)redhat.com> - 3.2.1-1
+- Update to latest upstream release
+- Update license tag
+- Restrict to same architectures as Eclipse itself
+
* Thu Jan 31 2019 Fedora Release Engineering <releng(a)fedoraproject.org> - 3.1.1-6
- Rebuilt for https://fedoraproject.org/wiki/Fedora_30_Mass_Rebuild
diff --git a/sources b/sources
index 5b4372c..3b63d4d 100644
--- a/sources
+++ b/sources
@@ -1 +1 @@
-48cc98de84bb08d1e0fecbad25ddf9c6 v3.1.1.tar.gz
+SHA512 (v3.2.1.tar.gz) = 12a36b956d9325b9ae907196833875dc32bd26df9cd191cabb7a821084970cc8843ef88dc99cb479179b642e2ef53b5d69dce7da43ba90e35680c4b3ee79359d
5 years, 3 months