The package rpms/webrtc-audio-processing.git has added or updated architecture specific
content in its
spec file (ExclusiveArch/ExcludeArch or %ifarch/%ifnarch) in commit(s):
https://src.fedoraproject.org/cgit/rpms/webrtc-audio-processing.git/commi....
Change:
+%ifarch %{arm} aarch64
Thanks.
Full change:
============
commit 95829f323b51c0b1690f8ccf01e2fb0d6c634d4d
Author: Peter Robinson <pbrobinson(a)gmail.com>
Date: Sat Mar 3 15:31:02 2018 +0000
remove no longer used neon patch
diff --git a/webrtc-audio-processing-0.3-neon.patch
b/webrtc-audio-processing-0.3-neon.patch
deleted file mode 100644
index 30145db..0000000
--- a/webrtc-audio-processing-0.3-neon.patch
+++ /dev/null
@@ -1,54 +0,0 @@
-diff -up webrtc-audio-processing-0.3/configure.ac.neon
webrtc-audio-processing-0.3/configure.ac
---- webrtc-audio-processing-0.3/configure.ac.neon 2016-06-22 01:46:41.000000000 -0500
-+++ webrtc-audio-processing-0.3/configure.ac 2016-07-18 08:01:43.541116030 -0500
-@@ -98,7 +98,7 @@ AS_IF([test "x$enable_neon" != "xno"],
- ],
- [
- HAVE_NEON=1
-- ARCH_CFLAGS="$ARCH_CFLAGS -DWEBRTC_DETECT_NEON -mfpu=neon"
-+ ARCH_CFLAGS="$ARCH_CFLAGS -DWEBRTC_DETECT_NEON"
- ])
- )
- AM_CONDITIONAL([HAVE_NEON], [test "x$HAVE_NEON" = "x1"])
-diff -up webrtc-audio-processing-0.3/webrtc/common_audio/Makefile.am.neon
webrtc-audio-processing-0.3/webrtc/common_audio/Makefile.am
---- webrtc-audio-processing-0.3/webrtc/common_audio/Makefile.am.neon 2016-06-21
06:16:05.000000000 -0500
-+++ webrtc-audio-processing-0.3/webrtc/common_audio/Makefile.am 2016-07-18
07:40:02.128151244 -0500
-@@ -118,13 +118,18 @@ libcommon_audio_la_SOURCES += \
- endif
-
- if HAVE_NEON
--libcommon_audio_la_SOURCES += \
-+noinst_LTLIBRARIES += libcommon_audio_neon.la
-+libcommon_audio_neon_la_SOURCES = \
- resampler/sinc_resampler_neon.cc \
- signal_processing/cross_correlation_neon.c \
- signal_processing/downsample_fast_neon.c \
- signal_processing/min_max_operations_neon.c \
- fir_filter_neon.cc \
- fir_filter_neon.h
-+
-+libcommon_audio_neon_la_CFLAGS = -mfpu=neon $(AM_CFLAGS) $(COMMON_CFLAGS) -mfpu=neon
-+libcommon_audio_neon_la_CXXFLAGS = -mfpu=neon $(AM_CXXFLAGS) $(COMMON_CXXFLAGS)
-mfpu=neon
-+libcommon_audio_neon_la_LDFLAGS = $(AM_LDFLAGS)
- endif
-
- if !HAVE_ARM
-diff -up webrtc-audio-processing-0.3/webrtc/modules/audio_processing/Makefile.am.neon
webrtc-audio-processing-0.3/webrtc/modules/audio_processing/Makefile.am
----
webrtc-audio-processing-0.3/webrtc/modules/audio_processing/Makefile.am.neon 2016-06-21
06:15:34.000000000 -0500
-+++ webrtc-audio-processing-0.3/webrtc/modules/audio_processing/Makefile.am 2016-07-18
07:40:02.128151244 -0500
-@@ -158,10 +158,15 @@ libwebrtc_audio_processing_privatearch_l
- endif
-
- if HAVE_NEON
-+noinst_LTLIBRARIES = libwebrtc_audio_processing_privatearch.la
-+LIBWEBRTC_PRIVATEARCH=libwebrtc_audio_processing_privatearch.la
- libwebrtc_audio_processing_la_SOURCES += \
- aec/aec_core_neon.c \
- aec/aec_rdft_neon.c \
- aecm/aecm_core_neon.c
-+libwebrtc_audio_processing_privatearch_la_CFLAGS = -mfpu=neon $(AM_CFLAGS)
$(COMMON_CFLAGS) -mfpu=neon
-+libwebrtc_audio_processing_privatearch_la_CXXFLAGS = -mfpu=neon $(AM_CXXFLAGS)
$(COMMON_CXXFLAGS) -mfpu-neon
-+libwebrtc_audio_processing_privatearch_la_LDFLAGS = $(AM_LDFLAGS)
- endif
-
- libwebrtc_audio_processing_la_CFLAGS = $(AM_CFLAGS) $(COMMON_CFLAGS)
commit b0c5f9f2c5b2b9b4489d70e3f6ab2b8154874195
Author: Peter Robinson <pbrobinson(a)gmail.com>
Date: Sat Mar 3 15:30:28 2018 +0000
fix up aarch64 build by just disabling neon everywhere (I wish enable-neon=runtime
actually worked), minor cleanups
diff --git a/webrtc-audio-processing.spec b/webrtc-audio-processing.spec
index bf3943e..5a7f7c1 100644
--- a/webrtc-audio-processing.spec
+++ b/webrtc-audio-processing.spec
@@ -1,7 +1,6 @@
-
Name: webrtc-audio-processing
Version: 0.3
-Release: 6%{?dist}
+Release: 7%{?dist}
Summary: Library for echo cancellation
License: BSD
@@ -27,13 +26,11 @@ Patch15:
0015-doc-file-invalid-reference-to-pulseaudio-mailing-lis.patch
Patch16: 0016-build-Fix-configure-option-with-ns-mode.patch
Patch100: webrtc-fix-typedefs-on-other-arches.patch
-# WIP to only explicitly add -mfpu=neon where needed for neon runtime detection
-# currently doesn't work due to %%configure injecting incompatible CFLAGS atm, see
below
-Patch101: webrtc-audio-processing-0.3-neon.patch
# bz#1336466,
https://bugs.freedesktop.org/show_bug.cgi?id=95738
Patch104: webrtc-audio-processing-0.2-big-endian.patch
-BuildRequires: automake libtool
+BuildRequires: autoconf automake libtool
+BuildRequires: gcc gcc-c++
%description
%{name} is a library derived from Google WebRTC project that
@@ -51,26 +48,14 @@ files for developing applications that use %{name}.
%prep
%autosetup -p1
-# for patch1
-autoreconf -fi
-
-
%build
-
-%ifarch %{arm}
-# disable neon support
-# can't unconditionally enable neon, and --enable-neon=runtime is broken
(WebRtc_GetCPUFeaturesARM is unimplemented)
-%global neon --enable-neon=no
-## hack to ensure -mfpu=neon flag appears last when using --enable-neon=yes|runtime
-#export CFLAGS="%{optflags} -mfpu=neon"
-#export CXXFLAGS="%{optflags} -mfpu=neon"
-## except that enables it for *all* objects, not just the ones we want (see patch1),
-## seems CFLAGS always trumps project flags, see also:
-##
http://www.gnu.org/software/automake/manual/html_node/Flag-Variables-Orde...
-%endif
+# for patch1
+autoreconf -vif
%configure \
- %{?neon} \
+%ifarch %{arm} aarch64
+ --enable-neon=no \
+%endif
--disable-silent-rules \
--disable-static
@@ -80,8 +65,8 @@ make %{?_smp_mflags}
%install
make install DESTDIR=%{buildroot} INSTALL="install -p"
-## unpackaged files
-rm -fv %{buildroot}%{_libdir}/lib*.la
+# remove libtool archives
+find %{buildroot} -type f -name "*.la" -delete
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
@@ -99,6 +84,10 @@ rm -fv %{buildroot}%{_libdir}/lib*.la
%changelog
+* Sat Mar 3 2018 Peter Robinson <pbrobinson(a)fedoraproject.org> 0.3-7
+- Add gcc/gcc-c++ build requires
+- Add aarch64 to NEON exception
+
* Fri Feb 09 2018 Fedora Release Engineering <releng(a)fedoraproject.org> - 0.3-6
- Rebuilt for
https://fedoraproject.org/wiki/Fedora_28_Mass_Rebuild