On 04/30/2012 12:56 PM, Josh Boyer wrote:
On Mon, Apr 30, 2012 at 12:50:56PM -0400, Eric Paris wrote:
> On Mon, 2012-04-30 at 12:47 -0400, Josh Boyer wrote:
>> On Sun, Apr 29, 2012 at 02:40:01AM -0400, Jon Masters wrote:
>> Going to assume you forwarded this here because you want it applied to
>> the Fedora kernel. Likely F17/rawhide?
>> I'm guessing we probably want to follow
>> for a bit to see if there are any more iterations of this?
>> Since it's CC'd to stable, it should get picked up rather quickly if RMK
>> applies it.
> You probably want to follow this thread as it's where an ARM developer
> actually looked at it :)
Yep, saw that too. Guess I'll keep my eyes peeled.
Yea, as Russell says, the original code in there for audit was "complete
crap". My fix was just to get rid of obvious register corruption after
wasting a lot of time hunting it down, but I did not extensively test
audit to see that it was actually working since it seemed obvious there
would be other problems, too (you know, given this, who knows what else
is wrong - clearly nobody uses it). Will's version is probably where
we'll go for this issue. I'm going to test his patch later and then see
if audit actually works properly with some further tests - again,
leaning toward turning off audit on ARM anyway until we know there are
no more horrors, given this little shocker.
P.S. Technically OOTO today. I'll test the latest patch tonight and
followup - yes, I did forward assuming you'd want to pull, and next time
I'll try harder to spell out my intent/request, etc.