Hi,
While working on my Fedora packages, I noticed that %configure replaces config.guess and config.sub with /usr/lib/rpm/redhat/config.guess and /usr/lib/rpm/redhat/config.sub, ie:
+ for i in '$(find . -name config.guess -o -name config.sub)' ++ basename ./lib-src/libresample/config.guess + '[' -f /usr/lib/rpm/redhat/config.guess ']' + /usr/bin/rm -f ./lib-src/libresample/config.guess ++ basename ./lib-src/libresample/config.guess + /usr/bin/cp -fv /usr/lib/rpm/redhat/config.guess ./lib-src/libresample/config '/usr/lib/rpm/redhat/config.guess' -> './lib-src/libresample/config.guess' + for i in '$(find . -name config.guess -o -name config.sub)' ++ basename ./config.sub + '[' -f /usr/lib/rpm/redhat/config.sub ']' + /usr/bin/rm -f ./config.sub ++ basename ./config.sub + /usr/bin/cp -fv /usr/lib/rpm/redhat/config.sub ./config.sub '/usr/lib/rpm/redhat/config.sub' -> './config.sub' + for i in '$(find . -name config.guess -o -name config.sub)' ++ basename ./config.guess + '[' -f /usr/lib/rpm/redhat/config.guess ']' + /usr/bin/rm -f ./config.guess ++ basename ./config.guess + /usr/bin/cp -fv /usr/lib/rpm/redhat/config.guess ./config.guess '/usr/lib/rpm/redhat/config.guess' -> './config.guess'
So why do we need to run autoreconf to update these, if they are replaced anyways ???
Regards,
Hans
On Sat, May 4, 2013 at 2:25 PM, Hans de Goede hdegoede@redhat.com wrote:
Hi,
While working on my Fedora packages, I noticed that %configure replaces config.guess and config.sub with /usr/lib/rpm/redhat/config.guess and /usr/lib/rpm/redhat/config.sub, ie:
- for i in '$(find . -name config.guess -o -name config.sub)'
++ basename ./lib-src/libresample/config.guess
- '[' -f /usr/lib/rpm/redhat/config.guess ']'
- /usr/bin/rm -f ./lib-src/libresample/config.guess
++ basename ./lib-src/libresample/config.guess
- /usr/bin/cp -fv /usr/lib/rpm/redhat/config.guess
./lib-src/libresample/config '/usr/lib/rpm/redhat/config.guess' -> './lib-src/libresample/config.guess'
- for i in '$(find . -name config.guess -o -name config.sub)'
++ basename ./config.sub
- '[' -f /usr/lib/rpm/redhat/config.sub ']'
- /usr/bin/rm -f ./config.sub
++ basename ./config.sub
- /usr/bin/cp -fv /usr/lib/rpm/redhat/config.sub ./config.sub
'/usr/lib/rpm/redhat/config.sub' -> './config.sub'
- for i in '$(find . -name config.guess -o -name config.sub)'
++ basename ./config.guess
- '[' -f /usr/lib/rpm/redhat/config.guess ']'
- /usr/bin/rm -f ./config.guess
++ basename ./config.guess
- /usr/bin/cp -fv /usr/lib/rpm/redhat/config.guess ./config.guess
'/usr/lib/rpm/redhat/config.guess' -> './config.guess'
So why do we need to run autoreconf to update these, if they are replaced anyways ???
That feature has only just landed in Fedora, we filed the bugs long before hand, we're in the process of reviewing all packages that would be fixed by the above feature and those bugs will be closed once we do.
Peter
Hi,
On 05/04/2013 07:50 PM, Peter Robinson wrote:
On Sat, May 4, 2013 at 2:25 PM, Hans de Goede hdegoede@redhat.com wrote:
Hi,
While working on my Fedora packages, I noticed that %configure replaces config.guess and config.sub with /usr/lib/rpm/redhat/config.guess and /usr/lib/rpm/redhat/config.sub, ie:
- for i in '$(find . -name config.guess -o -name config.sub)'
++ basename ./lib-src/libresample/config.guess
- '[' -f /usr/lib/rpm/redhat/config.guess ']'
- /usr/bin/rm -f ./lib-src/libresample/config.guess
++ basename ./lib-src/libresample/config.guess
- /usr/bin/cp -fv /usr/lib/rpm/redhat/config.guess
./lib-src/libresample/config '/usr/lib/rpm/redhat/config.guess' -> './lib-src/libresample/config.guess'
- for i in '$(find . -name config.guess -o -name config.sub)'
++ basename ./config.sub
- '[' -f /usr/lib/rpm/redhat/config.sub ']'
- /usr/bin/rm -f ./config.sub
++ basename ./config.sub
- /usr/bin/cp -fv /usr/lib/rpm/redhat/config.sub ./config.sub
'/usr/lib/rpm/redhat/config.sub' -> './config.sub'
- for i in '$(find . -name config.guess -o -name config.sub)'
++ basename ./config.guess
- '[' -f /usr/lib/rpm/redhat/config.guess ']'
- /usr/bin/rm -f ./config.guess
++ basename ./config.guess
- /usr/bin/cp -fv /usr/lib/rpm/redhat/config.guess ./config.guess
'/usr/lib/rpm/redhat/config.guess' -> './config.guess'
So why do we need to run autoreconf to update these, if they are replaced anyways ???
That feature has only just landed in Fedora, we filed the bugs long before hand, we're in the process of reviewing all packages that would be fixed by the above feature and those bugs will be closed once we do.
Hmm, I can clearly remember rpmbuild doing the same thing in the past (way back in the past I must admit). But given that this is clearly a way better fix then modifying a gazillion packages, I'm glad we've it back!
That does mean I've likely done the work on the 22 packages where I've already added autoreconf calls for nothing, ah well. I guess it is best to probably revert the changes there ?
Are there any cases where this is expected to not be fixed by the new redhat-rpm-config ?
Regards,
Hans
On 05/04/2013 12:19 PM, Hans de Goede wrote:
Hmm, I can clearly remember rpmbuild doing the same thing in the past (way back in the past I must admit). But given that this is clearly a way better fix then modifying a gazillion packages, I'm glad we've it back!
Yes, evidently this feature was around a long time ago but was turned off for some number of years.
That does mean I've likely done the work on the 22 packages where I've already added autoreconf calls for nothing, ah well. I guess it is best to probably revert the changes there ?
Not exactly- it would be preferable if all packagers ran autoreconf as a matter of course. This will ensure future changes to autoconf are picked up, even when building without redhat-rpm-config installed.
Are there any cases where this is expected to not be fixed by the new redhat-rpm-config ?
Anywhere that %configure isn't used will still need to be updated. It's a much smaller list!
-
Brendan Conoboy -
Hans de Goede -
Peter Robinson