[Fedora Build Service] Review request
by Petr Schindler
Hi,
I've made a quick fix to [1]. Here is the patch for review, you can find
it also attached to this mail.
[1] https://fedorahosted.org/fedora-build-service/ticket/9
---------------------PATCH-------------------------------------------
diff --git a/client/imagebuild.py b/client/imagebuild.py
index
78a29d4c6b7bb8cbae6c75f9178d8d11549f6410..1460a0611d32d01891b164aa7209e38b337c9752 100755
--- a/client/imagebuild.py
+++ b/client/imagebuild.py
@@ -102,7 +102,7 @@ def main():
type='choice',
choices=['boot','dvd','live'])
parser.add_option('-w', '--workdir', help='Work directory for the
image builder.',
- dest='workdir',
default=tempfile.gettempdir()+'/imagebuilder_work')
+ dest='workdir',
default='/var/tmp/imagebuilder_work')
parser.add_option('-s', '--staging', help='Staging area (file:///
or ftp://)',
dest='staging', default='file:///'+os.getcwd())
#parser.add_option('-e', '--email', help='Email address for
notification', dest='email')
@@ -120,6 +120,8 @@ def main():
parser.print_help()
sys.exit()
+ #TODO: write some warning if workdir is /tmp (in F18 and above)
+
#check for config file path.
if not os.path.exists(opts.config):
sys.exit('Config file is non-existent')
diff --git a/conf/dvd_imagebuild.conf b/conf/dvd_imagebuild.conf
index
22ff578f5b9bb0cf5d2b11f0d8b2b93a6afb6993..89793343edc31bf942e0bc7cc95f76337228aa6a 100644
--- a/conf/dvd_imagebuild.conf
+++ b/conf/dvd_imagebuild.conf
@@ -16,8 +16,8 @@
config=file:///usr/share/spin-kickstarts/fedora-install-fedora.ks
# sourceisos=0
# force=1
# stage=all (default)
-# destdir=/tmp/dvd_iso
-# cachedir=/tmp/dvd_iso/cache
+# destdir=/var/tmp/dvd_iso
+# cachedir=/var/tmp/dvd_iso/cache
# Additional packages to retrieve from Koji
# Seperated by semicolons;
diff --git a/conf/live_imagebuild.conf b/conf/live_imagebuild.conf
index
551d71ef9828ab7d961eb1e1e32cb1cf6a2f45e9..a5ff4877e12c3e0ebb62e915610ce860c8bf190f 100644
--- a/conf/live_imagebuild.conf
+++ b/conf/live_imagebuild.conf
@@ -18,9 +18,9 @@
config=http://git.fedorahosted.org/cgit/spin-kickstarts.git/tree/fedora-l...
# releasever=rawhide
# nvr=
# bid=
-# tmpdir=/tmp/livework
+# tmpdir=/var/tmp/livework
# cachedir=/var/cache/liveimage
-# logfile=/tmp/liveimage.log
+# logfile=/var/tmp/liveimage.log
# Additional packages to retrieve from Koji
# Seperated by semicolons;
10 years, 3 months
Mailing List Change Proposal
by Tim Flink
There was discussion about where qa development related emails should
go and whether we should create a new qa-devel list for qa tools
discussion or just use autoqa-devel@.
Instead of doing either of those, I propose that we depreciate the
autoqa-devel@ list and move everything related to qa development
(autoqa, blocker tracking app, any other tools) to a new qa-devel@
list. It keeps development discussion off of test@ and doesn't create
another mailing list for people to keep track of since many of us are
involved in more than one area of qa devel.
Thoughts?
Tim
10 years, 3 months
[Fedora Build Service] Why we are developing in develop branch?
by Petr Schindler
Hi,
I'd like to ask, is there any reason for developing in develop branch?
I'm not sure what the right git work flow is, but Kamil was wondering
why we do this. My experience is that I tried master firstly and I came
to develop after Tim told me about it. Wouldn't be better to develop in
master branch?
Thank you
Petr Schindler
10 years, 3 months
[fedora-build-service] #9: default templates use /tmp
by fedora-badges
#9: default templates use /tmp
----------------------------+--------------------------------
Reporter: tflink | Owner: somebody
Type: defect | Status: new
Priority: major | Milestone: Initial Deployment
Component: Image Building | Version:
Keywords: |
----------------------------+--------------------------------
The templates currently in git specify /tmp as working directories for
lorax and pungi. This is fine for F17 and earlier, but with tmpfs in F18,
this can cause problems because /tmp isn't a real filesystem.
This is a simple fix - just substitute /var/tmp for /tmp in the templates.
It might be worth a warning if someone tries to use /tmp as a work
directory but I really don't think that's necessary at this time.
--
Ticket URL: <https://fedorahosted.org/fedora-build-service/ticket/9>
fedora-build-service <https://fedorahosted.org/fedora-build-service>
A service to build fedora images with a somewhat arbitrary package set from the standard fedora repos or builds from koji.
10 years, 3 months
Fedora Gooey Karma
by Tomas Meszaros
I was told by Kamil Paral that autoqa-devel is the right place for devel
stuff related to the Fedora QA.
I announced at the test(a)lists.fedoraproject.org that I'm working on the
Fedora Gooey Karma:
https://lists.fedoraproject.org/pipermail/test/2013-February/113879.html
Currently, the code is at the Github:
https://github.com/examon/fedora-gooey-karma
It's already functional so you can test it. Please notice that I'm new
to the Fedora QA so give me some feedback, request features, etc.
If you would like to participate in any way, I'm at the #fedora-qa under
the nickname examon/exo. Feel free to send me patches, join me at
github, comment, IM me via IRC, e-mail.
--
Tomas Meszaros
10 years, 3 months
Review Request 2: Initial Blocker Review Code
by Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/2/
-----------------------------------------------------------
Review request for blockerbugs.
Changes
-------
This is still a draft code review - it wasn't meant to actually be reviewed yet and I probably should have deleted it. Several of the comments you made have already been fixed in git.
Bugs: 334
https://fedorahosted.org/fedora-qa/ticket/334
Repository: blockerbugs
Description
-------
Initial code for blocker submission page
Diffs
-----
testing/test_bugchange.py PRE-CREATION
init_f18db.sh c20df66c4b4a8f38ab79a1b61043d26de112f71c
init_db.sh PRE-CREATION
blockerbugs/util/bz_interface.py 2bae79db2d3a1206b7de1cee5f005f137ba2d6f3
blockerbugs/templates/thanks.html PRE-CREATION
blockerbugs/templates/propose_bug.html PRE-CREATION
blockerbugs/templates/base_nav.html f3a89798a9dadf297e722c067ad3795a72ebbf74
blockerbugs/controllers/main.py e7525f8433d74802f7c0cb2d719f0abdc13431c4
blockerbugs/controllers/forms.py 669d78a5030904d4559d6d68af093bd6f096888b
blockerbugs/config.py 009e7a97f57e31fcc499dba87fe7d33e41252a2c
blockerbugs/__init__.py ad051ca2523aa70ca2d4d26843e9a2bdf0b5cd00
Diff: http://reviewboard-tflink.rhcloud.com/r/2/diff/
Testing
-------
Thanks,
Tim Flink
10 years, 3 months
Review Request 6: Fixing sync to work with new python-bugzilla and new FE naming convention
by Martin Krizek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-tflink.rhcloud.com/r/6/
-----------------------------------------------------------
Review request for blockerbugs.
Bugs: 331
https://fedorahosted.org/fedora-qa/ticket/331
Repository: blockerbugs
Description
-------
Refactoring templates, bug sync and database to fit with new FreezeException nomenclature
adding alembic upgrade script for db changes
updated bug_sync code for python-bugzilla >= 0.8
Diffs
-----
testing/testfunc_bugsync.py 719b530187a5e3fff7aba72c6776eecaad32cc40
testing/test_bugsync_extract_information.py 47df0e7cd34406aafb7c27f35944d6cff8cb96f3
setup.py e9fc12082a4d16afe93b04d7b96658715403eccc
blockerbugs/util/bz_interface.py 2bae79db2d3a1206b7de1cee5f005f137ba2d6f3
blockerbugs/util/bug_sync.py a85200dae03630d9407d7b27e235eb13c4a5b4a1
blockerbugs/templates/milestone_stats.html 8ff6bc4470967d7eaef633ef8b9b98330eac198b
blockerbugs/templates/milestone_info.html 167dc0b1f5778c75f00e667240d03e8bf817e87a
blockerbugs/templates/irc_format.txt a931c077f88cc998e9464b520a5625d7d9cc7e73
blockerbugs/templates/blocker_list.html 79a8a4b008319e80763f66de3ed6e56df89aa6d8
blockerbugs/templates/admin/modify_release.html 548c3d90c95bfe2a90d5d399d020b7bfcbcffc90
blockerbugs/templates/admin/main.html 121e79f4aa4330cc7b364f835ff2fd61178ac842
blockerbugs/templates/admin/add_release.html d396629f5f30787bbf136c163d24f272371cf06f
blockerbugs/models/milestone.py cad913446157a15079a519fe0c29831b1635dc1f
blockerbugs/models/bug.py dc25f060c470c0ad168e88c981ffe82203ca0d93
blockerbugs/controllers/main.py e7525f8433d74802f7c0cb2d719f0abdc13431c4
blockerbugs/controllers/forms.py 669d78a5030904d4559d6d68af093bd6f096888b
blockerbugs/controllers/admin.py a6c8674820d602577363959be7d4eecd608cdf12
alembic/versions/487cb8ccce92_dropping_flask_login.py PRE-CREATION
alembic/versions/31a6a2f222b7_changing_nth_and_tra.py PRE-CREATION
Diff: http://reviewboard-tflink.rhcloud.com/r/6/diff/
Testing
-------
I've done several syncs on both sqlite and postgres dbs and clicked around to make sure that all the templates that _were_ working are still working. Some of the admin pages still have issues but that is orthogonal to the changes here.
I did an alembic upgrade of the database with no issues.
Thanks,
Tim Flink
10 years, 3 months
