----- Original Message -----
> On Tue, 2011-08-09 at 11:32 -0400, James Laska wrote:
> > Greetings gang,
> >
> > I discovered the following failure while examining cron output for
> > in
> > production. I haven't dug into the issue at all yet, but it seems to
> > be
> > caused by package NVR's that do not contain a %{dist} tag at the
> > end.
> > In this particular case, the package was 'glibc' [1]. I suspect this
> > is
> > not a systemmic problem, but perhaps a conditional check around the
> > get_distro() call? Perhaps something like the following ...
> >
> > diff --git a/tests/initscripts/control.autoqa
> > b/tests/initscripts/control.autoqa
> > index c380c81..d088db1 100644
> > --- a/tests/initscripts/control.autoqa
> > +++ b/tests/initscripts/control.autoqa
> > @@ -9,8 +9,13 @@ labels = ['virt']
> > # must be present (like 'fc13'). If proper label is not
> > found
> > the test will not execute
> > if autoqa_args.has_key('nvrs'):
> > from autoqa.util import get_distro
> > - distro = get_distro(autoqa_args['nvrs'][0])
> > - labels.append(distro)
> > + try:
> > + distro = get_distro(autoqa_args['nvrs'][0])
> > + except IndexError:
> > + # Optionally emit a warning that no %{dist} string was
> > found?
> > + pass
> > + else:
> > + labels.append(distro)
> >
> > # we want to run initscripts just for post-koji-build
> > if event in ['post-koji-build']:
>
> Committed to master. I think this makes sense to cherry-pick into
> 0.6.1
> since it's low impact.
>
>
http://git.fedorahosted.org/git/?p=autoqa.git;a=commitdiff;h=48c64e774b2d...
I don't think that patch is completely OK:
1. We need to adjust it on more places (depcheck uses that too)
2. Why do you catch IndexError? distro_tag() should throw ValueError.
3. We want to set execute=False if we don't find distro tag
I've created a new patch, I'll send it to the list, please comment, thanks.