This is an automatically generated e-mail. To reply, visit: http://reviewboard-tflink.rhcloud.com/r/2/ |
On February 22nd, 2013, 9:24 a.m. UTC, Martin Krizek wrote:
blockerbugs/util/bz_interface.py (Diff revision 1) 185 self.get_bugdata()Just curious, why is this not loaded in the constructor?On February 22nd, 2013, 2:52 p.m. UTC, Tim Flink wrote:
Part of it is a stylistic thing - I don't like constructors that load remote data. I've run into issues in the past with constructors that take too long or load a bunch of data wrt testability. It's not so much of an issue here since the loading can be overridden with a mock bz object but like I said, it's partially a stylistic thing on my part. Do you think that the code would be easier to read or better if that was loaded in the constructor?
Not necessarily. I was just curious if there is another reason other than loading remote data.
- Martin
On February 22nd, 2013, 2:41 p.m. UTC, Tim Flink wrote:
Review request for blockerbugs.
By Tim Flink.
Updated Feb. 22, 2013, 2:41 p.m.
Bugs:
334
Repository:
blockerbugs
Description
Diffs
|