8 Jun
2011
8 Jun
'11
7:53 p.m.
On 06/08/2011 06:25 AM, Kamil Paral wrote:
I had put it into review board in the end:
https://fedorahosted.org/reviewboard/r/151/
I'll update it if some large changes occur in the origin/pretty branch.
Looking forward to your comments!
PS: I'm sure it's not possible to review properly all those changes in every single test. But a review of at least the main library files could help.
I went through and made comments. Overall, it looks really good. I like all of the refactoring to get rid of code duplication.
Tim